From patchwork Fri Feb 15 06:47:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 220663 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-gh0-f188.google.com (mail-gh0-f188.google.com [209.85.160.188]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id F21382C0085 for ; Fri, 15 Feb 2013 17:47:54 +1100 (EST) Received: by mail-gh0-f188.google.com with SMTP id z12sf100621ghb.25 for ; Thu, 14 Feb 2013 22:47:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:x-received:received-spf:x-auditid :from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:x-mailer:thread-index:x-brightmail-tracker :x-brightmail-tracker:dlp-filter:x-mtr:x-cfilter-loop :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:x-google-group-id:list-post :list-help:list-archive:sender:list-subscribe:list-unsubscribe :content-type:content-language; bh=XGCJv/cCWDjUMPNewgpJFfoWqR5Fy95vnMzFu718zBw=; b=ccqYie0959x9fUwb6aqrczk6gBHpwfiJ3clTH+BTrCxouRpG6G/IqWgzka/sOvxWCg nGlADCT96JT7i0rm9TgXLrlRaOsm27o+0nmo05HuY/U62nE2jBEniblSAuYy/NxI8kbG 7qhYbrNdzTRT+pQphSfucYPn6xb8ZlMrft9edly5iOVtfCvjMia8ua3RAk5OlZXZltn0 09ZD+lsb9zO4xLxAEj7cQgW/r8M9k6gmWkv7HjO7RYFYQd8jovHHr2vVVZWMG5pDwE2U 5fQiSU0c8gGUWLH7dPnp7Ooudf+Tj18++Ae+xc41J4oFKVZVpW/EA9grXoewuuiRlkBP Zy3A== X-Received: by 10.50.187.133 with SMTP id fs5mr80810igc.12.1360910872218; Thu, 14 Feb 2013 22:47:52 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.179.72 with SMTP id de8ls330489igc.9.gmail; Thu, 14 Feb 2013 22:47:51 -0800 (PST) X-Received: by 10.67.23.68 with SMTP id hy4mr18943pad.47.1360910871764; Thu, 14 Feb 2013 22:47:51 -0800 (PST) X-Received: by 10.67.23.68 with SMTP id hy4mr18942pad.47.1360910871754; Thu, 14 Feb 2013 22:47:51 -0800 (PST) Received: from mailout2.samsung.com (mailout2.samsung.com. [203.254.224.25]) by gmr-mx.google.com with ESMTP id wc12si615842pbc.1.2013.02.14.22.47.51; Thu, 14 Feb 2013 22:47:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) client-ip=203.254.224.25; Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MI9008CB1JQVE70@mailout2.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 15:47:50 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.49]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 2E.62.05791.61ADD115; Fri, 15 Feb 2013 15:47:50 +0900 (KST) X-AuditID: cbfee690-b7f066d00000169f-c7-511dda162534 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 08.E4.03918.61ADD115; Fri, 15 Feb 2013 15:47:50 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MI9005O91JQ7RC0@mmp2.samsung.com> for rtc-linux@googlegroups.com; Fri, 15 Feb 2013 15:47:50 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' References: <001e01ce0b47$8edd1480$ac973d80$%han@samsung.com> In-reply-to: <001e01ce0b47$8edd1480$ac973d80$%han@samsung.com> Subject: [rtc-linux] [PATCH V2 09/11] rtc: rtc-sun4v: use pr_warn() instead of printk() Date: Fri, 15 Feb 2013 15:47:50 +0900 Message-id: <002701ce0b48$5f5f3930$1e1dab90$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4LR47AXgjtu6e1Qmq7gnKtv11nagAAL34w X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDIsWRmVeSWpSXmKPExsVy+t8zQ12xW7KBBnMn6Vns7+xgdGD02DPx JFsAYxSXTUpqTmZZapG+XQJXRstK7YJjXBW/Dvk2MO7g6GLk5JAQMJFY2r+OBcIWk7hwbz1b FyMXh5DAMkaJHY/WMMEUfZ64jREiMZ1RYuGBTewQzkwmiUnvlrGCVLEJqEl8+XIYKMHBISKg L9HWogFSwyzQyyhxpnc3WFxIwFZi6m1nEJNTwE7i/XRTkE5hAW+JrZu6waawCKhK7No7E8zm BapecvcNM4QtKPFj8j2wQ5kFtCQ2b2tihbDlJTavecsMMlJCQF3i0V9diAOMJNacDYCoEJHY 9+Id2PUSAvPYJRrnPWCBWCUg8W3yIRaIVlmJTQeYIb6VlDi44gbLBEaJWUgWz0KyeBaSxbOQ rFjAyLKKUTS1ILmgOCm9yESvODG3uDQvXS85P3cTIySmJuxgvHfA+hBjMtD6icxSosn5wJjM K4k3NDY2MTMxNTG3NDU3JU1YSZxX/pJMoJBAemJJanZqakFqUXxRaU5q8SFGJg5OqQbGWCGD rbcbF8Zpz5WcE33NR56H6b3Sb14bDZs8S85tOSu8SqTSNh31sGNcYuI0RcTo+Wafo3aTrcrN dp8O3dw8Jf9pFnO+k+r7eSy1d+Omr73jGc3wuLP05vnbK/6sTMoT3vHgjF5bntqN+q1FFny3 Qx6W/l4TdGv/krNi3csuT/57b42HdGimEktxRqKhFnNRcSIAMGkGSb8CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkleLIzCtJLcpLzFFi42I5/e+xoK7YLdlAg0VLtSz2d3YwOjB67Jl4 ki2AMaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH aKySQlliTilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMaNlpXbBMa6KX4d8Gxh3 cHQxcnJICJhIfJ64jRHCFpO4cG89WxcjF4eQwHRGiYUHNrFDODOZJCa9W8YKUsUmoCbx5cth oAQHh4iAvkRbiwZIDbNAL6PEmd7dYHEhAVuJqbedQUxOATuJ99NNQTqFBbwltm7qBpvCIqAq sWvvTDCbF6h6yd03zBC2oMSPyfdYQGxmAS2JzduaWCFseYnNa94yg4yUEFCXePRXF+IAI4k1 ZwMgKkQk9r14xziBUWgWkkGzkAyahWTQLCQtCxhZVjGKphYkFxQnpeca6hUn5haX5qXrJefn bmIER+wzqR2MKxssDjEKcDAq8fAKSMgGCrEmlhVX5h5ilOBgVhLhXRMCFOJNSaysSi3Kjy8q zUktPsSYDPTnRGYp0eR8YDLJK4k3NDYxM7I0MrMwMjE3J01YSZyX8dSTACGB9MSS1OzU1ILU IpgtTBycUg2MEsvCneX+z2LnMM6bdmXp53kV27umbeAsl37kLOdx+tfpFZYG+/e95al4H/TN zSPLLe28hcyKO+mrb3+KdzJak/8oPkQ7dZ368Y1Gd1f9fRrm//Y5Q+qSD8vZ0/fWTd6Vt4l/ 44mNnm+sjtxj7FIuXrCFo57n1vv85TunBWirCXLHb7zh9q++QomlOCPRUIu5qDgRAGNZ2nkc AwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.25 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Fixed the checkpatch warning as below: WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Jingoo Han --- No changes since v1: drivers/rtc/rtc-sun4v.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-sun4v.c b/drivers/rtc/rtc-sun4v.c index 5b22610..59b5c2d 100644 --- a/drivers/rtc/rtc-sun4v.c +++ b/drivers/rtc/rtc-sun4v.c @@ -3,6 +3,8 @@ * Copyright (C) 2008 David S. Miller */ +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + #include #include #include @@ -26,10 +28,10 @@ retry: udelay(100); goto retry; } - printk(KERN_WARNING "SUN4V: tod_get() timed out.\n"); + pr_warn("tod_get() timed out.\n"); return 0; } - printk(KERN_WARNING "SUN4V: tod_get() not supported.\n"); + pr_warn("tod_get() not supported.\n"); return 0; } @@ -53,10 +55,10 @@ retry: udelay(100); goto retry; } - printk(KERN_WARNING "SUN4V: tod_set() timed out.\n"); + pr_warn("tod_set() timed out.\n"); return -EAGAIN; } - printk(KERN_WARNING "SUN4V: tod_set() not supported.\n"); + pr_warn("tod_set() not supported.\n"); return -EOPNOTSUPP; }