diff mbox

[09/10] rtc: rtc-sirfsoc: Remove unnecessary OOM messages

Message ID 001201cf23dc$4c8cd8f0$e5a68ad0$%han@samsung.com
State Accepted
Headers show

Commit Message

Jingoo Han Feb. 7, 2014, 8:12 a.m. UTC
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/rtc/rtc-sirfsoc.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Barry Song Feb. 7, 2014, 12:08 p.m. UTC | #1
2014-02-07 16:12 GMT+08:00 Jingoo Han <jg1.han@samsung.com>:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---

Acked-by: Barry Song <Baohua.Song@csr.com>

>  drivers/rtc/rtc-sirfsoc.c |    6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/rtc/rtc-sirfsoc.c b/drivers/rtc/rtc-sirfsoc.c
> index 3eb3642..9e3cbce 100644
> --- a/drivers/rtc/rtc-sirfsoc.c
> +++ b/drivers/rtc/rtc-sirfsoc.c
> @@ -264,12 +264,8 @@ static int sirfsoc_rtc_probe(struct platform_device *pdev)
>
>         rtcdrv = devm_kzalloc(&pdev->dev,
>                 sizeof(struct sirfsoc_rtc_drv), GFP_KERNEL);
> -       if (rtcdrv == NULL) {
> -               dev_err(&pdev->dev,
> -                       "%s: can't alloc mem for drv struct\n",
> -                       pdev->name);
> +       if (rtcdrv == NULL)
>                 return -ENOMEM;
> -       }
>
>         err = of_property_read_u32(np, "reg", &rtcdrv->rtc_base);
>         if (err) {
> --
> 1.7.10.4
>
>
-barry
diff mbox

Patch

diff --git a/drivers/rtc/rtc-sirfsoc.c b/drivers/rtc/rtc-sirfsoc.c
index 3eb3642..9e3cbce 100644
--- a/drivers/rtc/rtc-sirfsoc.c
+++ b/drivers/rtc/rtc-sirfsoc.c
@@ -264,12 +264,8 @@  static int sirfsoc_rtc_probe(struct platform_device *pdev)
 
 	rtcdrv = devm_kzalloc(&pdev->dev,
 		sizeof(struct sirfsoc_rtc_drv), GFP_KERNEL);
-	if (rtcdrv == NULL) {
-		dev_err(&pdev->dev,
-			"%s: can't alloc mem for drv struct\n",
-			pdev->name);
+	if (rtcdrv == NULL)
 		return -ENOMEM;
-	}
 
 	err = of_property_read_u32(np, "reg", &rtcdrv->rtc_base);
 	if (err) {