From patchwork Mon Apr 1 09:42:02 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 232691 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ye0-f188.google.com (mail-ye0-f188.google.com [209.85.213.188]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 79E042C0109 for ; Mon, 1 Apr 2013 20:42:07 +1100 (EST) Received: by mail-ye0-f188.google.com with SMTP id m15sf898460yen.15 for ; Mon, 01 Apr 2013 02:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=x-received:x-beenthere:x-received:received-spf:x-auditid:from:to:cc :subject:date:message-id:mime-version:x-mailer:thread-index :x-brightmail-tracker:x-brightmail-tracker:dlp-filter:x-mtr :x-cfilter-loop:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:x-google-group-id :list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-language; bh=UCluQFbvMwoDei514mtAmzafrJnwI7aWLtHQ6pLtdVU=; b=MV48TGkOnMXDHbKoTtFR+MqydB6MxZnGRmHsibsfMrKGiwKpDVCm8tQjSoyZpPx7Ge XSTHY0McTjvt6bfHjVd6NT1b1FT1qzP9+rR6rGoYFIqUFM/997QbNqiYITOCc00zN2pl 7VOkNZ20RmAz3FC8zLDbcQQ51ojqNTsPeWH4XgOgagve7MnDcSgoGB1qxkfzCfXKM2KS A/39xznNCiJ9bN7Zf9wykMc/YVtstF16lJOfTbPA2Uk03PW4MMsiH/XqSh5gnEJVnhkI YfbmA+Ki9j/696zHnUBccQ5og93nhqzz/sVWPzhxroQ20cd46FAoAQgQK/PX3eQ3JlGu we8A== X-Received: by 10.50.160.132 with SMTP id xk4mr510096igb.7.1364809324692; Mon, 01 Apr 2013 02:42:04 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.27.70 with SMTP id r6ls885613igg.14.canary; Mon, 01 Apr 2013 02:42:04 -0700 (PDT) X-Received: by 10.67.1.131 with SMTP id bg3mr2070502pad.29.1364809324273; Mon, 01 Apr 2013 02:42:04 -0700 (PDT) Received: from mailout3.samsung.com (mailout3.samsung.com. [203.254.224.33]) by gmr-mx.google.com with ESMTP id xb6si2212603pab.0.2013.04.01.02.42.04; Mon, 01 Apr 2013 02:42:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) client-ip=203.254.224.33; Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MKK00DQKLM3VEW0@mailout3.samsung.com> for rtc-linux@googlegroups.com; Mon, 01 Apr 2013 18:42:03 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.49]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 3C.05.02019.B6659515; Mon, 01 Apr 2013 18:42:03 +0900 (KST) X-AuditID: cbfee690-b7f656d0000007e3-93-5159566b7bae Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id DC.D2.17838.B6659515; Mon, 01 Apr 2013 18:42:03 +0900 (KST) Received: from DOJG1HAN02 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MKK00B64LM22240@mmp1.samsung.com>; Mon, 01 Apr 2013 18:42:03 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' Subject: [rtc-linux] [PATCH 01/27] rtc: rtc-ab8500: use devm_*() functions Date: Mon, 01 Apr 2013 18:42:02 +0900 Message-id: <000c01ce2ebd$2a1307f0$7e3917d0$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac4uvSmu8Ej3RSKpRZmzfFm2iz9KEw== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsVy+t8zQ93ssMhAg5M/hSyWXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjeKySUnNySxL LdK3S+DKONgyh7ngAU/F9H23mBoYT3B1MXJySAiYSKw/eIINwhaTuHBvPZDNxSEksIxR4nDr R2aYogVrjrFAJBYxSrzcf5oZwvnFKHH2zhUWkCo2ATWJL18Os3cxcnCICOhLtLVogNQwC/Qy Spzp3c0OUiMsYCfx7t0esBoWAVWJya/BFvAK2Eq8bf/FBGELSvyYfA9sJLOAlsT6nceZIGx5 ic1r3jKDtEoIqEs8+qsLEhYR0JN4vugNO0SJiMS+F+8YQdZKCBxjlzjy7yvYHBYBAYlvkw+x QPTKSmw6APWXpMTBFTdYJjCKzUKyeRaSzbOQbJ6FZMUCRpZVjKKpBckFxUnpRSZ6xYm5xaV5 6XrJ+bmbGCGRN2EH470D1ocYk4HWT2SWEk3OB0ZuXkm8obGZkYWpiamxkbmlGWnCSuK86i3W gUIC6YklqdmpqQWpRfFFpTmpxYcYmTg4pRoY7W1fvn75bdmXf0efzfA7uPrgsWIGndI92uv3 y8/+ffuy/52qqCNBfAei78q6zfAt1P+/O4Tl8dSXb/J3TFI+66yxWj30ifunSoF5HyrW7pl4 /JwbR5WivpBv75HX6qIJe49/OqN3l5XhmYgiV5tdy33drBv6VgFlsReXxO9wLHk1iWXe0ms1 k5RYijMSDbWYi4oTAUX6Pm3SAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDKsWRmVeSWpSXmKPExsVy+t9jAd3ssMhAg41z+CyWXLzKbjFn/Ro2 i8sLL7FaXN41h81if2cHowOrx56JJ9k8Tsz4zeLRt2UVo8f0eT+ZPD5vkgtgjWpgtMlITUxJ LVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1y8wB2q6kUJaYUwoUCkgs LlbSt8M0ITTETdcCpjFC1zckCK7HyAANJKxjzDjYMoe54AFPxfR9t5gaGE9wdTFyckgImEgs WHOMBcIWk7hwbz1bFyMXh5DAIkaJl/tPM0M4vxglzt65AlbFJqAm8eXLYfYuRg4OEQF9ibYW DZAaZoFeRokzvbvZQWqEBewk3r3bA1bDIqAqMfk1M0iYV8BW4m37LyYIW1Dix+R7YCOZBbQk 1u88zgRhy0tsXvOWGaRVQkBd4tFfXZCwiICexPNFb9ghSkQk9r14xziBUWAWkkmzkEyahWTS LCQtCxhZVjGKphYkFxQnpeca6hUn5haX5qXrJefnbmIEx/UzqR2MKxssDjEKcDAq8fBGXIgI FGJNLCuuzD3EKMHBrCTC6/MNKMSbklhZlVqUH19UmpNafIgxGejPicxSosn5wJSTVxJvaGxi ZmRpZGZhZGJuTpqwkjjvgVbrQCGB9MSS1OzU1ILUIpgtTBycUg2MnNuj+e1ygiZkbTU/YrF+ ofWaykgHPkGL0w4xfKyOHZHKpY7n1mYeOZX2qYY/0UXigxV/bOqT2y2OLPKL1OfGn+++6L6m hXnX2v6YCBuVrp3sTMFq2U3d3sXT4wTvBUwOv7a0omnZXVfxM+F1cXdmP613CV7Y+F7mUKBS ypLohF2rVvpMnqzEUpyRaKjFXFScCAC8uip7LwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.33 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Use devm_*() functions to make cleanup paths simpler. Signed-off-by: Jingoo Han --- drivers/rtc/rtc-ab8500.c | 18 ++++++------------ 1 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c index 57cde2b..63cfa31 100644 --- a/drivers/rtc/rtc-ab8500.c +++ b/drivers/rtc/rtc-ab8500.c @@ -422,20 +422,19 @@ static int ab8500_rtc_probe(struct platform_device *pdev) device_init_wakeup(&pdev->dev, true); - rtc = rtc_device_register("ab8500-rtc", &pdev->dev, &ab8500_rtc_ops, - THIS_MODULE); + rtc = devm_rtc_device_register(&pdev->dev, "ab8500-rtc", + &ab8500_rtc_ops, THIS_MODULE); if (IS_ERR(rtc)) { dev_err(&pdev->dev, "Registration failed\n"); err = PTR_ERR(rtc); return err; } - err = request_threaded_irq(irq, NULL, rtc_alarm_handler, - IRQF_NO_SUSPEND | IRQF_ONESHOT, "ab8500-rtc", rtc); - if (err < 0) { - rtc_device_unregister(rtc); + err = devm_request_threaded_irq(&pdev->dev, irq, NULL, + rtc_alarm_handler, IRQF_NO_SUSPEND | IRQF_ONESHOT, + "ab8500-rtc", rtc); + if (err < 0) return err; - } platform_set_drvdata(pdev, rtc); @@ -450,13 +449,8 @@ static int ab8500_rtc_probe(struct platform_device *pdev) static int ab8500_rtc_remove(struct platform_device *pdev) { - struct rtc_device *rtc = platform_get_drvdata(pdev); - int irq = platform_get_irq_byname(pdev, "ALARM"); - ab8500_sysfs_rtc_unregister(&pdev->dev); - free_irq(irq, rtc); - rtc_device_unregister(rtc); platform_set_drvdata(pdev, NULL); return 0;