diff mbox

[01/10] rtc: rtc-at32ap700x: Remove unnecessary OOM messages

Message ID 000a01cf23da$e2b2e010$a818a030$%han@samsung.com
State Accepted
Headers show

Commit Message

Jingoo Han Feb. 7, 2014, 8:02 a.m. UTC
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/rtc/rtc-at32ap700x.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Hans-Christian Noren Egtvedt Feb. 7, 2014, 8:04 a.m. UTC | #1
Around Fri 07 Feb 2014 17:02:02 +0900 or thereabout, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.

Thanks for cleaning up.

> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>

Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>

> ---
>  drivers/rtc/rtc-at32ap700x.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-at32ap700x.c b/drivers/rtc/rtc-at32ap700x.c
> index 3161ab5..aee3387 100644
> --- a/drivers/rtc/rtc-at32ap700x.c
> +++ b/drivers/rtc/rtc-at32ap700x.c
> @@ -204,10 +204,8 @@ static int __init at32_rtc_probe(struct platform_device *pdev)
>  
>  	rtc = devm_kzalloc(&pdev->dev, sizeof(struct rtc_at32ap700x),
>  			   GFP_KERNEL);
> -	if (!rtc) {
> -		dev_dbg(&pdev->dev, "out of memory\n");
> +	if (!rtc)
>  		return -ENOMEM;
> -	}
>  
>  	regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	if (!regs) {
diff mbox

Patch

diff --git a/drivers/rtc/rtc-at32ap700x.c b/drivers/rtc/rtc-at32ap700x.c
index 3161ab5..aee3387 100644
--- a/drivers/rtc/rtc-at32ap700x.c
+++ b/drivers/rtc/rtc-at32ap700x.c
@@ -204,10 +204,8 @@  static int __init at32_rtc_probe(struct platform_device *pdev)
 
 	rtc = devm_kzalloc(&pdev->dev, sizeof(struct rtc_at32ap700x),
 			   GFP_KERNEL);
-	if (!rtc) {
-		dev_dbg(&pdev->dev, "out of memory\n");
+	if (!rtc)
 		return -ENOMEM;
-	}
 
 	regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	if (!regs) {