From patchwork Fri Feb 7 07:57:42 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 317626 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ve0-x238.google.com (mail-ve0-x238.google.com [IPv6:2607:f8b0:400c:c01::238]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 6C3252C00A1 for ; Fri, 7 Feb 2014 18:57:49 +1100 (EST) Received: by mail-ve0-f184.google.com with SMTP id db12sf747759veb.21 for ; Thu, 06 Feb 2014 23:57:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:thread-index:dlp-filter:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type:content-language; bh=xDSTL6QBlna0x7EgmlnRv7VkhkcH0rzVwfzBmZZOZ7E=; b=Z8HwM6kJqZSHF05bJyelU4pEnOUPZG0fLXn/BHnrNc/l6t5ulo9nqMKq2wpjVmCvv5 FahikvV1e1FjS/QxLp+aO7keMDWaFw+gAIBGmetkO9H8287vpE1jDWkVZMmhyUQlEc/A 9ykqw2wDQu/h5DwkOw9LHcoSNEkpX/NBDDsPEc2MGQlAqLmkrNEFKTPrlZ5x+UHACjWS p09KLQhzB8GClQo/VxMYdrsFQesHUREz/Y9FJZ1z0J3OZA/ilOuGn1NG9LL5ACENXu6K cy+Aj3BhsUGwLl3f+y2SIjR0NcQBBZSwBUcNhz3lGTkDYTCqGq5PcaV/O0FWy9Zr2DM2 tZeQ== X-Received: by 10.50.222.166 with SMTP id qn6mr71490igc.16.1391759865074; Thu, 06 Feb 2014 23:57:45 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.50.79.227 with SMTP id m3ls521958igx.23.canary; Thu, 06 Feb 2014 23:57:44 -0800 (PST) X-Received: by 10.66.189.163 with SMTP id gj3mr2134397pac.32.1391759864810; Thu, 06 Feb 2014 23:57:44 -0800 (PST) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by gmr-mx.google.com with ESMTPS id ox2si1263719pbc.1.2014.02.06.23.57.44 for (version=TLSv1 cipher=RC4-MD5 bits=128/128); Thu, 06 Feb 2014 23:57:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) client-ip=203.254.224.34; Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N0M005AR8S7QNE0@mailout4.samsung.com> for rtc-linux@googlegroups.com; Fri, 07 Feb 2014 16:57:43 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.49]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 8E.C4.10364.7F194F25; Fri, 07 Feb 2014 16:57:43 +0900 (KST) X-AuditID: cbfee690-b7f266d00000287c-57-52f491f75571 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 0B.C8.29263.6F194F25; Fri, 07 Feb 2014 16:57:43 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N0M00C468S67S20@mmp2.samsung.com>; Fri, 07 Feb 2014 16:57:42 +0900 (KST) From: Jingoo Han To: 'Andrew Morton' Cc: linux-kernel@vger.kernel.org, 'Alessandro Zummo' , rtc-linux@googlegroups.com, 'Jingoo Han' , 'Kevin Hilman' References: <000401cf23d9$d1df6e30$759e4a90$%han@samsung.com> In-reply-to: <000401cf23d9$d1df6e30$759e4a90$%han@samsung.com> Subject: [rtc-linux] [PATCH 2/4] rtc: rtc-davinci: Use devm_ioremap_resource() Date: Fri, 07 Feb 2014 16:57:42 +0900 Message-id: <000601cf23da$477dc060$d6794120$%han@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac8j2dGo+e7pmAi4QKyN7t2QoeNN8wAAB/Bg X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAIsWRmVeSWpSXmKPExsVy+t8zQ93vE78EGTx/zWax5OJVdos569ew WVxeeInV4uvhFYwWl3fNYbPY39nB6MDmsWfiSTaPO9f2sHmcmPGbxaNvyypGj+nzfjJ5fN4k F8AWxWWTkpqTWZZapG+XwJXx9cExloI7/BUX5/QwNTD+4Oli5OSQEDCRWHh7MhOELSZx4d56 ti5GLg4hgWWMEq+OP2CGKTpz6QQjiC0kMJ1RonlBFkTRL0aJOX2TWEASbAJqEl++HGbvYuTg EBHQl2hr0QCpYRbYwihx6eMydohmW4mFLzvBhnIK2En07+ljBakXFnCS6OllBQmzCKhKbLx7 FmwXL1D5m6u3oWxBiR+T74GtYhbQkli/8zgThC0vsXnNW2aQMRIC6hKP/uqChEUEjCQmH/nE ClEiIrHvxTtGkHMkBD6yS6zZfxJql4DEt8mHWCB6ZSU2HYB6V1Li4IobLBMYJWYh2TwLyeZZ SDbPQrJiASPLKkbR1ILkguKk9CITveLE3OLSvHS95PzcTYyQ2J2wg/HeAetDjMlA6ycyS4km 5wNjP68k3tDYzMjC1MTU2Mjc0ow0YSVxXrVHSUFCAumJJanZqakFqUXxRaU5qcWHGJk4OKUa GJX/xrU+/+ckfmpyWG/aBf1Oi7TznW0J1X5mtt9OBzhMk5vE53C+wbX8S8SKOVv1nmvnBvlJ 5VyamSsWI/s5IE9ldejpBdNfa9258EgxasMKj76JQSFPXsdxfDc+V+8vZ/RXdM2VaXdTQuzS 9nb/VxbZ9vqi+rOEg+Y8ZSeyH/8WNJn49843FSWW4oxEQy3mouJEAEJqYG/zAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLKsWRmVeSWpSXmKPExsVy+t9jQd3vE78EGex4zGSx5OJVdos569ew WVxeeInV4uvhFYwWl3fNYbPY39nB6MDmsWfiSTaPO9f2sHmcmPGbxaNvyypGj+nzfjJ5fN4k F8AW1cBok5GamJJapJCal5yfkpmXbqvkHRzvHG9qZmCoa2hpYa6kkJeYm2qr5OIToOuWmQN0 h5JCWWJOKVAoILG4WEnfDtOE0BA3XQuYxghd35AguB4jAzSQsI4x4+uDYywFd/grLs7pYWpg /MHTxcjJISFgInHm0glGCFtM4sK99WwgtpDAdEaJ5gVZXYxcQPYvRok5fZNYQBJsAmoSX74c Zu9i5OAQEdCXaGvRAKlhFtjCKHHp4zJ2iGZbiYUvO5lBbE4BO4n+PX2sIPXCAk4SPb2sIGEW AVWJjXfPgu3lBSp/c/U2lC0o8WPyPbBVzAJaEut3HmeCsOUlNq95ywwyRkJAXeLRX12QsIiA kcTkI59YIUpEJPa9eMc4gVFoFpJJs5BMmoVk0iwkLQsYWVYxiqYWJBcUJ6XnGuoVJ+YWl+al 6yXn525iBCeGZ1I7GFc2WBxiFOBgVOLhPbH0c5AQa2JZcWXuIUYJDmYlEd6fDV+ChHhTEiur Uovy44tKc1KLDzEmAz06kVlKNDkfmLTySuINjU3MjCyNzCyMTMzNSRNWEuc90GodKCSQnliS mp2aWpBaBLOFiYNTqoFR3TR31v9pS80WixVa6SuuzTwlGTjpUvaRymkZv0qffmJY739MN9fx 9mR/5j3iz/M6clIi/r15UJsteP2up0fPgeXqN9Y/W1e8QNKl6X3E/P2sJVnxG7m9TOyYdY10 9KxmvxJZFup925nNUbPdWkTIQ0X5mkw++6LAxr3C1S2ds+c5cnsJlyixFGckGmoxFxUnAgDX kmOAUAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-Original-Sender: jg1.han@samsung.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of jg1.han@samsung.com designates 203.254.224.34 as permitted sender) smtp.mail=jg1.han@samsung.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , Content-type: text/plain; charset=ISO-8859-1 Content-language: ko Use devm_ioremap_resource() in order to make the code simpler, and remove redundant return value check of platform_get_resource() because the value is checked by devm_ioremap_resource(). Signed-off-by: Jingoo Han --- drivers/rtc/rtc-davinci.c | 29 ++++------------------------- 1 file changed, 4 insertions(+), 25 deletions(-) diff --git a/drivers/rtc/rtc-davinci.c b/drivers/rtc/rtc-davinci.c index 24677ef8..d3e70f3 100644 --- a/drivers/rtc/rtc-davinci.c +++ b/drivers/rtc/rtc-davinci.c @@ -119,8 +119,6 @@ static DEFINE_SPINLOCK(davinci_rtc_lock); struct davinci_rtc { struct rtc_device *rtc; void __iomem *base; - resource_size_t pbase; - size_t base_size; int irq; }; @@ -482,7 +480,7 @@ static int __init davinci_rtc_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct davinci_rtc *davinci_rtc; - struct resource *res, *mem; + struct resource *res; int ret = 0; davinci_rtc = devm_kzalloc(&pdev->dev, sizeof(struct davinci_rtc), GFP_KERNEL); @@ -498,28 +496,9 @@ static int __init davinci_rtc_probe(struct platform_device *pdev) } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(dev, "no mem resource\n"); - return -EINVAL; - } - - davinci_rtc->pbase = res->start; - davinci_rtc->base_size = resource_size(res); - - mem = devm_request_mem_region(dev, davinci_rtc->pbase, - davinci_rtc->base_size, pdev->name); - if (!mem) { - dev_err(dev, "RTC registers at %08x are not free\n", - davinci_rtc->pbase); - return -EBUSY; - } - - davinci_rtc->base = devm_ioremap(dev, davinci_rtc->pbase, - davinci_rtc->base_size); - if (!davinci_rtc->base) { - dev_err(dev, "unable to ioremap MEM resource\n"); - return -ENOMEM; - } + davinci_rtc->base = devm_ioremap_resource(dev, res); + if (IS_ERR(davinci_rtc->base)) + return PTR_ERR(davinci_rtc->base); platform_set_drvdata(pdev, davinci_rtc);