mbox series

[v3,0/2] Add a driver for Epson RX8111 RTC

Message ID cover.1700491765.git.waqar.hameed@axis.com
Headers show
Series Add a driver for Epson RX8111 RTC | expand

Message

Waqar Hameed Nov. 20, 2023, 2:49 p.m. UTC 
In this patch series we add a basic driver for Epson RX8111 RTC with
support for only reading/writing the time and the `ioctl`s `RTC_VL_READ`
and `RTC_VL_CLR`.

Datasheet: https://support.epson.biz/td/api/doc_check.php?dl=app_RX8111CE&lang=en

Changes in v3:
* Remove macro define `RX8111_DRV_NAME` for the driver name.
* Remove macro function `RX8111_TIME_BUF_IDX` and instead use the
  offsets as indices directly.
* Remove `rx8111_setup()` that disabled extended functionality and
  interrupts.
* Remove comments explaining register value conversions in
  `rx8111_read/set_time()`.
* Check/clear register flag XST (oscillation stoppage) in
  `rx8111_read/set_time()`.
* Change `vlval` to `unsigned int` in `rx8111_ioctl()`.
* Remove `case RTC_VL_CLR` in `rx8111_ioctl()`.
* Convert all `dev_err()` to `dev_dbg()`.
* Convert all `dev_err_probe()` to `dev_dbg()` in probe.
* Return without printing from `devm_rtc_register_device()` in probe.

Link to v2: https://lore.kernel.org/lkml/cover.1692699931.git.waqar.hameed@axis.com/

Changes in v2:
* Move dt-bindings to `trivial-rtc.yaml`.

Link to v1: https://lore.kernel.org/lkml/cover.1691158774.git.waqar.hameed@axis.com/

Waqar Hameed (2):
  dt-bindings: rtc: Add Epson RX8111
  rtc: Add driver for Epson RX8111

 .../devicetree/bindings/rtc/trivial-rtc.yaml  |   1 +
 drivers/rtc/Kconfig                           |  10 +
 drivers/rtc/Makefile                          |   1 +
 drivers/rtc/rtc-rx8111.c                      | 356 ++++++++++++++++++
 4 files changed, 368 insertions(+)
 create mode 100644 drivers/rtc/rtc-rx8111.c


base-commit: 98b1cc82c4affc16f5598d4fa14b1858671b2263

Comments

Alexandre Belloni April 17, 2024, 6:08 p.m. UTC | #1 
On Mon, 20 Nov 2023 15:49:25 +0100, Waqar Hameed wrote:
> In this patch series we add a basic driver for Epson RX8111 RTC with
> support for only reading/writing the time and the `ioctl`s `RTC_VL_READ`
> and `RTC_VL_CLR`.
> 
> Datasheet: https://support.epson.biz/td/api/doc_check.php?dl=app_RX8111CE&lang=en
> 
> Changes in v3:
> * Remove macro define `RX8111_DRV_NAME` for the driver name.
> * Remove macro function `RX8111_TIME_BUF_IDX` and instead use the
>   offsets as indices directly.
> * Remove `rx8111_setup()` that disabled extended functionality and
>   interrupts.
> * Remove comments explaining register value conversions in
>   `rx8111_read/set_time()`.
> * Check/clear register flag XST (oscillation stoppage) in
>   `rx8111_read/set_time()`.
> * Change `vlval` to `unsigned int` in `rx8111_ioctl()`.
> * Remove `case RTC_VL_CLR` in `rx8111_ioctl()`.
> * Convert all `dev_err()` to `dev_dbg()`.
> * Convert all `dev_err_probe()` to `dev_dbg()` in probe.
> * Return without printing from `devm_rtc_register_device()` in probe.
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: rtc: Add Epson RX8111
      https://git.kernel.org/abelloni/c/c6a2fb6d14bf
[2/2] rtc: Add driver for Epson RX8111
      https://git.kernel.org/abelloni/c/f8c81d15f4bb

Best regards,