mbox series

[v3,0/4] Introduce STM32MP1 RTC

Message ID 1526558666-24243-1-git-send-email-amelie.delaunay@st.com
Headers show
Series Introduce STM32MP1 RTC | expand

Message

Amelie DELAUNAY May 17, 2018, 12:04 p.m. UTC
This series introduces STM32MP1 RTC.
On STM32MP1:
- two clocks are needed, plck and rtc_ck;
- to wakeup the system, a wakeup alarm interrupt is needed;
- some registers or bits have moved, but the operation is the same;
- the Backup Domain Protection (DBP) is not managed by RTC driver.

---
Changes in v3:
* Move cleanup changes in a separate patch
* Replace regs and evts by pointers to ensure no copy is made
* Set all registers offset as u16 instead of u8 and u16
* Fix Kbuild smatch warning:
  drivers/rtc/rtc-stm32.c:827 stm32_rtc_probe()
  warn: always true condition '(regs.verr != ~0) => (0-u16max != (-1))'

Changes in v2:
* One compatible per line in bindings file
* Remove unnecessary comment under rtc_ck as this clock is required for all
* Remove interrupts-extended and add stm32mp1 rtc alarm wakeup interrupt in
  interrupts property description

Amelie Delaunay (4):
  rtc: stm32: fix misspelling and misalignment issues
  rtc: stm32: rework register management to prepare other version of RTC
  dt-bindings: rtc: update stm32-rtc documentation for stm32mp1 rtc
  rtc: stm32: add stm32mp1 rtc support

 .../devicetree/bindings/rtc/st,stm32-rtc.txt       |  27 +-
 drivers/rtc/rtc-stm32.c                            | 273 ++++++++++++++++-----
 2 files changed, 229 insertions(+), 71 deletions(-)

Comments

Alexandre Belloni May 22, 2018, 6:11 p.m. UTC | #1
On 17/05/2018 14:04:22+0200, Amelie Delaunay wrote:
> This series introduces STM32MP1 RTC.
> On STM32MP1:
> - two clocks are needed, plck and rtc_ck;
> - to wakeup the system, a wakeup alarm interrupt is needed;
> - some registers or bits have moved, but the operation is the same;
> - the Backup Domain Protection (DBP) is not managed by RTC driver.
> 
> ---
> Changes in v3:
> * Move cleanup changes in a separate patch
> * Replace regs and evts by pointers to ensure no copy is made
> * Set all registers offset as u16 instead of u8 and u16
> * Fix Kbuild smatch warning:
>   drivers/rtc/rtc-stm32.c:827 stm32_rtc_probe()
>   warn: always true condition '(regs.verr != ~0) => (0-u16max != (-1))'
> 
> Changes in v2:
> * One compatible per line in bindings file
> * Remove unnecessary comment under rtc_ck as this clock is required for all
> * Remove interrupts-extended and add stm32mp1 rtc alarm wakeup interrupt in
>   interrupts property description
> 
> Amelie Delaunay (4):
>   rtc: stm32: fix misspelling and misalignment issues
>   rtc: stm32: rework register management to prepare other version of RTC
>   dt-bindings: rtc: update stm32-rtc documentation for stm32mp1 rtc
>   rtc: stm32: add stm32mp1 rtc support
> 
>  .../devicetree/bindings/rtc/st,stm32-rtc.txt       |  27 +-
>  drivers/rtc/rtc-stm32.c                            | 273 ++++++++++++++++-----
>  2 files changed, 229 insertions(+), 71 deletions(-)
> 

Applied, thanks.