From patchwork Mon Mar 21 13:09:20 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Shah X-Patchwork-Id: 87777 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 3BB09B6F77 for ; Tue, 22 Mar 2011 00:20:34 +1100 (EST) Received: from localhost ([127.0.0.1]:41988 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q1f21-00024Z-EZ for incoming@patchwork.ozlabs.org; Mon, 21 Mar 2011 09:20:25 -0400 Received: from [140.186.70.92] (port=40654 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q1erf-0005AO-W7 for qemu-devel@nongnu.org; Mon, 21 Mar 2011 09:09:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q1ere-0007Pr-GF for qemu-devel@nongnu.org; Mon, 21 Mar 2011 09:09:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q1ere-0007Ph-4t for qemu-devel@nongnu.org; Mon, 21 Mar 2011 09:09:42 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2LD9eJZ012362 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 21 Mar 2011 09:09:40 -0400 Received: from localhost (dhcp193-58.pnq.redhat.com [10.65.193.58]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p2LD9dRk025405; Mon, 21 Mar 2011 09:09:40 -0400 From: Amit Shah To: Anthony Liguori Date: Mon, 21 Mar 2011 18:39:20 +0530 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: Amit Shah , qemu list Subject: [Qemu-devel] [PATCH 5/7] virtio-serial: Don't clear ->have_data() pointer after unplug X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org After a port unplug operation, the port->info->have_data() pointer was set to NULL. The problem is, the ->info struct is shared by all ports, effectively disabling writes to other ports. Reported-by: juzhang Signed-off-by: Amit Shah --- hw/virtio-console.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index 4440784..be59558 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console.c @@ -82,7 +82,6 @@ static int virtconsole_exitfn(VirtIOSerialPort *port) VirtConsole *vcon = DO_UPCAST(VirtConsole, port, port); if (vcon->chr) { - port->info->have_data = NULL; qemu_chr_close(vcon->chr); }