From patchwork Fri Nov 20 12:09:22 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 546927 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id A69A91402D6 for ; Sat, 21 Nov 2015 00:46:04 +1100 (AEDT) Received: from localhost ([::1]:47419 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zzm0o-0006gN-Fe for incoming@patchwork.ozlabs.org; Fri, 20 Nov 2015 08:46:02 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zzm0O-0006Ol-AY for qemu-devel@nongnu.org; Fri, 20 Nov 2015 08:45:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zzm0K-0005d5-PA for qemu-devel@nongnu.org; Fri, 20 Nov 2015 08:45:36 -0500 Received: from mail-cys01nam02on0056.outbound.protection.outlook.com ([104.47.37.56]:33152 helo=NAM02-CY1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zzm0K-0005c7-JY for qemu-devel@nongnu.org; Fri, 20 Nov 2015 08:45:32 -0500 Received: from CY1NAM02FT026.eop-nam02.prod.protection.outlook.com (10.152.74.57) by CY1NAM02HT092.eop-nam02.prod.protection.outlook.com (10.152.75.81) with Microsoft SMTP Server (TLS) id 15.1.331.11; Fri, 20 Nov 2015 12:11:27 +0000 Authentication-Results: spf=fail (sender IP is 149.199.60.96) smtp.mailfrom=xilinx.com; redhat.com; dkim=none (message not signed) header.d=none; redhat.com; dmarc=none action=none header.from=xilinx.com; Received-SPF: Fail (protection.outlook.com: domain of xilinx.com does not designate 149.199.60.96 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.96; helo=xsj-tvapsmtpgw01; Received: from xsj-tvapsmtpgw01 (149.199.60.96) by CY1NAM02FT026.mail.protection.outlook.com (10.152.75.157) with Microsoft SMTP Server (TLS) id 15.1.331.11 via Frontend Transport; Fri, 20 Nov 2015 12:11:27 +0000 Received: from 172-16-1-203.xilinx.com ([172.16.1.203]:40949 helo=xsj-tvapsmtp02.xilinx.com) by xsj-tvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1ZzkXG-0003po-N6; Fri, 20 Nov 2015 04:11:26 -0800 Received: from [127.0.0.1] (port=47671 helo=tsj-smtp-dlp1.xlnx.xilinx.com) by xsj-tvapsmtp02.xilinx.com with esmtp (Exim 4.63) (envelope-from ) id 1ZzkXG-0003Qt-Ha; Fri, 20 Nov 2015 04:11:26 -0800 Received: from xsj-tvapsmtp02 (xsj-tvapsmtp02.xilinx.com [172.16.1.203]) by tsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id tAKC6DkU019604; Fri, 20 Nov 2015 04:06:13 -0800 Received: from [172.19.74.182] (port=36126 helo=xsjalistai50.xlnx.xilinx.com) by xsj-tvapsmtp02 with esmtp (Exim 4.63) (envelope-from ) id 1ZzkXF-0003Qq-GK; Fri, 20 Nov 2015 04:11:25 -0800 From: Alistair Francis To: , Date: Fri, 20 Nov 2015 04:09:22 -0800 Message-ID: X-Mailer: git-send-email 2.5.0 X-RCIS-Action: ALLOW X-TM-AS-MML: disable X-TM-AS-Product-Ver: IMSS-7.1.0.1679-8.0.0.1202-21952.006 X-TM-AS-Result: No--9.397-7.0-31-10 X-imss-scan-details: No--9.397-7.0-31-10 X-TMASE-MatchedRID: We1Gmpc0dwp60j/UbRmWKI7Su3QulAZ5aIqWsHxNIOqCsBeCv8CM/VO4 BD7nLMxnThbvLLI8RvML1e7TPqB0BUjlo2JU8qCxUIhTTahb7dUgXSmAKVRhN5soi2XrUn/Js98 n9dYnJNNQSFbL1bvQASAHAopEd76v01/6A1WX3qs1KfVKcywHrRMSZg1VM11THOdXDA/+g+ZnCL c+j10hGg== X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.96; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(6806005)(5008740100001)(36756003)(5003940100001)(50466002)(33646002)(229853001)(118296001)(77096005)(81156007)(189998001)(586003)(48376002)(5001960100002)(5001770100001)(92566002)(71366001)(105606002)(85426001)(47776003)(50986999)(11100500001)(106466001)(5007970100001)(19580395003)(86362001)(19580405001)(5003600100002)(87936001)(50226001)(64026002)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1NAM02HT092; H:xsj-tvapsmtpgw01; FPR:; SPF:Fail; PTR:unknown-60-96.xilinx.com; MX:1; A:1; LANG:en; MIME-Version: 1.0 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1NAM02HT092; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(10201501046)(3002001); SRVR:CY1NAM02HT092; BCL:0; PCL:0; RULEID:; SRVR:CY1NAM02HT092; X-Forefront-PRVS: 07665BE9D1 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2015 12:11:27.5876 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.96]; Helo=[xsj-tvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1NAM02HT092 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.37.56 Cc: crosthwaitepeter@gmail.com, stefanha@redhat.com, alistair.francis@xilinx.com Subject: [Qemu-devel] [PATCH v1 1/1] xlnx-ep108: Fix minimum RAM check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The minimum RAM check logic for the Xiilnx EP108 was off by one, which caused a false positive. Correct the logic to only print warnings when the RAM is below 0x8000000. Signed-off-by: Alistair Francis --- hw/arm/xlnx-ep108.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/xlnx-ep108.c b/hw/arm/xlnx-ep108.c index 2899698..85b978f 100644 --- a/hw/arm/xlnx-ep108.c +++ b/hw/arm/xlnx-ep108.c @@ -51,7 +51,7 @@ static void xlnx_ep108_init(MachineState *machine) machine->ram_size = EP108_MAX_RAM_SIZE; } - if (machine->ram_size <= 0x08000000) { + if (machine->ram_size < 0x08000000) { qemu_log("WARNING: RAM size " RAM_ADDR_FMT " is small for EP108", machine->ram_size); }