From patchwork Tue Jul 17 19:19:12 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eduardo Otubo X-Patchwork-Id: 171545 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 8BE752C00C1 for ; Wed, 18 Jul 2012 05:30:36 +1000 (EST) Received: from localhost ([::1]:60378 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrDTe-00028d-KF for incoming@patchwork.ozlabs.org; Tue, 17 Jul 2012 15:30:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrDTV-00028X-Fe for qemu-devel@nongnu.org; Tue, 17 Jul 2012 15:30:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrDTT-000559-HV for qemu-devel@nongnu.org; Tue, 17 Jul 2012 15:30:25 -0400 Received: from e24smtp01.br.ibm.com ([32.104.18.85]:50191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrDTT-00054d-5o for qemu-devel@nongnu.org; Tue, 17 Jul 2012 15:30:23 -0400 Received: from /spool/local by e24smtp01.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 17 Jul 2012 16:20:07 -0300 Received: from d24dlp01.br.ibm.com (9.18.248.204) by e24smtp01.br.ibm.com (10.172.0.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 17 Jul 2012 16:20:05 -0300 Received: from d24relay02.br.ibm.com (d24relay02.br.ibm.com [9.13.184.26]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id AC53F352004D for ; Tue, 17 Jul 2012 15:20:02 -0400 (EDT) Received: from d24av05.br.ibm.com (d24av05.br.ibm.com [9.18.232.44]) by d24relay02.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6HJJIl636307030 for ; Tue, 17 Jul 2012 16:19:18 -0300 Received: from d24av05.br.ibm.com (loopback [127.0.0.1]) by d24av05.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6HJK36T013071 for ; Tue, 17 Jul 2012 16:20:04 -0300 Received: from vader.local.com ([9.12.226.34]) by d24av05.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q6HJJpnv012694; Tue, 17 Jul 2012 16:19:58 -0300 From: Eduardo Otubo To: qemu-devel@nongnu.org Date: Tue, 17 Jul 2012 16:19:12 -0300 Message-Id: X-Mailer: git-send-email 1.7.9.5 In-Reply-To: References: In-Reply-To: References: X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12071719-1524-0000-0000-0000031F6939 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 32.104.18.85 Cc: pmoore@redhat.com, blauwirbel@gmail.com, anthony@codemonkey.ws, wad@chromium.org, Eduardo Otubo Subject: [Qemu-devel] [PATCHv4 1/4] Adding support for libseccomp in configure and Makefile X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Adding basic options to the configure script to use libseccomp or not. The default is set to 'no'. If the flag --enable-libseccomp is used, the script will check for its existence using pkg-config. v2: * As I removed all the code related to seccomp from vl.c, I created qemu-seccomp.[ch]. * Also making the configure script to add the specific line to Makefile.obj in order to compile with appropriate support to seccomp. v3: * Removing the line from Makefile.obj and adding it to Makefile.objs. * Marking libseccomp default option to 'yes' in the configure script. v4: * Now two new options added: --enable-seccomp-debug --disable-seccomp-debug Enabling debug will cause libseccomp to be configured with SCMP_ACT_TRAP. This will help users/developers to catch system calls that were not previously whitelisted. Signed-off-by: Eduardo Otubo --- Makefile.objs | 10 ++++++++++ configure | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 44 insertions(+) diff --git a/Makefile.objs b/Makefile.objs index 5ebbcfa..eb4efa3 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -96,6 +96,16 @@ common-obj-y += qemu-timer.o qemu-timer-common.o common-obj-$(CONFIG_SLIRP) += slirp/ ###################################################################### +# libseccomp +ifeq ($(CONFIG_SECCOMP),y) +common-obj-y += qemu-seccomp.o +endif + +ifeq ($(CONFIG_SECCOMP_DEBUG),y) +common-obj-y += qemu-seccomp-debug.o +endif + +###################################################################### # libuser user-obj-y = diff --git a/configure b/configure index 0a3896e..39ef457 100755 --- a/configure +++ b/configure @@ -195,6 +195,8 @@ zlib="yes" guest_agent="yes" libiscsi="" coroutine="" +seccomp="yes" +seccomp_debug="no" # parse CC options first for opt do @@ -824,6 +826,14 @@ for opt do ;; --disable-guest-agent) guest_agent="no" ;; + --enable-seccomp-debug) seccomp_debug="yes" + ;; + --disable-seccomp-debug) seccomp_debug="no" + ;; + --enable-seccomp) seccomp="yes" + ;; + --disable-seccomp) seccomp="no" + ;; *) echo "ERROR: unknown option $opt"; show_help="yes" ;; esac @@ -1108,6 +1118,10 @@ echo " --disable-usb-redir disable usb network redirection support" echo " --enable-usb-redir enable usb network redirection support" echo " --disable-guest-agent disable building of the QEMU Guest Agent" echo " --enable-guest-agent enable building of the QEMU Guest Agent" +echo " --disable-seccomp-debug disable seccomp debug support" +echo " --enable-seccomp-debug enables seccomp debug support" +echo " --disable-seccomp disable seccomp support" +echo " --enable-seccomp enables seccomp support" echo " --with-coroutine=BACKEND coroutine backend. Supported options:" echo " gthread, ucontext, sigaltstack, windows" echo "" @@ -1369,6 +1383,16 @@ EOF fi ########################################## +# libseccomp check + +if test "$seccomp" = "yes" ; then + if $pkg_config libseccomp --modversion >/dev/null 2>&1; then + LIBS=`$pkg_config --libs libseccomp` + else + feature_not_found "libseccomp" + fi +fi +########################################## # xen probe if test "$xen" != "no" ; then @@ -3053,6 +3077,8 @@ echo "usb net redir $usb_redir" echo "OpenGL support $opengl" echo "libiscsi support $libiscsi" echo "build guest agent $guest_agent" +echo "seccomp support $seccomp" +echo "seccomp debug $seccomp_debug" echo "coroutine backend $coroutine_backend" if test "$sdl_too_old" = "yes"; then @@ -3351,6 +3377,14 @@ if test "$libiscsi" = "yes" ; then echo "CONFIG_LIBISCSI=y" >> $config_host_mak fi +if test "$seccomp" = "yes"; then + echo "CONFIG_SECCOMP=y" >> $config_host_mak +fi + +if test "$seccomp_debug" = "yes"; then + echo "CONFIG_SECCOMP_DEBUG=y" >> $config_host_mak +fi + # XXX: suppress that if [ "$bsd" = "yes" ] ; then echo "CONFIG_BSD=y" >> $config_host_mak