From patchwork Tue Jun 11 06:42:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Crosthwaite X-Patchwork-Id: 250449 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A7DF92C00A2 for ; Tue, 11 Jun 2013 16:47:56 +1000 (EST) Received: from localhost ([::1]:41659 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmIN0-0000u4-Rf for incoming@patchwork.ozlabs.org; Tue, 11 Jun 2013 02:47:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmIMd-0000js-34 for qemu-devel@nongnu.org; Tue, 11 Jun 2013 02:47:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UmIMb-00056S-5d for qemu-devel@nongnu.org; Tue, 11 Jun 2013 02:47:31 -0400 Received: from mail-pb0-x232.google.com ([2607:f8b0:400e:c01::232]:50598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmIMa-00056D-Vi for qemu-devel@nongnu.org; Tue, 11 Jun 2013 02:47:29 -0400 Received: by mail-pb0-f50.google.com with SMTP id wz7so2542668pbc.37 for ; Mon, 10 Jun 2013 23:47:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=PF6Cydp1bNOhF9fn7Zy8YiffEdmnSbtlEKgKo3uceFA=; b=G3snaYNx7ZJl51dGV5U6tsZcFFBNq93DXvauCkBeZHXeds0yDdBPm4+2nhNQN/Lu45 WDAVHUrGVBs0MvAeaZ/oelv6D4YvW5rbupCPLL6CVaYPcRfNssIQ6m9tLm/OP4tVbYtc 2LCAIT8Aym4bNG61TeHferJs5GncrIm1lDrPmtPy0CFajmHAIr2ar1KrBRgi9nzd522P QU/DYAKqhoWZvXK4q8jdzBEcZNl4iDbxYHFnTbNvO68owRrq2k6eoyC8d8dzatyyv07K Nb1BkD88AfWlaqdaN118jnKk5WZ2C+iNUuz2y6QdTGjiy9XUEONHkeGDTOwmHMQcSP7g swMA== X-Received: by 10.68.213.231 with SMTP id nv7mr13485133pbc.70.1370933248120; Mon, 10 Jun 2013 23:47:28 -0700 (PDT) Received: from localhost ([203.126.243.116]) by mx.google.com with ESMTPSA id tb7sm13436048pbc.14.2013.06.10.23.47.22 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Mon, 10 Jun 2013 23:47:27 -0700 (PDT) From: peter.crosthwaite@xilinx.com To: qemu-devel@nongnu.org Date: Tue, 11 Jun 2013 16:42:18 +1000 Message-Id: X-Mailer: git-send-email 1.8.3.rc1.44.gb387c77.dirty In-Reply-To: References: X-Gm-Message-State: ALoCoQkDzNqmzLb2Sx8OHhtjI4hb3MNW3ieAzwcDzsaRtC7u69o9Xw3h1CZgXJPsFnlRWbtUPOEZ X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c01::232 Cc: pbonzini@redhat.com, aliguori@us.ibm.com, afaerber@suse.de Subject: [Qemu-devel] [RFT PATCH v1 03/30] net/pcnet-pci: QOM Upcast Sweep X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style upcasting. Signed-off-by: Peter Crosthwaite --- hw/net/pcnet-pci.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/net/pcnet-pci.c b/hw/net/pcnet-pci.c index 9df2b87..b1afbf4 100644 --- a/hw/net/pcnet-pci.c +++ b/hw/net/pcnet-pci.c @@ -43,6 +43,10 @@ //#define PCNET_DEBUG_TMD //#define PCNET_DEBUG_MATCH +#define TYPE_PCI_PC_NET "pcnet" + +#define PCI_PC_NET(obj) \ + OBJECT_CHECK(PCIPCNetState, (obj), TYPE_PCI_PC_NET) typedef struct { PCIDevice pci_dev; @@ -273,7 +277,7 @@ static void pci_pcnet_cleanup(NetClientState *nc) static void pci_pcnet_uninit(PCIDevice *dev) { - PCIPCNetState *d = DO_UPCAST(PCIPCNetState, pci_dev, dev); + PCIPCNetState *d = PCI_PC_NET(dev); memory_region_destroy(&d->state.mmio); memory_region_destroy(&d->io_bar); @@ -293,7 +297,7 @@ static NetClientInfo net_pci_pcnet_info = { static int pci_pcnet_init(PCIDevice *pci_dev) { - PCIPCNetState *d = DO_UPCAST(PCIPCNetState, pci_dev, pci_dev); + PCIPCNetState *d = PCI_PC_NET(pci_dev); PCNetState *s = &d->state; uint8_t *pci_conf; @@ -329,12 +333,12 @@ static int pci_pcnet_init(PCIDevice *pci_dev) s->phys_mem_write = pci_physical_memory_write; s->dma_opaque = pci_dev; - return pcnet_common_init(&pci_dev->qdev, s, &net_pci_pcnet_info); + return pcnet_common_init(DEVICE(pci_dev), s, &net_pci_pcnet_info); } static void pci_reset(DeviceState *dev) { - PCIPCNetState *d = DO_UPCAST(PCIPCNetState, pci_dev.qdev, dev); + PCIPCNetState *d = PCI_PC_NET(dev); pcnet_h_reset(&d->state); } @@ -362,7 +366,7 @@ static void pcnet_class_init(ObjectClass *klass, void *data) } static const TypeInfo pcnet_info = { - .name = "pcnet", + .name = TYPE_PCI_PC_NET, .parent = TYPE_PCI_DEVICE, .instance_size = sizeof(PCIPCNetState), .class_init = pcnet_class_init,