| Message ID | f2d825663a754dabf6ba0056808a3d78480aee1e.1407302379.git.hutao@cn.fujitsu.com |
|---|---|
| State | New |
| Headers | show |
On Wed, Aug 6, 2014 at 3:36 PM, Hu Tao <hutao@cn.fujitsu.com> wrote: > When using monitor command object_add to add a memory backend whose > size is way too big to allocate memory for it, qemu just exits. In > the case we'd better give an error message and keep guest running. > > The problem can be reproduced as follows: > > 1. run qemu > 2. (monitor)object_add memory-backend-ram,size=100000G,id=ram0 > > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com> > --- > backends/hostmem-ram.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/backends/hostmem-ram.c b/backends/hostmem-ram.c > index e55d066..a67a134 100644 > --- a/backends/hostmem-ram.c > +++ b/backends/hostmem-ram.c > @@ -27,7 +27,7 @@ ram_backend_memory_alloc(HostMemoryBackend *backend, Error **errp) > > path = object_get_canonical_path_component(OBJECT(backend)); > memory_region_init_ram(&backend->mr, OBJECT(backend), path, > - backend->size, &error_abort); > + backend->size, errp); > g_free(path); > } > > -- > 1.9.3 > >
diff --git a/backends/hostmem-ram.c b/backends/hostmem-ram.c index e55d066..a67a134 100644 --- a/backends/hostmem-ram.c +++ b/backends/hostmem-ram.c @@ -27,7 +27,7 @@ ram_backend_memory_alloc(HostMemoryBackend *backend, Error **errp) path = object_get_canonical_path_component(OBJECT(backend)); memory_region_init_ram(&backend->mr, OBJECT(backend), path, - backend->size, &error_abort); + backend->size, errp); g_free(path); }
When using monitor command object_add to add a memory backend whose size is way too big to allocate memory for it, qemu just exits. In the case we'd better give an error message and keep guest running. The problem can be reproduced as follows: 1. run qemu 2. (monitor)object_add memory-backend-ram,size=100000G,id=ram0 Signed-off-by: Hu Tao <hutao@cn.fujitsu.com> --- backends/hostmem-ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)