From patchwork Fri Feb 19 18:57:27 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jay Foad X-Patchwork-Id: 45909 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4C444B7CE4 for ; Sat, 20 Feb 2010 15:59:09 +1100 (EST) Received: from localhost ([127.0.0.1]:57047 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NihNo-0008I4-Ny for incoming@patchwork.ozlabs.org; Fri, 19 Feb 2010 23:56:00 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NiY2d-0005iU-EO for qemu-devel@nongnu.org; Fri, 19 Feb 2010 13:57:31 -0500 Received: from [199.232.76.173] (port=34666 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NiY2c-0005hQ-W5 for qemu-devel@nongnu.org; Fri, 19 Feb 2010 13:57:31 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NiY2c-0008RP-6h for qemu-devel@nongnu.org; Fri, 19 Feb 2010 13:57:30 -0500 Received: from mail-bw0-f218.google.com ([209.85.218.218]:41106) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NiY2b-0008Qv-PN for qemu-devel@nongnu.org; Fri, 19 Feb 2010 13:57:30 -0500 Received: by bwz10 with SMTP id 10so354260bwz.2 for ; Fri, 19 Feb 2010 10:57:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type; bh=6myWefengHg/XhZKRpaf9NTIQ+XHTSujLr7kbhAC3a8=; b=Pg9KTqjTdXc5QH773mvFmeM+7KT6kJHQ844kvtJWON4dnHjoRapdHHUbx2lxDxCksr fPDuhfNgnkVgyS5gWF+u2l7Qf1BvL15y9YjcumuXfixBOan0lzJ43EqcJY05Hn++FkGN LltaOAqI1oluICOKoWVi9fsNDtahg7GplzwEg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=AQRy2OOF3Vrd9CovIaR8/cMBdbxax3hLdvjldKtM0s+9QjZK55kJOBqwW0slm0MlDd ug7b1nRmYaPeQw+4V3RUBxDAbBEFuLk7SmsPA34u32ZM5oNYMbdOvht5+g5wog3RdMQp bx7XxAmfci9H7yEcdPNmiAnGBcqvDjXt+kRlg= MIME-Version: 1.0 Received: by 10.204.138.81 with SMTP id z17mr1530920bkt.49.1266605847762; Fri, 19 Feb 2010 10:57:27 -0800 (PST) Date: Fri, 19 Feb 2010 18:57:27 +0000 Message-ID: From: Jay Foad To: qemu-devel@nongnu.org X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-Mailman-Approved-At: Fri, 19 Feb 2010 23:49:25 -0500 Subject: [Qemu-devel] [PATCH] tcg: fix assertion with --enable-debug X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org After configuring with --enable-debug on Linux/x86, I get: foad@foad-ubuntu:~/qemu/objdir-git$ qemu-alpha /dev/null qemu-alpha: /home/foad/git/qemu/tcg/tcg.c:1055: tcg_add_target_add_op_defs: Assertion `tcg_op_defs[op].used' failed. Aborted (and the same for all other targets). The qemu_ld32s op appears to be unused on 32-bit hosts. Is it OK to just remove it? Signed-off-by: Jay Foad --- tcg/tcg-opc.h | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) DEF2(qemu_ld64, 2, 2, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS) diff --git a/tcg/tcg-opc.h b/tcg/tcg-opc.h index 89db3b4..838f1f4 100644 --- a/tcg/tcg-opc.h +++ b/tcg/tcg-opc.h @@ -224,11 +224,6 @@ DEF2(qemu_ld32u, 1, 1, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS) DEF2(qemu_ld32u, 1, 2, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS) #endif #if TARGET_LONG_BITS == 32 -DEF2(qemu_ld32s, 1, 1, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS) -#else -DEF2(qemu_ld32s, 1, 2, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS) -#endif -#if TARGET_LONG_BITS == 32 DEF2(qemu_ld64, 2, 1, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS) #else