From patchwork Mon Aug 12 16:28:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michal Novotny X-Patchwork-Id: 266569 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (unknown [IPv6:2001:4830:134:3::12]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 043A02C00FB for ; Tue, 13 Aug 2013 02:39:44 +1000 (EST) Received: from localhost ([::1]:49450 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8v9i-00015N-0O for incoming@patchwork.ozlabs.org; Mon, 12 Aug 2013 12:39:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8v9H-00013y-QT for qemu-devel@nongnu.org; Mon, 12 Aug 2013 12:39:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V8v9B-000113-5I for qemu-devel@nongnu.org; Mon, 12 Aug 2013 12:39:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49009) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V8uyw-0003Kn-Gk for qemu-devel@nongnu.org; Mon, 12 Aug 2013 12:28:34 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7CGSXla028915 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 12 Aug 2013 12:28:34 -0400 Received: from miglaptop.brq.redhat.com (dhcp-26-175.brq.redhat.com [10.34.26.175]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r7CGSWx2021012; Mon, 12 Aug 2013 12:28:33 -0400 From: Michal Novotny To: qemu-devel@nongnu.org Date: Mon, 12 Aug 2013 18:28:30 +0200 Message-Id: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: aliguori@us.ibm.com Subject: [Qemu-devel] [QEMU-1.6 PATCH] vl.c: Output error on invalid machine type provided X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Output error message using qemu's error_report() function when user provides the invalid machine type on the command line. This also saves time to find what issue is when you downgrade from one version of qemu to another that doesn't support required machine type yet (the version user downgraded to have to have this patch applied too, of course). Signed-off-by: Michal Novotny Reviewed-by: Eric Blake Reviewed-by: Marcel Apfelbaum Reviewed-by: Andreas Färber --- vl.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/vl.c b/vl.c index f422a1c..9b4a3f9 100644 --- a/vl.c +++ b/vl.c @@ -2671,6 +2671,11 @@ static QEMUMachine *machine_parse(const char *name) if (machine) { return machine; } + + if (name && !is_help_option(name)) { + error_report("Unsupported machine type"); + } + printf("Supported machines are:\n"); for (m = first_machine; m != NULL; m = m->next) { if (m->alias) {