Message ID | cover.1494140527.git.mjt@msgid.tls.msk.ru |
---|---|
State | New |
Headers | show |
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: cover.1494140527.git.mjt@msgid.tls.msk.ru Subject: [Qemu-devel] [PULL 00/23] Trivial patches for 2017-05-07 Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 8acf5d3 tests: Remove redundant assignment 0f494a6 MAINTAINERS: Update paths for AioContext implementation 9974be0 MAINTAINERS: Update paths for main loop 3e8c3af jazz_led: fix bad snprintf 8f753b9 tests: Ignore another built executable (test-hmp) 7d5489d scripts: Switch to more portable Perl shebang 536d031 scripts/qemu-binfmt-conf.sh: Fix shell portability issue a3e0b2b virtfs: allow a device id to be specified in the -virtfs option 3227c55 hw/core/generic-loader: Fix crash when running without CPU 22bf6ca virtio-blk: Remove useless condition around g_free() 65fe06c qemu-doc: Fix broken URLs of amnhltm.zip and dosidle210.zip 1f55ac0 use _Static_assert in QEMU_BUILD_BUG_ON 58005fb channel-file: fix wrong parameter comments 9029b8b block: Make 'replication_state' an enum d5f07f0 util: Use g_malloc/g_free in envlist.c e1d8273 qga: fix compiler warnings (clang 5) 077a79e device_tree: fix compiler warnings (clang 5) 965b305 usb-ccid: make ccid_write_data_block() cope with null buffers 3b19d93 tests: Ignore more test executables 296cc0d Add 'none' as type for drive's if option 708674a doc: fix function spelling afcc583 ppc_booke: drop useless assignment 8b94589 Remove reduntant qemu: from error functions === OUTPUT BEGIN === Checking PATCH 1/23: Remove reduntant qemu: from error functions... Checking PATCH 2/23: ppc_booke: drop useless assignment... Checking PATCH 3/23: doc: fix function spelling... Checking PATCH 4/23: Add 'none' as type for drive's if option... Checking PATCH 5/23: tests: Ignore more test executables... Checking PATCH 6/23: usb-ccid: make ccid_write_data_block() cope with null buffers... Checking PATCH 7/23: device_tree: fix compiler warnings (clang 5)... Checking PATCH 8/23: qga: fix compiler warnings (clang 5)... Checking PATCH 9/23: util: Use g_malloc/g_free in envlist.c... ERROR: code indent should never use tabs #116: FILE: util/envlist.c:27: +^Ienvlist = g_malloc(sizeof(*envlist));$ ERROR: code indent should never use tabs #126: FILE: util/envlist.c:49: +^I^Ig_free((char *)entry->ev_var);$ ERROR: code indent should never use tabs #127: FILE: util/envlist.c:50: +^I^Ig_free(entry);$ ERROR: code indent should never use tabs #130: FILE: util/envlist.c:52: +^Ig_free(envlist);$ ERROR: code indent should never use tabs #140: FILE: util/envlist.c:102: +^Itmpenv = g_strdup(env);$ ERROR: code indent should never use tabs #159: FILE: util/envlist.c:155: +^I^Ig_free((char *)entry->ev_var);$ ERROR: code indent should never use tabs #160: FILE: util/envlist.c:156: +^I^Ig_free(entry);$ ERROR: code indent should never use tabs #171: FILE: util/envlist.c:161: +^Ientry = g_malloc(sizeof(*entry));$ ERROR: code indent should never use tabs #172: FILE: util/envlist.c:162: +^Ientry->ev_var = g_strdup(env);$ ERROR: code indent should never use tabs #182: FILE: util/envlist.c:197: +^I^Ig_free((char *)entry->ev_var);$ ERROR: code indent should never use tabs #183: FILE: util/envlist.c:198: +^I^Ig_free(entry);$ ERROR: code indent should never use tabs #211: FILE: util/envlist.c:221: +^Ipenv = env = g_malloc((envlist->el_count + 1) * sizeof(char *));$ ERROR: code indent should never use tabs #216: FILE: util/envlist.c:225: +^I^I*(penv++) = g_strdup(entry->ev_var);$ total: 13 errors, 0 warnings, 168 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 10/23: block: Make 'replication_state' an enum... Checking PATCH 11/23: channel-file: fix wrong parameter comments... Checking PATCH 12/23: use _Static_assert in QEMU_BUILD_BUG_ON... Checking PATCH 13/23: qemu-doc: Fix broken URLs of amnhltm.zip and dosidle210.zip... Checking PATCH 14/23: virtio-blk: Remove useless condition around g_free()... Checking PATCH 15/23: hw/core/generic-loader: Fix crash when running without CPU... Checking PATCH 16/23: virtfs: allow a device id to be specified in the -virtfs option... Checking PATCH 17/23: scripts/qemu-binfmt-conf.sh: Fix shell portability issue... Checking PATCH 18/23: scripts: Switch to more portable Perl shebang... Checking PATCH 19/23: tests: Ignore another built executable (test-hmp)... Checking PATCH 20/23: jazz_led: fix bad snprintf... Checking PATCH 21/23: MAINTAINERS: Update paths for main loop... Checking PATCH 22/23: MAINTAINERS: Update paths for AioContext implementation... Checking PATCH 23/23: tests: Remove redundant assignment... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org
On Sun, May 07, 2017 at 10:02:03AM +0300, Michael Tokarev wrote: > The following changes since commit 12a95f320a36ef66f724a49bb05e4fb553ac5dbe: > > Merge remote-tracking branch 'kwolf/tags/for-upstream' into staging (2017-05-04 13:44:32 +0100) > > are available in the git repository at: > > git://git.corpit.ru/qemu.git tags/trivial-patches-fetch > > for you to fetch changes up to 311875781e549af91a3216d34c6ef40420bab435: > > tests: Remove redundant assignment (2017-05-07 09:57:51 +0300) > > ---------------------------------------------------------------- > trivial patches for 2017-05-07 > > ---------------------------------------------------------------- > Andreas Grapentin (1): > use _Static_assert in QEMU_BUILD_BUG_ON > > Chris Webb (1): > virtfs: allow a device id to be specified in the -virtfs option > > Craig Jellick (1): > Add 'none' as type for drive's if option > > Eric Blake (2): > tests: Ignore more test executables > tests: Ignore another built executable (test-hmp) > > Fam Zheng (3): > block: Make 'replication_state' an enum > virtio-blk: Remove useless condition around g_free() > tests: Remove redundant assignment > > Ishani Chugh (1): > Remove reduntant qemu: from error functions > > KONRAD Frederic (1): > ppc_booke: drop useless assignment > > Kamil Rytarowski (2): > scripts/qemu-binfmt-conf.sh: Fix shell portability issue > scripts: Switch to more portable Perl shebang > > Marc-André Lureau (1): > doc: fix function spelling > > Paolo Bonzini (3): > jazz_led: fix bad snprintf > MAINTAINERS: Update paths for main loop > MAINTAINERS: Update paths for AioContext implementation > > Philippe Mathieu-Daudé (3): > usb-ccid: make ccid_write_data_block() cope with null buffers > device_tree: fix compiler warnings (clang 5) > qga: fix compiler warnings (clang 5) > > Saurav Sachidanand (1): > util: Use g_malloc/g_free in envlist.c > > Thomas Huth (2): > qemu-doc: Fix broken URLs of amnhltm.zip and dosidle210.zip > hw/core/generic-loader: Fix crash when running without CPU > > sochin.jiang fix wrong parameter comments in channel-file.h (1): > channel-file: fix wrong parameter comments > > MAINTAINERS | 8 +++---- > block/replication.c | 44 +++++++++++++++++++------------------- > bsd-user/main.c | 14 ++++-------- > configure | 18 ++++++++++++++++ > device_tree.c | 1 + > hw/block/virtio-blk.c | 4 +--- > hw/core/generic-loader.c | 9 ++++---- > hw/display/jazz_led.c | 4 ++-- > hw/microblaze/boot.c | 2 +- > hw/nios2/boot.c | 2 +- > hw/ppc/pnv.c | 2 +- > hw/ppc/ppc_booke.c | 1 - > hw/s390x/sclp.c | 4 ++-- > hw/tricore/tricore_testboard.c | 2 +- > hw/usb/dev-smartcard-reader.c | 5 ++++- > include/io/channel-file.h | 2 +- > include/io/channel.h | 2 +- > include/qemu/compiler.h | 4 +++- > linux-user/main.c | 9 +++----- > numa.c | 4 ++-- > qemu-doc.texi | 10 ++++----- > qemu-options.hx | 4 ++-- > qga/commands-posix.c | 8 ++++--- > scripts/checkpatch.pl | 3 ++- > scripts/clean-header-guards.pl | 3 ++- > scripts/cleanup-trace-events.pl | 2 +- > scripts/disas-objdump.pl | 4 +++- > scripts/get_maintainer.pl | 3 ++- > scripts/qemu-binfmt-conf.sh | 4 ++-- > scripts/shaderinclude.pl | 2 +- > scripts/switch-timer-api | 2 +- > scripts/texi2pod.pl | 4 +++- > tests/.gitignore | 4 ++++ > tests/postcopy-test.c | 2 +- > util/envlist.c | 47 +++++++++++++++++------------------------ > vl.c | 5 +++-- > 36 files changed, 133 insertions(+), 115 deletions(-) > Thanks, applied to my staging tree: https://github.com/stefanha/qemu/commits/staging Stefan
On 05/08/2017 12:30 PM, Stefan Hajnoczi wrote: > On Sun, May 07, 2017 at 10:02:03AM +0300, Michael Tokarev wrote: >> The following changes since commit 12a95f320a36ef66f724a49bb05e4fb553ac5dbe: >> >> Merge remote-tracking branch 'kwolf/tags/for-upstream' into staging (2017-05-04 13:44:32 +0100) >> >> are available in the git repository at: >> >> git://git.corpit.ru/qemu.git tags/trivial-patches-fetch >> >> for you to fetch changes up to 311875781e549af91a3216d34c6ef40420bab435: >> >> tests: Remove redundant assignment (2017-05-07 09:57:51 +0300) >> >> ---------------------------------------------------------------- >> trivial patches for 2017-05-07 >> >> sochin.jiang fix wrong parameter comments in channel-file.h (1): >> channel-file: fix wrong parameter comments See my question on 11/23 > > Thanks, applied to my staging tree: > https://github.com/stefanha/qemu/commits/staging
On Mon, May 08, 2017 at 01:30:31PM -0400, Stefan Hajnoczi wrote: > On Sun, May 07, 2017 at 10:02:03AM +0300, Michael Tokarev wrote: > > The following changes since commit 12a95f320a36ef66f724a49bb05e4fb553ac5dbe: > > > > Merge remote-tracking branch 'kwolf/tags/for-upstream' into staging (2017-05-04 13:44:32 +0100) > > > > are available in the git repository at: > > > > git://git.corpit.ru/qemu.git tags/trivial-patches-fetch > > > > for you to fetch changes up to 311875781e549af91a3216d34c6ef40420bab435: > > > > tests: Remove redundant assignment (2017-05-07 09:57:51 +0300) > > > > ---------------------------------------------------------------- > > trivial patches for 2017-05-07 > > > > ---------------------------------------------------------------- > > Andreas Grapentin (1): > > use _Static_assert in QEMU_BUILD_BUG_ON > > > > Chris Webb (1): > > virtfs: allow a device id to be specified in the -virtfs option > > > > Craig Jellick (1): > > Add 'none' as type for drive's if option > > > > Eric Blake (2): > > tests: Ignore more test executables > > tests: Ignore another built executable (test-hmp) > > > > Fam Zheng (3): > > block: Make 'replication_state' an enum > > virtio-blk: Remove useless condition around g_free() > > tests: Remove redundant assignment > > > > Ishani Chugh (1): > > Remove reduntant qemu: from error functions > > > > KONRAD Frederic (1): > > ppc_booke: drop useless assignment > > > > Kamil Rytarowski (2): > > scripts/qemu-binfmt-conf.sh: Fix shell portability issue > > scripts: Switch to more portable Perl shebang > > > > Marc-André Lureau (1): > > doc: fix function spelling > > > > Paolo Bonzini (3): > > jazz_led: fix bad snprintf > > MAINTAINERS: Update paths for main loop > > MAINTAINERS: Update paths for AioContext implementation > > > > Philippe Mathieu-Daudé (3): > > usb-ccid: make ccid_write_data_block() cope with null buffers > > device_tree: fix compiler warnings (clang 5) > > qga: fix compiler warnings (clang 5) > > > > Saurav Sachidanand (1): > > util: Use g_malloc/g_free in envlist.c > > > > Thomas Huth (2): > > qemu-doc: Fix broken URLs of amnhltm.zip and dosidle210.zip > > hw/core/generic-loader: Fix crash when running without CPU > > > > sochin.jiang fix wrong parameter comments in channel-file.h (1): > > channel-file: fix wrong parameter comments > > > > MAINTAINERS | 8 +++---- > > block/replication.c | 44 +++++++++++++++++++------------------- > > bsd-user/main.c | 14 ++++-------- > > configure | 18 ++++++++++++++++ > > device_tree.c | 1 + > > hw/block/virtio-blk.c | 4 +--- > > hw/core/generic-loader.c | 9 ++++---- > > hw/display/jazz_led.c | 4 ++-- > > hw/microblaze/boot.c | 2 +- > > hw/nios2/boot.c | 2 +- > > hw/ppc/pnv.c | 2 +- > > hw/ppc/ppc_booke.c | 1 - > > hw/s390x/sclp.c | 4 ++-- > > hw/tricore/tricore_testboard.c | 2 +- > > hw/usb/dev-smartcard-reader.c | 5 ++++- > > include/io/channel-file.h | 2 +- > > include/io/channel.h | 2 +- > > include/qemu/compiler.h | 4 +++- > > linux-user/main.c | 9 +++----- > > numa.c | 4 ++-- > > qemu-doc.texi | 10 ++++----- > > qemu-options.hx | 4 ++-- > > qga/commands-posix.c | 8 ++++--- > > scripts/checkpatch.pl | 3 ++- > > scripts/clean-header-guards.pl | 3 ++- > > scripts/cleanup-trace-events.pl | 2 +- > > scripts/disas-objdump.pl | 4 +++- > > scripts/get_maintainer.pl | 3 ++- > > scripts/qemu-binfmt-conf.sh | 4 ++-- > > scripts/shaderinclude.pl | 2 +- > > scripts/switch-timer-api | 2 +- > > scripts/texi2pod.pl | 4 +++- > > tests/.gitignore | 4 ++++ > > tests/postcopy-test.c | 2 +- > > util/envlist.c | 47 +++++++++++++++++------------------------ > > vl.c | 5 +++-- > > 36 files changed, 133 insertions(+), 115 deletions(-) > > > > Thanks, applied to my staging tree: > https://github.com/stefanha/qemu/commits/staging Dropped for now, please see my reply to "channel-file: fix wrong parameter comments".