| Message ID | ce726611d2900dde5eac808524baff0b7097f7a9.1398359346.git.crobinso@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 04/24/2014 01:13 PM, Cole Robinson wrote: > I don't see why tpm is disabled by default: it doesn't have any > external dependencies, or change default behavior. Leaving it disabled > is just going to cause it to bit rot. > > Enable it by default, and change --enable-tpm to --disable-tpm if > people still want an option to compile it out. > > Signed-off-by: Cole Robinson <crobinso@redhat.com> > --- > v2: > Don't drop --enable-tpm option > err, I probably should have changed the patch description. I'll send v3 - Cole
diff --git a/configure b/configure index b08afc3..976d815 100755 --- a/configure +++ b/configure @@ -320,7 +320,7 @@ virtio_blk_data_plane="" gtk="" gtkabi="2.0" vte="" -tpm="no" +tpm="yes" libssh2="" vhdx="" quorum="no" @@ -1073,6 +1073,8 @@ for opt do ;; --enable-vte) vte="yes" ;; + --disable-tpm) tpm="no" + ;; --enable-tpm) tpm="yes" ;; --disable-libssh2) libssh2="no" @@ -1343,6 +1345,7 @@ Advanced options (experts only): --disable-glusterfs disable GlusterFS backend --enable-gcov enable test coverage analysis with gcov --gcov=GCOV use specified gcov [$gcov_tool] + --disable-tpm disable TPM support --enable-tpm enable TPM support --disable-libssh2 disable ssh block device support --enable-libssh2 enable ssh block device support
I don't see why tpm is disabled by default: it doesn't have any external dependencies, or change default behavior. Leaving it disabled is just going to cause it to bit rot. Enable it by default, and change --enable-tpm to --disable-tpm if people still want an option to compile it out. Signed-off-by: Cole Robinson <crobinso@redhat.com> --- v2: Don't drop --enable-tpm option configure | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)