From patchwork Fri Jun 8 01:06:18 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Maciej W. Rozycki" X-Patchwork-Id: 163708 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5F005B6FA5 for ; Fri, 8 Jun 2012 14:50:21 +1000 (EST) Received: from localhost ([::1]:49183 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScqOP-0001CB-CL for incoming@patchwork.ozlabs.org; Fri, 08 Jun 2012 00:01:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Scner-0007gm-1T for qemu-devel@nongnu.org; Thu, 07 Jun 2012 21:06:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Scnep-0006jV-Am for qemu-devel@nongnu.org; Thu, 07 Jun 2012 21:06:32 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:47522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Scnep-0006jP-5B for qemu-devel@nongnu.org; Thu, 07 Jun 2012 21:06:31 -0400 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Scnen-0003LG-KU from Maciej_Rozycki@mentor.com ; Thu, 07 Jun 2012 18:06:29 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 7 Jun 2012 18:05:58 -0700 Received: from [172.30.1.189] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Fri, 8 Jun 2012 02:06:27 +0100 Date: Fri, 8 Jun 2012 02:06:18 +0100 From: "Maciej W. Rozycki" To: Message-ID: User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 X-OriginalArrivalTime: 08 Jun 2012 01:05:58.0259 (UTC) FILETIME=[DCF82430:01CD4512] X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 192.94.38.131 X-Mailman-Approved-At: Fri, 08 Jun 2012 00:01:11 -0400 Cc: "Maciej W. Rozycki" , Aurelien Jarno Subject: [Qemu-devel] [PATCH] MIPS: Remove obsolete comment about OPC_JALX X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org A while ago I made a change to make MIPS16 code use the OPC_JALS opcode "pinched" from microMIPS support as well as the artificial OPC_JALXS opcode I made up on that occasion so that the fixed 16-bit delay slot size of MIPS16 instructions is handled uniformly across code, just as the microMIPS delay slot size constraints are. As a result of this change OPC_JALX is never used for MIPS16 emulation anymore, it's now only ever used in the standard MIPS and microMIPS modes. Someone was kind enough to push that change upstream on my behalf, but somehow the piece to update the comment accordingly was missed and not propagated. Here's an update to remove the obsolete and now misleading comment. Signed-off-by: Maciej W. Rozycki Reviewed-by: Richard Henderson --- Mostly obvious, please apply. Maciej qemu-mips16-jal.diff Index: qemu-git-trunk/target-mips/translate.c =================================================================== --- qemu-git-trunk.orig/target-mips/translate.c 2012-06-04 02:38:47.000000000 +0100 +++ qemu-git-trunk/target-mips/translate.c 2012-06-04 03:06:38.975449423 +0100 @@ -69,7 +69,7 @@ enum { OPC_BLEZL = (0x16 << 26), OPC_BGTZ = (0x07 << 26), OPC_BGTZL = (0x17 << 26), - OPC_JALX = (0x1D << 26), /* MIPS 16 only */ + OPC_JALX = (0x1D << 26), OPC_JALXS = OPC_JALX | 0x5, /* Load and stores */ OPC_LDL = (0x1A << 26),