From patchwork Thu Jun 28 19:22:10 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juan Quintela X-Patchwork-Id: 167949 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id BF339B6FF8 for ; Fri, 29 Jun 2012 05:24:35 +1000 (EST) Received: from localhost ([::1]:41226 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SkKKP-0003sw-KM for incoming@patchwork.ozlabs.org; Thu, 28 Jun 2012 15:24:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SkKIS-0007kb-Vm for qemu-devel@nongnu.org; Thu, 28 Jun 2012 15:22:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SkKIR-0002xr-BA for qemu-devel@nongnu.org; Thu, 28 Jun 2012 15:22:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16240) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SkKIR-0002xX-2x for qemu-devel@nongnu.org; Thu, 28 Jun 2012 15:22:31 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5SJMTc5000877 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 28 Jun 2012 15:22:29 -0400 Received: from trasno.mitica (ovpn-116-23.ams2.redhat.com [10.36.116.23]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q5SJMB82000894; Thu, 28 Jun 2012 15:22:28 -0400 From: Juan Quintela To: qemu-devel@nongnu.org Date: Thu, 28 Jun 2012 21:22:10 +0200 Message-Id: In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: owasserm@redhat.com Subject: [Qemu-devel] [PATCH 12/12] ram: save_live_setup() we don't need to synchronize the dirty bitmap. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org 1st: we were synchonizing the dirty bitmap before calling memory_global_dirty_log_start(). 2nd: We are marking all pages as dirty anywhere, no reason to go through all the bitmap to "mark" dirty same pages twice. So, call removed. Signed-off-by: Juan Quintela Reviewed-by: Orit Wasserman --- arch_init.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch_init.c b/arch_init.c index 8299c15..c1b4f13 100644 --- a/arch_init.c +++ b/arch_init.c @@ -308,8 +308,6 @@ static int ram_save_setup(QEMUFile *f, void *opaque) ram_addr_t addr; RAMBlock *block; - memory_global_sync_dirty_bitmap(get_system_memory()); - bytes_transferred = 0; last_block = NULL; last_offset = 0;