| Message ID | aa3087554703e0849c3d6582cdefb265cc444403.1593456926.git.balaton@eik.bme.hu |
|---|---|
| State | New |
| Headers | show |
| Series | Mac Old World ROM experiment | expand |
On 29/06/2020 19:55, BALATON Zoltan wrote: > The board firmware expect these to be at fixed addresses and programs > them without probing, this patch puts the macio device at the expected > PCI address. > > Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> > --- > hw/ppc/mac_oldworld.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c > index 4200008851..6276973c95 100644 > --- a/hw/ppc/mac_oldworld.c > +++ b/hw/ppc/mac_oldworld.c > @@ -286,7 +286,7 @@ static void ppc_heathrow_init(MachineState *machine) > ide_drive_get(hd, ARRAY_SIZE(hd)); > > /* MacIO */ > - macio = pci_new(-1, TYPE_OLDWORLD_MACIO); > + macio = pci_new(PCI_DEVFN(16, 0), TYPE_OLDWORLD_MACIO); > dev = DEVICE(macio); > qdev_prop_set_uint64(dev, "frequency", tbfreq); > object_property_set_link(OBJECT(macio), OBJECT(pic_dev), "pic", This looks much better! Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> ATB, Mark.
diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c index 4200008851..6276973c95 100644 --- a/hw/ppc/mac_oldworld.c +++ b/hw/ppc/mac_oldworld.c @@ -286,7 +286,7 @@ static void ppc_heathrow_init(MachineState *machine) ide_drive_get(hd, ARRAY_SIZE(hd)); /* MacIO */ - macio = pci_new(-1, TYPE_OLDWORLD_MACIO); + macio = pci_new(PCI_DEVFN(16, 0), TYPE_OLDWORLD_MACIO); dev = DEVICE(macio); qdev_prop_set_uint64(dev, "frequency", tbfreq); object_property_set_link(OBJECT(macio), OBJECT(pic_dev), "pic",
The board firmware expect these to be at fixed addresses and programs them without probing, this patch puts the macio device at the expected PCI address. Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> --- hw/ppc/mac_oldworld.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)