From patchwork Tue Mar 30 01:33:24 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: TeLeMan X-Patchwork-Id: 48926 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 1EBE6B7C48 for ; Tue, 30 Mar 2010 12:35:02 +1100 (EST) Received: from localhost ([127.0.0.1]:49885 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NwQLr-0007i2-IR for incoming@patchwork.ozlabs.org; Mon, 29 Mar 2010 21:34:43 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NwQKf-0007gh-Jc for qemu-devel@nongnu.org; Mon, 29 Mar 2010 21:33:29 -0400 Received: from [140.186.70.92] (port=50838 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NwQKe-0007fb-5l for qemu-devel@nongnu.org; Mon, 29 Mar 2010 21:33:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NwQKd-0006Mx-1a for qemu-devel@nongnu.org; Mon, 29 Mar 2010 21:33:28 -0400 Received: from mail-pw0-f45.google.com ([209.85.160.45]:51802) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NwQKc-0006Mp-TM for qemu-devel@nongnu.org; Mon, 29 Mar 2010 21:33:27 -0400 Received: by pwi9 with SMTP id 9so8172271pwi.4 for ; Mon, 29 Mar 2010 18:33:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:received:message-id :subject:from:to:content-type; bh=UthW7k/nGvqZ7BNQ2wwFVNsO2h0LhsiZaa0rk++6F9w=; b=b7+7XQuyrC/SM2G8UTsHmWqhaoR0cLYKZbJ4vMZyG50fwvoMlrx1VvCs28TAihNKGE fqSkU/niEXNyAQ6ISNaukyZmXhIskGCXABzh725mBh6YoHSimXfyUN1MeaoUDaTWDwwo 05y+R32pJrhzU7d2MZPoO6rmfav2SPEX1eFDE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=YRzIRFeKd2VXrVa106yCZUz4kukdbVnZM0jB1bo/8FagSML70SoTAQFaUcHDxRfiDD f9yRsAozDblELRtMjqUfQi4TVEFBeVWKkVaHw90xN+PI3+DRiKMRq15Hok/gT2RZvRue zL8sl4zNGh7IXob3Y/B8ha+zHkLHOpNAdc/MM= MIME-Version: 1.0 Received: by 10.140.125.14 with HTTP; Mon, 29 Mar 2010 18:33:24 -0700 (PDT) Date: Tue, 30 Mar 2010 09:33:24 +0800 Received: by 10.141.105.10 with SMTP id h10mr1673865rvm.45.1269912804869; Mon, 29 Mar 2010 18:33:24 -0700 (PDT) Message-ID: From: TeLeMan To: qemu-devel X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: [Qemu-devel] [PATCHv2] usb-bus: fix no params X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org After commit 702f3e0fb52c124c07f215426eeadb70a716643f, the params is nerver NULL. It should check *params instead of params to determine whether the params is empty. Signed-off-by: TeLeMan --- hw/usb-bus.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index ce8a694..ee0e9e3 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -299,7 +299,7 @@ USBDevice *usbdevice_create(const char *cmdline) } if (!usb->usbdevice_init) { - if (params) { + if (*params) { error_report("usbdevice %s accepts no params", driver); return NULL; }