diff mbox series

[v3,5/6] docs/system/devices/usb: Add CanoKey to USB devices examples

Message ID YeBrbOLSDL1xJAj6@Sun
State New
Headers show
Series Introduce CanoKey QEMU | expand

Commit Message

Hongren (Zenithal) Zheng Jan. 13, 2022, 6:11 p.m. UTC
Signed-off-by: Hongren (Zenithal) Zheng <i@zenithal.me>
---
 docs/system/devices/usb.rst | 3 +++
 1 file changed, 3 insertions(+)

Comments

Thomas Huth Jan. 18, 2022, 9:28 a.m. UTC | #1
On 13/01/2022 19.11, Hongren (Zenithal) Zheng wrote:
> Signed-off-by: Hongren (Zenithal) Zheng <i@zenithal.me>
> ---
>   docs/system/devices/usb.rst | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/docs/system/devices/usb.rst b/docs/system/devices/usb.rst
> index afb7d6c226..341694403a 100644
> --- a/docs/system/devices/usb.rst
> +++ b/docs/system/devices/usb.rst
> @@ -199,6 +199,9 @@ option or the ``device_add`` monitor command. Available devices are:
>   ``u2f-{emulated,passthru}``
>      Universal Second Factor device
>   
> +``canokey``
> +   An Open-source Secure Key implementing FIDO2, OpenPGP, PIV and more.

Reviewed-by: Thomas Huth <thuth@redhat.com>

Just an additional idea: It might be helpful for the users if you put a link 
to the separate documentation from the previous patch here?

  Thomas
Hongren (Zenithal) Zheng Jan. 20, 2022, 2:40 a.m. UTC | #2
On Tue, Jan 18, 2022 at 10:28:49AM +0100, Thomas Huth wrote:
> On 13/01/2022 19.11, Hongren (Zenithal) Zheng wrote:
> > Signed-off-by: Hongren (Zenithal) Zheng <i@zenithal.me>
> > ---
> >   docs/system/devices/usb.rst | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/docs/system/devices/usb.rst b/docs/system/devices/usb.rst
> > index afb7d6c226..341694403a 100644
> > --- a/docs/system/devices/usb.rst
> > +++ b/docs/system/devices/usb.rst
> > @@ -199,6 +199,9 @@ option or the ``device_add`` monitor command. Available devices are:
> >   ``u2f-{emulated,passthru}``
> >      Universal Second Factor device
> > +``canokey``
> > +   An Open-source Secure Key implementing FIDO2, OpenPGP, PIV and more.
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> 
> Just an additional idea: It might be helpful for the users if you put a link
> to the separate documentation from the previous patch here?

Will be added in the next version.

> 
>  Thomas
>
diff mbox series

Patch

diff --git a/docs/system/devices/usb.rst b/docs/system/devices/usb.rst
index afb7d6c226..341694403a 100644
--- a/docs/system/devices/usb.rst
+++ b/docs/system/devices/usb.rst
@@ -199,6 +199,9 @@  option or the ``device_add`` monitor command. Available devices are:
 ``u2f-{emulated,passthru}``
    Universal Second Factor device
 
+``canokey``
+   An Open-source Secure Key implementing FIDO2, OpenPGP, PIV and more.
+
 Physical port addressing
 ^^^^^^^^^^^^^^^^^^^^^^^^