diff mbox series

configure: Loosen GCC requirement from 7.5.0 to 7.4.0

Message ID YVAfpt8k8BHsN2Ln@homeworld.netbsd.org
State New
Headers show
Series configure: Loosen GCC requirement from 7.5.0 to 7.4.0 | expand

Commit Message

nia Sept. 26, 2021, 7:22 a.m. UTC
As discussed in issue 614, we're shipping GCC 7.4.0 as the
system compiler in NetBSD 9, the most recent stable branch,
and are still actively interested in QEMU on this platform.

The differences between GCC 7.5.0 and 7.4.0 are trivial.

Signed-off-by: Nia Alarie <nia@NetBSD.org>
---
 configure | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Philippe Mathieu-Daudé Sept. 26, 2021, 8:19 a.m. UTC | #1
Cc'ing Daniel & Thomas.

On 9/26/21 09:22, nia wrote:
> As discussed in issue 614, we're shipping GCC 7.4.0 as the
> system compiler in NetBSD 9, the most recent stable branch,
> and are still actively interested in QEMU on this platform.
> 
> The differences between GCC 7.5.0 and 7.4.0 are trivial.
> 
> Signed-off-by: Nia Alarie <nia@NetBSD.org>
> ---
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 1043ccce4f..f918ad67a1 100755
> --- a/configure
> +++ b/configure
> @@ -2094,8 +2094,8 @@ cat > $TMPC << EOF
>  #  endif
>  # endif
>  #elif defined(__GNUC__) && defined(__GNUC_MINOR__)
> -# if __GNUC__ < 7 || (__GNUC__ == 7 && __GNUC_MINOR__ < 5)
> -#  error You need at least GCC v7.5.0 to compile QEMU
> +# if __GNUC__ < 7 || (__GNUC__ == 7 && __GNUC_MINOR__ < 4)
> +#  error You need at least GCC v7.4.0 to compile QEMU
>  # endif
>  #else
>  # error You either need GCC or Clang to compiler QEMU
>
Daniel P. Berrangé Sept. 27, 2021, 7:36 a.m. UTC | #2
On Sun, Sep 26, 2021 at 07:22:14AM +0000, nia wrote:
> As discussed in issue 614, we're shipping GCC 7.4.0 as the
> system compiler in NetBSD 9, the most recent stable branch,
> and are still actively interested in QEMU on this platform.
> 
> The differences between GCC 7.5.0 and 7.4.0 are trivial.
> 
> Signed-off-by: Nia Alarie <nia@NetBSD.org>
> ---
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 1043ccce4f..f918ad67a1 100755
> --- a/configure
> +++ b/configure
> @@ -2094,8 +2094,8 @@ cat > $TMPC << EOF
>  #  endif
>  # endif
>  #elif defined(__GNUC__) && defined(__GNUC_MINOR__)
> -# if __GNUC__ < 7 || (__GNUC__ == 7 && __GNUC_MINOR__ < 5)
> -#  error You need at least GCC v7.5.0 to compile QEMU
> +# if __GNUC__ < 7 || (__GNUC__ == 7 && __GNUC_MINOR__ < 4)
> +#  error You need at least GCC v7.4.0 to compile QEMU
>  # endif
>  #else
>  # error You either need GCC or Clang to compiler QEMU

You missed another version number change just after here


Regards,
Daniel
diff mbox series

Patch

diff --git a/configure b/configure
index 1043ccce4f..f918ad67a1 100755
--- a/configure
+++ b/configure
@@ -2094,8 +2094,8 @@  cat > $TMPC << EOF
 #  endif
 # endif
 #elif defined(__GNUC__) && defined(__GNUC_MINOR__)
-# if __GNUC__ < 7 || (__GNUC__ == 7 && __GNUC_MINOR__ < 5)
-#  error You need at least GCC v7.5.0 to compile QEMU
+# if __GNUC__ < 7 || (__GNUC__ == 7 && __GNUC_MINOR__ < 4)
+#  error You need at least GCC v7.4.0 to compile QEMU
 # endif
 #else
 # error You either need GCC or Clang to compiler QEMU