From patchwork Thu Nov 17 09:06:01 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caraman Mihai Claudiu-B02008 X-Patchwork-Id: 126162 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0759EB71F8 for ; Thu, 17 Nov 2011 20:06:16 +1100 (EST) Received: from localhost ([::1]:57536 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQxvA-0008C1-TB for incoming@patchwork.ozlabs.org; Thu, 17 Nov 2011 04:06:12 -0500 Received: from eggs.gnu.org ([140.186.70.92]:41098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQxv5-0008BO-RO for qemu-devel@nongnu.org; Thu, 17 Nov 2011 04:06:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RQxv4-0004Fu-Dh for qemu-devel@nongnu.org; Thu, 17 Nov 2011 04:06:07 -0500 Received: from ch1ehsobe001.messaging.microsoft.com ([216.32.181.181]:53542 helo=ch1outboundpool.messaging.microsoft.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQxv4-0004Fq-9q for qemu-devel@nongnu.org; Thu, 17 Nov 2011 04:06:06 -0500 Received: from mail180-ch1-R.bigfish.com (10.43.68.242) by CH1EHSOBE010.bigfish.com (10.43.70.60) with Microsoft SMTP Server id 14.1.225.22; Thu, 17 Nov 2011 09:05:32 +0000 Received: from mail180-ch1 (localhost [127.0.0.1]) by mail180-ch1-R.bigfish.com (Postfix) with ESMTP id 5D70F3C0092 for ; Thu, 17 Nov 2011 09:05:55 +0000 (UTC) X-SpamScore: 0 X-BigFish: VS0(zzzz1202hzz8275bhz2dh2a8h668h839h8e2h8e3h944h) X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPV:NLI; H:mail.freescale.net; RD:none; EFVD:NLI Received: from mail180-ch1 (localhost.localdomain [127.0.0.1]) by mail180-ch1 (MessageSwitch) id 1321520753269991_32365; Thu, 17 Nov 2011 09:05:53 +0000 (UTC) Received: from CH1EHSMHS029.bigfish.com (snatpool1.int.messaging.microsoft.com [10.43.68.240]) by mail180-ch1.bigfish.com (Postfix) with ESMTP id 3F408100042 for ; Thu, 17 Nov 2011 09:05:53 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by CH1EHSMHS029.bigfish.com (10.43.70.29) with Microsoft SMTP Server (TLS) id 14.1.225.22; Thu, 17 Nov 2011 09:05:30 +0000 Received: from 039-SN1MPN1-006.039d.mgd.msft.net ([169.254.8.169]) by 039-SN1MMR1-001.039d.mgd.msft.net ([10.84.1.13]) with mapi id 14.01.0339.002; Thu, 17 Nov 2011 03:06:02 -0600 From: Caraman Mihai Claudiu-B02008 To: "qemu-devel@nongnu.org" Thread-Topic: ncurses 5.3 conflicts with latest qemu Thread-Index: AcylCB+qRRBA0IiaSX2zjCyeqKQTfA== Date: Thu, 17 Nov 2011 09:06:01 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.171.73.30] MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-detected-operating-system: by eggs.gnu.org: Windows XP/2000 (RFC1323+, w+, tstamp-) X-Received-From: 216.32.181.181 Subject: [Qemu-devel] ncurses 5.3 conflicts with latest qemu X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Hi, A recent patch in qemu conflicts with old ncurses libraries (version 5.3). You will see this error cause by bool type redefinition in curses.h (with CONFIG_CURSES configured by default): console.c: In function 'text_console_init': console.c:1550:23: error: assignment from incompatible pointer type the qemu patch exposing this problem is: curses: fix garbling when chtype != long author Devin J. Pohly Wed, 7 Sep 2011 19:44:36 +0000 (15:44 -0400) committer Anthony Liguori Fri, 9 Sep 2011 17:58:16 +0000 (12:58 -0500) commit df00bed0fa30a6f5712456e7add783e470c534c9 The problem seems to be fixed in newer versions of ncurses (5.7 and above). I just looked over the sources, so better if someone can confirm this. Here is a qemu patch that solve the conflict with old ncurses: Signed-off-by: Mihai Caraman --- Fix compile errors with old ncurses libraries (version 5.3) caused by bool type redefinition. qemu-common.h | 3 +++ console.h | 1 - 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/qemu-common.h b/qemu-common.h index 5e87bdf..9ac15ba 100644 --- a/qemu-common.h +++ b/qemu-common.h @@ -23,6 +23,9 @@ typedef struct Monitor Monitor; #include #include #include +#ifdef CONFIG_CURSES +#include +#endif #include #include #include diff --git a/console.h b/console.h index 9c1487e..3327c43 100644 --- a/console.h +++ b/console.h @@ -329,7 +329,6 @@ static inline int ds_get_bytes_per_pixel(DisplayState *ds) } #ifdef CONFIG_CURSES -#include typedef chtype console_ch_t; #else typedef unsigned long console_ch_t; -- 1.7.4.1