From patchwork Tue May 28 01:19:59 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jacek burghardt X-Patchwork-Id: 246916 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 205432C02AD for ; Wed, 29 May 2013 01:53:42 +1000 (EST) Received: from localhost ([::1]:59136 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhMDU-0002pW-Ak for incoming@patchwork.ozlabs.org; Tue, 28 May 2013 11:53:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uh8aA-0002Ax-C9 for qemu-devel@nongnu.org; Mon, 27 May 2013 21:20:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uh8a1-0001Pw-3f for qemu-devel@nongnu.org; Mon, 27 May 2013 21:20:10 -0400 Received: from mail-ie0-x234.google.com ([2607:f8b0:4001:c03::234]:52880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uh8a0-0001Ps-S4 for qemu-devel@nongnu.org; Mon, 27 May 2013 21:20:01 -0400 Received: by mail-ie0-f180.google.com with SMTP id b11so5411193iee.25 for ; Mon, 27 May 2013 18:20:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=bntqB8x/YjbrnS/wBTIaunnamidDTWogopKEHdt3NGw=; b=CG008ZtPhrb9grMvFRnvxBEFdgYLzSig2++Y7H1I5CVguu56XChEqkOQwvdySeckmK mrl8sB4vOPLMzlj4MMDXG/qIjRQFXmiwRS+14tIdfvot2ePESI2AgZ/NXJ6Vj1urdbGL Qaj6nPefcbU0lOW5/+sR/F9wewESoDLszn1xxeXcGaL3HTiSqO+IxXxkEN4FjD7Yh1+G A9wzCS3WzSkF+056IAWGJF4419SMp+85TQDCx+l6o7qVh8Qftbma9q4O2Kv89x2YKzeL 5br6INpPU/mfQbXHIQ7AvpEN0X6Cdb98YRrX8Q3UxSPz/A54KkNL03z2MSqHknwflImO NFrg== MIME-Version: 1.0 X-Received: by 10.50.25.102 with SMTP id b6mr5850368igg.27.1369703999939; Mon, 27 May 2013 18:19:59 -0700 (PDT) Received: by 10.42.76.137 with HTTP; Mon, 27 May 2013 18:19:59 -0700 (PDT) In-Reply-To: <20130527161227.2bd4c3a3@nial.usersys.redhat.com> References: <20130527161227.2bd4c3a3@nial.usersys.redhat.com> Date: Mon, 27 May 2013 19:19:59 -0600 Message-ID: From: jacek burghardt To: Igor Mammedov X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4001:c03::234 X-Mailman-Approved-At: Tue, 28 May 2013 11:53:02 -0400 Cc: kraxel@redhat.com, qemu-devel@nongnu.org, "xen-devel@lists.xen.org" Subject: Re: [Qemu-devel] [Xen-devel] target-i386: Introduce ICC bus/device/bridge X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Do you think this change will solv the issue? No need for xen_vcpu_init anymore: - the RTC emulator doesn't have any periodic timers continuously running even in absence of guest interactions anymore; - qemu_dummy_start_vcpu takes care of disabling TCG for us, so we don't need to do it manually here. Signed-off-by: Stefano Stabellini --- hw/i386/pc_piix.c | 1 - xen-all.c | 23 ----------------------- 2 files changed, 0 insertions(+), 24 deletions(-) vcpu) { On Mon, May 27, 2013 at 8:12 AM, Igor Mammedov wrote: > On Fri, 24 May 2013 08:56:14 -0600 > jacek burghardt wrote: > > > I wonder if anyone has patch that allows to tlak to icc bus introduced in > > qemu upstream ? > > > https://github.com/qemu/qemu/commit/f0513d2c0156799e0c75a108ab9a049eea4f9607 > > > > icc-bridge will serve as a parent for icc-bus and provide > > mmio mapping services to child icc-devices. > > * icc-device will replace SysBusDevice as a parent of APIC > > and IOAPIC devices. > > looking at xen_init_pv() it creates dummy CPU which appears > not to be used by PV guest. What was the purpose in creating it? > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 43ab480..1ef4cbf 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -324,7 +324,6 @@ static void pc_xen_hvm_init(QEMUMachineInitArgs *args) hw_error("xen hardware virtual machine initialisation failed"); } pc_init_pci_no_kvmclock(args); - xen_vcpu_init(); } #endif diff --git a/xen-all.c b/xen-all.c index 539a154..bc308f4 100644 --- a/xen-all.c +++ b/xen-all.c @@ -574,29 +574,6 @@ void qmp_xen_set_global_dirty_log(bool enable, Error **errp) } } -/* VCPU Operations, MMIO, IO ring ... */ - -static void xen_reset_vcpu(void *opaque) -{ - CPUState *cpu = opaque; - - cpu->halted = 1; -} - -void xen_vcpu_init(void) -{ - if (first_cpu != NULL) { - CPUState *cpu = ENV_GET_CPU(first_cpu); - - qemu_register_reset(xen_reset_vcpu, cpu); - xen_reset_vcpu(cpu); - } - /* if rtc_clock is left to default (host_clock), disable it */ - if (rtc_clock == host_clock) { - qemu_clock_enable(rtc_clock, false); - } -} - /* get the ioreq packets from share mem */ static ioreq_t *cpu_get_ioreq_from_shared_memory(XenIOState *state, int