From patchwork Tue Feb 7 18:55:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 725283 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vHttf29zwz9s2s for ; Wed, 8 Feb 2017 05:59:38 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="IRo7mVBF"; dkim-atps=neutral Received: from localhost ([::1]:55964 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbAzH-0000w8-UY for incoming@patchwork.ozlabs.org; Tue, 07 Feb 2017 13:59:35 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbAvt-0006cg-Gs for qemu-devel@nongnu.org; Tue, 07 Feb 2017 13:56:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbAvs-0001w7-Fj for qemu-devel@nongnu.org; Tue, 07 Feb 2017 13:56:05 -0500 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:36857) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cbAvs-0001vb-6l for qemu-devel@nongnu.org; Tue, 07 Feb 2017 13:56:04 -0500 Received: by mail-wm0-x231.google.com with SMTP id c85so173828259wmi.1 for ; Tue, 07 Feb 2017 10:56:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=h9jrRkFgzdk5PrFFRt/Kld/9Bo73VkOaDfnKWBghoJE=; b=IRo7mVBF77bgMPrvCQTbF8Ph2z1AXxhF3pwyGkR11oM22hNvcLK4J1HcV4NP5Rzsc4 hcDLuCfHAQjhPCpHiCF/bH3vaAz5fQm9Rd76IbWfTgbfRf7M+yphvfLOKoU13CqDpc6k 5uEIeWPNLM94RTLx83wsjd/HJwIIabPdM+Zjo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=h9jrRkFgzdk5PrFFRt/Kld/9Bo73VkOaDfnKWBghoJE=; b=b65bRwduuqmEqZAIQcOoYePW0nvxCOpCz2tjKxQxIzBhstUZiVQBGiw61ifjnfxZ5t bOjcqtNuUp0OLy28ql7eX8NQPjUOlhUx5m5MlxIvSaa/a5K0EPYmevWFEt0/1QLCPjRO UIku5x7bO4Zsag8pVpM9tZ9ICISsz3W1BeG4isexxJr40O5GlS4+RM78MuYT8yjKXEJN mi37SolWGUm/2kxrNcXhXCm5pCp/ak9/6okRHjpvb930Ocq8UhsjwfOvHShlbeiX+9yl Bq8XS1QDqi5GKlok3fq3WEriCEG4PiQEJ9oCmof2wrV8yzvOSnFZQzeTSsIBfU+m9SFK 1ayg== X-Gm-Message-State: AIkVDXLPMIsccXmoGCHgcTAm67OsEW40kqmIjz0aq6m0hPJDA2R0ZcU68jj61N8AVL73t0zemWR7GItsiuXHmBph X-Received: by 10.223.136.152 with SMTP id f24mr14922805wrf.187.1486493762637; Tue, 07 Feb 2017 10:56:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.145.69 with HTTP; Tue, 7 Feb 2017 10:55:42 -0800 (PST) In-Reply-To: <1486492645-27803-1-git-send-email-peter.maydell@linaro.org> References: <1486492645-27803-1-git-send-email-peter.maydell@linaro.org> From: Peter Maydell Date: Tue, 7 Feb 2017 18:55:42 +0000 Message-ID: To: QEMU Developers X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::231 Subject: Re: [Qemu-devel] [PULL 00/13] target-arm queue X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" On 7 February 2017 at 18:37, Peter Maydell wrote: > A random mix of items here, nothing very major. > > thanks > -- PMM > > > The following changes since commit d0dff238a87fa81393ed72754d4dc8b09e50b08b: > > Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20170206' into staging (2017-02-07 15:29:26 +0000) > > are available in the git repository at: > > git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20170207 > > for you to fetch changes up to 7727b832886fafbdec7299eb7773dc9071bf4cdd: > > stellaris: Use the 'unimplemented' device for parts we don't implement (2017-02-07 18:30:00 +0000) > > ---------------------------------------------------------------- > target-arm: > * new "unimplemented" device for stubbing out devices in a > system model so accesses can be logged > * stellaris: document the SoC memory map > * arm: create instruction syndromes for AArch32 data aborts > * arm: Correctly handle watchpoints for BE32 CPUs > * Fix Thumb-1 BE32 execution and disassembly > * arm: Add cfgend parameter for ARM CPU selection > * sd: sdhci: check data length during dma_memory_read > * aspeed: add a watchdog controller > * integratorcp: adding vmstate for save/restore Clang complains about unused functions; will squash in: @@ -997,7 +997,7 @@ static inline void gen_aa32_st##SUFF##_iss(DisasContext *s, \ TCGv_i32 a32, int index, \ ISSInfo issinfo) \ { \ - gen_aa32_st_i32(s, val, a32, index, OPC | s->be_data); \ + gen_aa32_st##SUFF(s, val, a32, index); \ disas_set_da_iss(s, OPC, issinfo | ISSIsWrite); \ } (which avoids the problem by having the _iss() versions of the function call the non-iss versions rather than duplicating their function body; seems like better code anyway.) thanks -- PMM diff --git a/target/arm/translate.c b/target/arm/translate.c index a14f74c..4436d8f 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -982,7 +982,7 @@ static inline void gen_aa32_ld##SUFF##_iss(DisasContext *s, \ TCGv_i32 a32, int index, \ ISSInfo issinfo) \ { \ - gen_aa32_ld_i32(s, val, a32, index, OPC | s->be_data); \ + gen_aa32_ld##SUFF(s, val, a32, index); \ disas_set_da_iss(s, OPC, issinfo); \ }