From patchwork Sat Feb 4 16:49:54 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Blue Swirl X-Patchwork-Id: 139583 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E7AE9104798 for ; Sun, 5 Feb 2012 03:50:24 +1100 (EST) Received: from localhost ([::1]:48156 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rtiog-0001R5-88 for incoming@patchwork.ozlabs.org; Sat, 04 Feb 2012 11:50:22 -0500 Received: from eggs.gnu.org ([140.186.70.92]:60978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rtioa-0001R0-A0 for qemu-devel@nongnu.org; Sat, 04 Feb 2012 11:50:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RtioZ-0005hH-6i for qemu-devel@nongnu.org; Sat, 04 Feb 2012 11:50:16 -0500 Received: from mail-iy0-f173.google.com ([209.85.210.173]:61752) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtioY-0005h5-Uo for qemu-devel@nongnu.org; Sat, 04 Feb 2012 11:50:15 -0500 Received: by iahk25 with SMTP id k25so7798314iah.4 for ; Sat, 04 Feb 2012 08:50:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=O4VlhPGGUzk7g7gL+AdrWo0MreBSQAZIKHT3hipb1+4=; b=bjC0Hb/6/mvxL6JTpsD8z59Ni0LhqMvysC1DZYm7t5FgtrSd/K6m8RMfm2E+vrjnC6 eSod6/vhmmCmPwZOUvh8SAfiG7QEtpds8E4wCVmt+IgQMmGyGjqE005ab+BapVEGdsjY xlF7i8Ezj09fdXBEvsFuNCpkf6gWTWt7Ajgb0= Received: by 10.50.161.231 with SMTP id xv7mr3182753igb.0.1328374214106; Sat, 04 Feb 2012 08:50:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.50.15.167 with HTTP; Sat, 4 Feb 2012 08:49:54 -0800 (PST) In-Reply-To: <4F2D59EE.2020906@web.de> References: <4F2D59EE.2020906@web.de> From: Blue Swirl Date: Sat, 4 Feb 2012 16:49:54 +0000 Message-ID: To: Jan Kiszka X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.210.173 Cc: qemu-devel Subject: Re: [Qemu-devel] [PATCH 0/6] VGA patches X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Sat, Feb 4, 2012 at 16:16, Jan Kiszka wrote: > On 2012-02-04 14:15, Blue Swirl wrote: >> On Sun, Jan 29, 2012 at 19:12, Blue Swirl wrote: >>> Patch 1 has been sent several times, though the logic has been copied >>> from flawed implementations before. >>> >>> Other patches should be trivial. >> >> Pushed. I compared vga.o object files with codiff and objdump >> disassembler before and after the constant patch and the code was >> identical. >> >>> URL     git://repo.or.cz/qemu/blueswirl.git >>>        http://repo.or.cz/r/qemu/blueswirl.git >>> >>> Blue Swirl (6): >>>  memory: change dirty getting API to take a size > > This causes regressions of WinXP guests. The upper half of the screen is > not properly updated. I can't reproduce this, but can you try the following: update |= (s->invalidated_y_table[y >> 5] >> (y & 0x1f)) & 1; diff --git a/hw/vga.c b/hw/vga.c index d87c4f9..729ab8d 100644 --- a/hw/vga.c +++ b/hw/vga.c @@ -1779,7 +1779,7 @@ static void vga_draw_graphic(VGACommonState *s, int full_update) } page0 = addr; page1 = addr + bwidth - 1; - update = memory_region_get_dirty(&s->vram, page0, page1, + update = memory_region_get_dirty(&s->vram, page0, bwidth - 1, DIRTY_MEMORY_VGA); /* explicit invalidation for the hardware cursor */