From patchwork Thu Mar 4 09:00:31 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juan Quintela X-Patchwork-Id: 46891 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6465CB7CE6 for ; Thu, 4 Mar 2010 20:19:43 +1100 (EST) Received: from localhost ([127.0.0.1]:58237 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nn7C3-0003mO-JF for incoming@patchwork.ozlabs.org; Thu, 04 Mar 2010 04:18:07 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nn6vO-0003rj-8I for qemu-devel@nongnu.org; Thu, 04 Mar 2010 04:00:54 -0500 Received: from [199.232.76.173] (port=45404 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nn6vL-0003rM-El for qemu-devel@nongnu.org; Thu, 04 Mar 2010 04:00:51 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nn6vI-0004Qa-Bs for qemu-devel@nongnu.org; Thu, 04 Mar 2010 04:00:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37061) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nn6vH-0004Q6-W7 for qemu-devel@nongnu.org; Thu, 04 Mar 2010 04:00:48 -0500 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2490jJY017882 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 4 Mar 2010 04:00:45 -0500 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2490etV010016; Thu, 4 Mar 2010 04:00:44 -0500 From: Juan Quintela To: qemu-devel@nongnu.org Date: Thu, 4 Mar 2010 10:00:31 +0100 Message-Id: <93c1dcb48b0cfa33775fc45a1ffb9c0edb44d833.1267692963.git.quintela@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.67 on 10.5.11.17 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: [Qemu-devel] [PATCH 02/10] slirp: check system() success X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org we shouldn't call W*() macros until we check that fork worked. Signed-off-by: Juan Quintela Acked-by: Michael S. Tsirkin --- net/slirp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index 317cca7..7f846ec 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -472,7 +472,7 @@ static void slirp_smb_cleanup(SlirpState *s) if (s->smb_dir[0] != '\0') { snprintf(cmd, sizeof(cmd), "rm -rf %s", s->smb_dir); ret = system(cmd); - if (!WIFEXITED(ret)) { + if (ret == -1 || !WIFEXITED(ret)) { qemu_error("'%s' failed.\n", cmd); } else if (WEXITSTATUS(ret)) { qemu_error("'%s' failed. Error code: %d\n",