| Message ID | 8a940c893b26ec19d741d2efe929b85df559d850.1588587700.git.lukasstraub2@web.de |
|---|---|
| State | New |
| Headers | show |
| Series | colo-compare bugfixes | expand |
On 5/4/20 12:28 PM, Lukas Straub wrote: > Else the log will be flooded if there is a lot of network > traffic. > > Signed-off-by: Lukas Straub <lukasstraub2@web.de> > Reviewed-by: Zhang Chen <chen.zhang@intel.com> > --- > net/colo-compare.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/net/colo-compare.c b/net/colo-compare.c > index 2a4e7f7c4e..56db3d3bfc 100644 > --- a/net/colo-compare.c > +++ b/net/colo-compare.c > @@ -483,10 +483,12 @@ sec: > g_queue_push_head(&conn->primary_list, ppkt); > g_queue_push_head(&conn->secondary_list, spkt); > > - qemu_hexdump((char *)ppkt->data, stderr, > - "colo-compare ppkt", ppkt->size); > - qemu_hexdump((char *)spkt->data, stderr, > - "colo-compare spkt", spkt->size); > + if (trace_event_get_state_backends(TRACE_COLO_COMPARE_MISCOMPARE)) { Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > + qemu_hexdump((char *)ppkt->data, stderr, > + "colo-compare ppkt", ppkt->size); > + qemu_hexdump((char *)spkt->data, stderr, > + "colo-compare spkt", spkt->size); > + } > > colo_compare_inconsistency_notify(s); > } >
On 5/4/20 1:27 PM, Philippe Mathieu-Daudé wrote: > On 5/4/20 12:28 PM, Lukas Straub wrote: >> Else the log will be flooded if there is a lot of network >> traffic. >> >> Signed-off-by: Lukas Straub <lukasstraub2@web.de> >> Reviewed-by: Zhang Chen <chen.zhang@intel.com> >> --- >> net/colo-compare.c | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/net/colo-compare.c b/net/colo-compare.c >> index 2a4e7f7c4e..56db3d3bfc 100644 >> --- a/net/colo-compare.c >> +++ b/net/colo-compare.c >> @@ -483,10 +483,12 @@ sec: >> g_queue_push_head(&conn->primary_list, ppkt); >> g_queue_push_head(&conn->secondary_list, spkt); >> - qemu_hexdump((char *)ppkt->data, stderr, >> - "colo-compare ppkt", ppkt->size); >> - qemu_hexdump((char *)spkt->data, stderr, >> - "colo-compare spkt", spkt->size); >> + if >> (trace_event_get_state_backends(TRACE_COLO_COMPARE_MISCOMPARE)) { > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> > >> + qemu_hexdump((char *)ppkt->data, stderr, >> + "colo-compare ppkt", ppkt->size); >> + qemu_hexdump((char *)spkt->data, stderr, >> + "colo-compare spkt", spkt->size); >> + } >> colo_compare_inconsistency_notify(s); >> } >>
diff --git a/net/colo-compare.c b/net/colo-compare.c index 2a4e7f7c4e..56db3d3bfc 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -483,10 +483,12 @@ sec: g_queue_push_head(&conn->primary_list, ppkt); g_queue_push_head(&conn->secondary_list, spkt); - qemu_hexdump((char *)ppkt->data, stderr, - "colo-compare ppkt", ppkt->size); - qemu_hexdump((char *)spkt->data, stderr, - "colo-compare spkt", spkt->size); + if (trace_event_get_state_backends(TRACE_COLO_COMPARE_MISCOMPARE)) { + qemu_hexdump((char *)ppkt->data, stderr, + "colo-compare ppkt", ppkt->size); + qemu_hexdump((char *)spkt->data, stderr, + "colo-compare spkt", spkt->size); + } colo_compare_inconsistency_notify(s); }