From patchwork Tue Jul 30 19:10:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Novotny X-Patchwork-Id: 263516 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 528182C00C2 for ; Wed, 31 Jul 2013 05:11:24 +1000 (EST) Received: from localhost ([::1]:54001 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4FKL-0002Jb-Ir for incoming@patchwork.ozlabs.org; Tue, 30 Jul 2013 15:11:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4FJt-0002C5-B0 for qemu-devel@nongnu.org; Tue, 30 Jul 2013 15:10:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4FJo-0007MF-9Y for qemu-devel@nongnu.org; Tue, 30 Jul 2013 15:10:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57262) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4FJn-0007Lz-VE for qemu-devel@nongnu.org; Tue, 30 Jul 2013 15:10:48 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6UJAlhr005560 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 30 Jul 2013 15:10:47 -0400 Received: from miglaptop.brq.redhat.com (dhcp-26-175.brq.redhat.com [10.34.26.175]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r6UJAj7V008707 for ; Tue, 30 Jul 2013 15:10:46 -0400 From: Michal Novotny To: qemu-devel@nongnu.org Date: Tue, 30 Jul 2013 21:10:44 +0200 Message-Id: <7f847cb5fd7c350e1460df5772c5a0481bc77b3c.1375211373.git.minovotn@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v3] vl.c: Output error on invalid machine type provided X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Output error message when user provides the invalid machine type on the command line. This also saves time to find what issue is when you upgrade from one version of qemu to another version that doesn't support required machine type any longer. Signed-off-by: Michal Novotny Reviewed-by: Eric Blake --- The patch is checked using ./scripts/checkpatch.pl script and also is_help_option() function is being used. vl.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/vl.c b/vl.c index 25b8f2f..dc5241b 100644 --- a/vl.c +++ b/vl.c @@ -2671,6 +2671,11 @@ static QEMUMachine *machine_parse(const char *name) if (machine) { return machine; } + + if (name && !is_help_option(name)) { + printf("Error: Unsupported machine type '%s'\n", name); + } + printf("Supported machines are:\n"); for (m = first_machine; m != NULL; m = m->next) { if (m->alias) {