diff mbox

[v3,1/3] i.MX: Add GPIO device

Message ID 7bfbee11405de3953bb01ed402e788fd3f5e5739.1441758297.git.jcd@tribudubois.net
State New
Headers show

Commit Message

Jean-Christophe Dubois Sept. 9, 2015, 12:38 a.m. UTC
Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
---

Changes since V1:
  * added "has-edge-sel" property 
  * use extract64() and deposit64() in read/write icr access
  * set "number of GPIO pin" as a #define
  * reorganize functions in file to group them
  * various coding style cleanup
  * rename state handler array in output array.
 
Changes since v2: 
  * always compile DEBUG functions 
  * Fix imx_gpio_update_int to use isr, imr and gdir
  * Fix imx_gpio_set_int_line to check gdir instead of imr
  * Fix imx_gpio_set to update psr even if line is output
  * Fix PSR read to use gdir.

 hw/gpio/Makefile.objs      |   1 +
 hw/gpio/imx_gpio.c         | 340 +++++++++++++++++++++++++++++++++++++++++++++
 include/hw/gpio/imx_gpio.h |  63 +++++++++
 3 files changed, 404 insertions(+)
 create mode 100644 hw/gpio/imx_gpio.c
 create mode 100644 include/hw/gpio/imx_gpio.h

Comments

Peter Crosthwaite Sept. 9, 2015, 7:09 a.m. UTC | #1
On Tue, Sep 8, 2015 at 5:38 PM, Jean-Christophe Dubois
<jcd@tribudubois.net> wrote:
> Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
> ---
>
> Changes since V1:
>   * added "has-edge-sel" property
>   * use extract64() and deposit64() in read/write icr access
>   * set "number of GPIO pin" as a #define
>   * reorganize functions in file to group them
>   * various coding style cleanup
>   * rename state handler array in output array.
>
> Changes since v2:
>   * always compile DEBUG functions
>   * Fix imx_gpio_update_int to use isr, imr and gdir
>   * Fix imx_gpio_set_int_line to check gdir instead of imr
>   * Fix imx_gpio_set to update psr even if line is output
>   * Fix PSR read to use gdir.
>
>  hw/gpio/Makefile.objs      |   1 +
>  hw/gpio/imx_gpio.c         | 340 +++++++++++++++++++++++++++++++++++++++++++++
>  include/hw/gpio/imx_gpio.h |  63 +++++++++
>  3 files changed, 404 insertions(+)
>  create mode 100644 hw/gpio/imx_gpio.c
>  create mode 100644 include/hw/gpio/imx_gpio.h
>
> diff --git a/hw/gpio/Makefile.objs b/hw/gpio/Makefile.objs
> index 1abcf17..52233f7 100644
> --- a/hw/gpio/Makefile.objs
> +++ b/hw/gpio/Makefile.objs
> @@ -5,3 +5,4 @@ common-obj-$(CONFIG_ZAURUS) += zaurus.o
>  common-obj-$(CONFIG_E500) += mpc8xxx.o
>
>  obj-$(CONFIG_OMAP) += omap_gpio.o
> +obj-$(CONFIG_IMX) += imx_gpio.o
> diff --git a/hw/gpio/imx_gpio.c b/hw/gpio/imx_gpio.c
> new file mode 100644
> index 0000000..f8d7ef8
> --- /dev/null
> +++ b/hw/gpio/imx_gpio.c
> @@ -0,0 +1,340 @@
> +/*
> + * i.MX processors GPIO emulation.
> + *
> + * Copyright (C) 2015 Jean-Christophe Dubois <jcd@tribudubois.net>
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 or
> + * (at your option) version 3 of the License.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License along
> + * with this program; if not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#include "hw/gpio/imx_gpio.h"
> +
> +#ifndef DEBUG_IMX_GPIO
> +#define DEBUG_IMX_GPIO 0
> +#endif
> +
> +typedef enum IMXGPIOLevel {
> +    IMX_GPIO_LEVEL_LOW = 0,
> +    IMX_GPIO_LEVEL_HIGH = 1,
> +} IMXGPIOLevel;
> +
> +#define DPRINTF(fmt, args...) \
> +          do { \
> +              if (DEBUG_IMX_GPIO) { \
> +                  fprintf(stderr, "%s: " fmt , __func__, ##args); \
> +              } \
> +          } while (0)
> +
> +static const char *imx_gpio_reg_name(uint32_t reg)
> +{
> +    switch (reg) {
> +    case DR_ADDR:
> +        return "DR";
> +    case GDIR_ADDR:
> +        return "GDIR";
> +    case PSR_ADDR:
> +        return "PSR";
> +    case ICR1_ADDR:
> +        return "ICR1";
> +    case ICR2_ADDR:
> +        return "ICR2";
> +    case IMR_ADDR:
> +        return "IMR";
> +    case ISR_ADDR:
> +        return "ISR";
> +    case EDGE_SEL_ADDR:
> +        return "EDGE_SEL";
> +    default:
> +        return "[?]";
> +    }
> +}
> +
> +static void imx_gpio_update_int(IMXGPIOState *s)
> +{
> +    qemu_set_irq(s->irq, (s->isr & s->imr & ~s->gdir) ? 1 : 0);

This doesn't look right, having it conditional on the gdir. I think
you already implement the gdir masking in set_int_line, why do you
need this extra mask?

> +}
> +
> +static void imx_gpio_set_int_line(IMXGPIOState *s, int line, IMXGPIOLevel level)
> +{
> +    /* if this signal isn't configured as an input signal, nothing to do */
>

> +/* i.MX GPIO memory map */
> +#define DR_ADDR             0x00 /* DATA REGISTER */
> +#define GDIR_ADDR           0x04 /* DIRECTION REGISTER */
> +#define PSR_ADDR            0x08 /* PAD STATUS REGISTER */
> +#define ICR1_ADDR           0x0c /* INTERRUPT CONFIGURATION REGISTER 1 */
> +#define ICR2_ADDR           0x10 /* INTERRUPT CONFIGURATION REGISTER 2 */
> +#define IMR_ADDR            0x14 /* INTERRUPT MASK REGISTER */
> +#define ISR_ADDR            0x18 /* INTERRUPT STATUS REGISTER */
> +#define EDGE_SEL_ADDR       0x1c /* EDGE SEL REGISTER */
> +
> +#define IMX_GPIO_PIN_COUNT 32
> +
> +typedef struct IMXGPIOState {
> +    /*< private >*/
> +    SysBusDevice parent_obj;
> +
> +    /*< public >*/
> +    MemoryRegion iomem;
> +
> +    uint32_t dr;
> +    uint32_t gdir;
> +    uint32_t psr;
> +    uint64_t icr;
> +    uint32_t imr;
> +    uint32_t isr;
> +    bool has_edge_sel;
> +    /* This register is not present in i.MX31 */

Drop comment.

Otherwise,

Reviewed-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>

Regards,
Peter

> +    uint32_t edge_sel;
> +
> +    qemu_irq irq;
> +    qemu_irq output[IMX_GPIO_PIN_COUNT];
> +} IMXGPIOState;
> +
> +#endif /* __IMX_GPIO_H_ */
> --
> 2.1.4
>
Jean-Christophe Dubois Sept. 9, 2015, 8:02 p.m. UTC | #2
Le 09/09/2015 09:09, Peter Crosthwaite a écrit :
> On Tue, Sep 8, 2015 at 5:38 PM, Jean-Christophe Dubois
> <jcd@tribudubois.net> wrote:
>> Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
>> ---
>>
>> Changes since V1:
>>    * added "has-edge-sel" property
>>    * use extract64() and deposit64() in read/write icr access
>>    * set "number of GPIO pin" as a #define
>>    * reorganize functions in file to group them
>>    * various coding style cleanup
>>    * rename state handler array in output array.
>>
>> Changes since v2:
>>    * always compile DEBUG functions
>>    * Fix imx_gpio_update_int to use isr, imr and gdir
>>    * Fix imx_gpio_set_int_line to check gdir instead of imr
>>    * Fix imx_gpio_set to update psr even if line is output
>>    * Fix PSR read to use gdir.
>>
>>   hw/gpio/Makefile.objs      |   1 +
>>   hw/gpio/imx_gpio.c         | 340 +++++++++++++++++++++++++++++++++++++++++++++
>>   include/hw/gpio/imx_gpio.h |  63 +++++++++
>>   3 files changed, 404 insertions(+)
>>   create mode 100644 hw/gpio/imx_gpio.c
>>   create mode 100644 include/hw/gpio/imx_gpio.h
>>
>> diff --git a/hw/gpio/Makefile.objs b/hw/gpio/Makefile.objs
>> index 1abcf17..52233f7 100644
>> --- a/hw/gpio/Makefile.objs
>> +++ b/hw/gpio/Makefile.objs
>> @@ -5,3 +5,4 @@ common-obj-$(CONFIG_ZAURUS) += zaurus.o
>>   common-obj-$(CONFIG_E500) += mpc8xxx.o
>>
>>   obj-$(CONFIG_OMAP) += omap_gpio.o
>> +obj-$(CONFIG_IMX) += imx_gpio.o
>> diff --git a/hw/gpio/imx_gpio.c b/hw/gpio/imx_gpio.c
>> new file mode 100644
>> index 0000000..f8d7ef8
>> --- /dev/null
>> +++ b/hw/gpio/imx_gpio.c
>> @@ -0,0 +1,340 @@
>> +/*
>> + * i.MX processors GPIO emulation.
>> + *
>> + * Copyright (C) 2015 Jean-Christophe Dubois <jcd@tribudubois.net>
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License as
>> + * published by the Free Software Foundation; either version 2 or
>> + * (at your option) version 3 of the License.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License along
>> + * with this program; if not, see <http://www.gnu.org/licenses/>.
>> + */
>> +
>> +#include "hw/gpio/imx_gpio.h"
>> +
>> +#ifndef DEBUG_IMX_GPIO
>> +#define DEBUG_IMX_GPIO 0
>> +#endif
>> +
>> +typedef enum IMXGPIOLevel {
>> +    IMX_GPIO_LEVEL_LOW = 0,
>> +    IMX_GPIO_LEVEL_HIGH = 1,
>> +} IMXGPIOLevel;
>> +
>> +#define DPRINTF(fmt, args...) \
>> +          do { \
>> +              if (DEBUG_IMX_GPIO) { \
>> +                  fprintf(stderr, "%s: " fmt , __func__, ##args); \
>> +              } \
>> +          } while (0)
>> +
>> +static const char *imx_gpio_reg_name(uint32_t reg)
>> +{
>> +    switch (reg) {
>> +    case DR_ADDR:
>> +        return "DR";
>> +    case GDIR_ADDR:
>> +        return "GDIR";
>> +    case PSR_ADDR:
>> +        return "PSR";
>> +    case ICR1_ADDR:
>> +        return "ICR1";
>> +    case ICR2_ADDR:
>> +        return "ICR2";
>> +    case IMR_ADDR:
>> +        return "IMR";
>> +    case ISR_ADDR:
>> +        return "ISR";
>> +    case EDGE_SEL_ADDR:
>> +        return "EDGE_SEL";
>> +    default:
>> +        return "[?]";
>> +    }
>> +}
>> +
>> +static void imx_gpio_update_int(IMXGPIOState *s)
>> +{
>> +    qemu_set_irq(s->irq, (s->isr & s->imr & ~s->gdir) ? 1 : 0);
> This doesn't look right, having it conditional on the gdir. I think
> you already implement the gdir masking in set_int_line, why do you
> need this extra mask?
This might be extra cautious (and unnecessary) but in order to raise an 
interrupt a "line"/pin needs to be set as an input line.

But OK, I'll remove it as it is also taken care of elsewhere (set_int_line).
>
>> +}
>> +
>> +static void imx_gpio_set_int_line(IMXGPIOState *s, int line, IMXGPIOLevel level)
>> +{
>> +    /* if this signal isn't configured as an input signal, nothing to do */
>>
>> +/* i.MX GPIO memory map */
>> +#define DR_ADDR             0x00 /* DATA REGISTER */
>> +#define GDIR_ADDR           0x04 /* DIRECTION REGISTER */
>> +#define PSR_ADDR            0x08 /* PAD STATUS REGISTER */
>> +#define ICR1_ADDR           0x0c /* INTERRUPT CONFIGURATION REGISTER 1 */
>> +#define ICR2_ADDR           0x10 /* INTERRUPT CONFIGURATION REGISTER 2 */
>> +#define IMR_ADDR            0x14 /* INTERRUPT MASK REGISTER */
>> +#define ISR_ADDR            0x18 /* INTERRUPT STATUS REGISTER */
>> +#define EDGE_SEL_ADDR       0x1c /* EDGE SEL REGISTER */
>> +
>> +#define IMX_GPIO_PIN_COUNT 32
>> +
>> +typedef struct IMXGPIOState {
>> +    /*< private >*/
>> +    SysBusDevice parent_obj;
>> +
>> +    /*< public >*/
>> +    MemoryRegion iomem;
>> +
>> +    uint32_t dr;
>> +    uint32_t gdir;
>> +    uint32_t psr;
>> +    uint64_t icr;
>> +    uint32_t imr;
>> +    uint32_t isr;
>> +    bool has_edge_sel;
>> +    /* This register is not present in i.MX31 */
> Drop comment.
OK
>
> Otherwise,
>
> Reviewed-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
>
> Regards,
> Peter
>
>> +    uint32_t edge_sel;
>> +
>> +    qemu_irq irq;
>> +    qemu_irq output[IMX_GPIO_PIN_COUNT];
>> +} IMXGPIOState;
>> +
>> +#endif /* __IMX_GPIO_H_ */
>> --
>> 2.1.4
>>
diff mbox

Patch

diff --git a/hw/gpio/Makefile.objs b/hw/gpio/Makefile.objs
index 1abcf17..52233f7 100644
--- a/hw/gpio/Makefile.objs
+++ b/hw/gpio/Makefile.objs
@@ -5,3 +5,4 @@  common-obj-$(CONFIG_ZAURUS) += zaurus.o
 common-obj-$(CONFIG_E500) += mpc8xxx.o
 
 obj-$(CONFIG_OMAP) += omap_gpio.o
+obj-$(CONFIG_IMX) += imx_gpio.o
diff --git a/hw/gpio/imx_gpio.c b/hw/gpio/imx_gpio.c
new file mode 100644
index 0000000..f8d7ef8
--- /dev/null
+++ b/hw/gpio/imx_gpio.c
@@ -0,0 +1,340 @@ 
+/*
+ * i.MX processors GPIO emulation.
+ *
+ * Copyright (C) 2015 Jean-Christophe Dubois <jcd@tribudubois.net>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 or
+ * (at your option) version 3 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "hw/gpio/imx_gpio.h"
+
+#ifndef DEBUG_IMX_GPIO
+#define DEBUG_IMX_GPIO 0
+#endif
+
+typedef enum IMXGPIOLevel {
+    IMX_GPIO_LEVEL_LOW = 0,
+    IMX_GPIO_LEVEL_HIGH = 1,
+} IMXGPIOLevel;
+
+#define DPRINTF(fmt, args...) \
+          do { \
+              if (DEBUG_IMX_GPIO) { \
+                  fprintf(stderr, "%s: " fmt , __func__, ##args); \
+              } \
+          } while (0)
+
+static const char *imx_gpio_reg_name(uint32_t reg)
+{
+    switch (reg) {
+    case DR_ADDR:
+        return "DR";
+    case GDIR_ADDR:
+        return "GDIR";
+    case PSR_ADDR:
+        return "PSR";
+    case ICR1_ADDR:
+        return "ICR1";
+    case ICR2_ADDR:
+        return "ICR2";
+    case IMR_ADDR:
+        return "IMR";
+    case ISR_ADDR:
+        return "ISR";
+    case EDGE_SEL_ADDR:
+        return "EDGE_SEL";
+    default:
+        return "[?]";
+    }
+}
+
+static void imx_gpio_update_int(IMXGPIOState *s)
+{
+    qemu_set_irq(s->irq, (s->isr & s->imr & ~s->gdir) ? 1 : 0);
+}
+
+static void imx_gpio_set_int_line(IMXGPIOState *s, int line, IMXGPIOLevel level)
+{
+    /* if this signal isn't configured as an input signal, nothing to do */
+    if (!extract32(s->gdir, line, 1)) {
+        return;
+    }
+
+    /* When set, EDGE_SEL overrides the ICR config */
+    if (extract32(s->edge_sel, line, 1)) {
+        /* we detect interrupt on rising and falling edge */
+        if (extract32(s->psr, line, 1) != level) {
+            /* level changed */
+            s->isr = deposit32(s->isr, line, 1, 1);
+        }
+    } else if (extract64(s->icr, 2*line + 1, 1)) {
+        /* interrupt is edge sensitive */
+        if (extract32(s->psr, line, 1) != level) {
+            /* level changed */
+            if (extract64(s->icr, 2*line, 1) != level) {
+                s->isr = deposit32(s->isr, line, 1, 1);
+            }
+        }
+    } else {
+        /* interrupt is level sensitive */
+        if (extract64(s->icr, 2*line, 1) == level) {
+            s->isr = deposit32(s->isr, line, 1, 1);
+        }
+    }
+}
+
+static void imx_gpio_set(void *opaque, int line, int level)
+{
+    IMXGPIOState *s = IMX_GPIO(opaque);
+    IMXGPIOLevel imx_level = level ? IMX_GPIO_LEVEL_HIGH : IMX_GPIO_LEVEL_LOW;
+
+    imx_gpio_set_int_line(s, line, imx_level);
+
+    /* this is an input signal, so set PSR */
+    s->psr = deposit32(s->psr, line, 1, imx_level);
+
+    imx_gpio_update_int(s);
+}
+
+static void imx_gpio_set_all_int_lines(IMXGPIOState *s)
+{
+    int i;
+
+    for (i = 0; i < IMX_GPIO_PIN_COUNT; i++) {
+        IMXGPIOLevel imx_level = extract32(s->psr, i, 1);
+        imx_gpio_set_int_line(s, i, imx_level);
+    }
+
+    imx_gpio_update_int(s);
+}
+
+static inline void imx_gpio_set_all_output_lines(IMXGPIOState *s)
+{
+    int i;
+
+    for (i = 0; i < IMX_GPIO_PIN_COUNT; i++) {
+        /*
+         * if the line is set as output, then forward the line
+         * level to its user.
+         */
+        if (extract32(s->gdir, i, 1) && s->output[i]) {
+            qemu_set_irq(s->output[i], extract32(s->dr, i, 1));
+        }
+    }
+}
+
+static uint64_t imx_gpio_read(void *opaque, hwaddr offset, unsigned size)
+{
+    IMXGPIOState *s = IMX_GPIO(opaque);
+    uint32_t reg_value = 0;
+
+    switch (offset) {
+    case DR_ADDR:
+        /*
+         * depending on the "line" configuration, the bit values
+         * are coming either from DR or PSR
+         */
+        reg_value = (s->dr & s->gdir) | (s->psr & ~s->gdir);
+        break;
+
+    case GDIR_ADDR:
+        reg_value = s->gdir;
+        break;
+
+    case PSR_ADDR:
+        reg_value = s->psr & ~s->gdir;
+        break;
+
+    case ICR1_ADDR:
+        reg_value = extract64(s->icr, 0, 32);
+        break;
+
+    case ICR2_ADDR:
+        reg_value = extract64(s->icr, 32, 32);
+        break;
+
+    case IMR_ADDR:
+        reg_value = s->imr;
+        break;
+
+    case ISR_ADDR:
+        reg_value = s->isr;
+        break;
+
+    case EDGE_SEL_ADDR:
+        if (s->has_edge_sel) {
+            reg_value = s->edge_sel;
+        } else {
+            qemu_log_mask(LOG_GUEST_ERROR, "%s[%s]: EDGE_SEL register not "
+                          "present on this version of GPIO device\n",
+                          TYPE_IMX_GPIO, __func__);
+        }
+        break;
+
+    default:
+        qemu_log_mask(LOG_GUEST_ERROR, "%s[%s]: Bad register at offset %d\n",
+                      TYPE_IMX_GPIO, __func__, (int)offset);
+        break;
+    }
+
+    DPRINTF("(%s) = 0x%"PRIx32"\n", imx_gpio_reg_name(offset), reg_value);
+
+    return reg_value;
+}
+
+static void imx_gpio_write(void *opaque, hwaddr offset, uint64_t value,
+                           unsigned size)
+{
+    IMXGPIOState *s = IMX_GPIO(opaque);
+
+    DPRINTF("(%s, value = 0x%"PRIx32")\n", imx_gpio_reg_name(offset),
+            (uint32_t)value);
+
+    switch (offset) {
+    case DR_ADDR:
+        s->dr = value;
+        imx_gpio_set_all_output_lines(s);
+        break;
+
+    case GDIR_ADDR:
+        s->gdir = value;
+        imx_gpio_set_all_output_lines(s);
+        imx_gpio_set_all_int_lines(s);
+        break;
+
+    case ICR1_ADDR:
+        s->icr = deposit64(s->icr, 0, 32, value);
+        imx_gpio_set_all_int_lines(s);
+        break;
+
+    case ICR2_ADDR:
+        s->icr = deposit64(s->icr, 32, 32, value);
+        imx_gpio_set_all_int_lines(s);
+        break;
+
+    case IMR_ADDR:
+        s->imr = value;
+        imx_gpio_update_int(s);
+        break;
+
+    case ISR_ADDR:
+        s->isr |= ~value;
+        imx_gpio_set_all_int_lines(s);
+        break;
+
+    case EDGE_SEL_ADDR:
+        if (s->has_edge_sel) {
+            s->edge_sel = value;
+            imx_gpio_set_all_int_lines(s);
+        } else {
+            qemu_log_mask(LOG_GUEST_ERROR, "%s[%s]: EDGE_SEL register not "
+                          "present on this version of GPIO device\n",
+                          TYPE_IMX_GPIO, __func__);
+        }
+        break;
+
+    default:
+        qemu_log_mask(LOG_GUEST_ERROR, "%s[%s]: Bad register at offset %d\n",
+                      TYPE_IMX_GPIO, __func__, (int)offset);
+        break;
+    }
+
+    return;
+}
+
+static const MemoryRegionOps imx_gpio_ops = {
+    .read = imx_gpio_read,
+    .write = imx_gpio_write,
+    .valid.min_access_size = 4,
+    .valid.max_access_size = 4,
+    .endianness = DEVICE_NATIVE_ENDIAN,
+};
+
+static const VMStateDescription vmstate_imx_gpio = {
+    .name = TYPE_IMX_GPIO,
+    .version_id = 1,
+    .minimum_version_id = 1,
+    .minimum_version_id_old = 1,
+    .fields = (VMStateField[]) {
+        VMSTATE_UINT32(dr, IMXGPIOState),
+        VMSTATE_UINT32(gdir, IMXGPIOState),
+        VMSTATE_UINT32(psr, IMXGPIOState),
+        VMSTATE_UINT64(icr, IMXGPIOState),
+        VMSTATE_UINT32(imr, IMXGPIOState),
+        VMSTATE_UINT32(isr, IMXGPIOState),
+        VMSTATE_BOOL(has_edge_sel, IMXGPIOState),
+        VMSTATE_UINT32(edge_sel, IMXGPIOState),
+        VMSTATE_END_OF_LIST()
+    }
+};
+
+static Property imx_gpio_properties[] = {
+    DEFINE_PROP_BOOL("has-edge-sel", IMXGPIOState, has_edge_sel, true),
+    DEFINE_PROP_END_OF_LIST(),
+};
+
+static void imx_gpio_reset(DeviceState *dev)
+{
+    IMXGPIOState *s = IMX_GPIO(dev);
+
+    s->dr       = 0;
+    s->gdir     = 0;
+    s->psr      = 0;
+    s->icr      = 0;
+    s->imr      = 0;
+    s->isr      = 0;
+    s->edge_sel = 0;
+
+    imx_gpio_set_all_output_lines(s);
+    imx_gpio_update_int(s);
+}
+
+static void imx_gpio_realize(DeviceState *dev, Error **errp)
+{
+    IMXGPIOState *s = IMX_GPIO(dev);
+
+    memory_region_init_io(&s->iomem, OBJECT(s), &imx_gpio_ops, s,
+                          TYPE_IMX_GPIO, IMX_GPIO_MEM_SIZE);
+
+    qdev_init_gpio_in(DEVICE(s), imx_gpio_set, IMX_GPIO_PIN_COUNT);
+    qdev_init_gpio_out(DEVICE(s), s->output, IMX_GPIO_PIN_COUNT);
+
+    sysbus_init_irq(SYS_BUS_DEVICE(dev), &s->irq);
+    sysbus_init_mmio(SYS_BUS_DEVICE(dev), &s->iomem);
+}
+
+static void imx_gpio_class_init(ObjectClass *klass, void *data)
+{
+    DeviceClass *dc = DEVICE_CLASS(klass);
+
+    dc->realize = imx_gpio_realize;
+    dc->reset = imx_gpio_reset;
+    dc->props = imx_gpio_properties;
+    dc->vmsd = &vmstate_imx_gpio;
+    dc->desc = "i.MX GPIO controller";
+}
+
+static const TypeInfo imx_gpio_info = {
+    .name = TYPE_IMX_GPIO,
+    .parent = TYPE_SYS_BUS_DEVICE,
+    .instance_size = sizeof(IMXGPIOState),
+    .class_init = imx_gpio_class_init,
+};
+
+static void imx_gpio_register_types(void)
+{
+    type_register_static(&imx_gpio_info);
+}
+
+type_init(imx_gpio_register_types)
diff --git a/include/hw/gpio/imx_gpio.h b/include/hw/gpio/imx_gpio.h
new file mode 100644
index 0000000..1e09e62
--- /dev/null
+++ b/include/hw/gpio/imx_gpio.h
@@ -0,0 +1,63 @@ 
+/*
+ * i.MX processors GPIO registers definition.
+ *
+ * Copyright (C) 2015 Jean-Christophe Dubois <jcd@tribudubois.net>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 or
+ * (at your option) version 3 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef __IMX_GPIO_H_
+#define __IMX_GPIO_H_
+
+#include <hw/sysbus.h>
+
+#define TYPE_IMX_GPIO "imx.gpio"
+#define IMX_GPIO(obj) OBJECT_CHECK(IMXGPIOState, (obj), TYPE_IMX_GPIO)
+
+#define IMX_GPIO_MEM_SIZE 0x20
+
+/* i.MX GPIO memory map */
+#define DR_ADDR             0x00 /* DATA REGISTER */
+#define GDIR_ADDR           0x04 /* DIRECTION REGISTER */
+#define PSR_ADDR            0x08 /* PAD STATUS REGISTER */
+#define ICR1_ADDR           0x0c /* INTERRUPT CONFIGURATION REGISTER 1 */
+#define ICR2_ADDR           0x10 /* INTERRUPT CONFIGURATION REGISTER 2 */
+#define IMR_ADDR            0x14 /* INTERRUPT MASK REGISTER */
+#define ISR_ADDR            0x18 /* INTERRUPT STATUS REGISTER */
+#define EDGE_SEL_ADDR       0x1c /* EDGE SEL REGISTER */
+
+#define IMX_GPIO_PIN_COUNT 32
+
+typedef struct IMXGPIOState {
+    /*< private >*/
+    SysBusDevice parent_obj;
+
+    /*< public >*/
+    MemoryRegion iomem;
+
+    uint32_t dr;
+    uint32_t gdir;
+    uint32_t psr;
+    uint64_t icr;
+    uint32_t imr;
+    uint32_t isr;
+    bool has_edge_sel;
+    /* This register is not present in i.MX31 */
+    uint32_t edge_sel;
+
+    qemu_irq irq;
+    qemu_irq output[IMX_GPIO_PIN_COUNT];
+} IMXGPIOState;
+
+#endif /* __IMX_GPIO_H_ */