diff mbox

[for-2.0] scripts/make-release: Don't distribute .git directories

Message ID 7bd1da678bd39335a69894433070611baf7c2968.1394815484.git.crobinso@redhat.com
State New
Headers show

Commit Message

Cole Robinson March 14, 2014, 4:45 p.m. UTC
[crobinso@localhost qemu-2.0.0-rc0]$ find . -name .git
./dtc/.git
./pixman/.git

This is already done for the rom submodules.

https://bugs.launchpad.net/qemu/+bug/1224414
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 scripts/make-release | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laszlo Ersek March 14, 2014, 6:30 p.m. UTC | #1
On 03/14/14 17:45, Cole Robinson wrote:
> [crobinso@localhost qemu-2.0.0-rc0]$ find . -name .git
> ./dtc/.git
> ./pixman/.git
> 
> This is already done for the rom submodules.
> 
> https://bugs.launchpad.net/qemu/+bug/1224414
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>  scripts/make-release | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/make-release b/scripts/make-release
> index 196c755..cb7c2da 100755
> --- a/scripts/make-release
> +++ b/scripts/make-release
> @@ -18,7 +18,7 @@ git clone "${src}" ${destination}
>  pushd ${destination}
>  git checkout "v${version}"
>  git submodule update --init
> -rm -rf .git roms/*/.git
> +rm -rf .git roms/*/.git dtc/.git pixman/*.git
>  popd
>  tar cfj ${destination}.tar.bz2 ${destination}
>  rm -rf ${destination}
> 

This seems to be complete:

.gitmodules:[submodule "roms/vgabios"]
.gitmodules:[submodule "roms/seabios"]
.gitmodules:[submodule "roms/SLOF"]
.gitmodules:[submodule "roms/ipxe"]
.gitmodules:[submodule "roms/openbios"]
.gitmodules:[submodule "roms/openhackware"]
.gitmodules:[submodule "roms/qemu-palcode"]
.gitmodules:[submodule "roms/sgabios"]
.gitmodules:[submodule "pixman"]
.gitmodules:[submodule "dtc"]

but did you in fact mean

  pixman/*.git

rather tan

  pixman/.git

?

Thanks
Laszlo
Michael Tokarev March 14, 2014, 7:38 p.m. UTC | #2
14.03.2014 22:30, Laszlo Ersek wrote:
[]
> but did you in fact mean
> 
>   pixman/*.git
> 
> rather tan
> 
>   pixman/.git

This has been fixed in a v2 patch, which I applied to -trivial.

Thanks,

/mjt
diff mbox

Patch

diff --git a/scripts/make-release b/scripts/make-release
index 196c755..cb7c2da 100755
--- a/scripts/make-release
+++ b/scripts/make-release
@@ -18,7 +18,7 @@  git clone "${src}" ${destination}
 pushd ${destination}
 git checkout "v${version}"
 git submodule update --init
-rm -rf .git roms/*/.git
+rm -rf .git roms/*/.git dtc/.git pixman/*.git
 popd
 tar cfj ${destination}.tar.bz2 ${destination}
 rm -rf ${destination}