From patchwork Fri Jul 17 13:26:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Fedin X-Patchwork-Id: 497141 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 8ACBD14029E for ; Fri, 17 Jul 2015 23:27:40 +1000 (AEST) Received: from localhost ([::1]:44817 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZG5fu-0004b6-Mf for incoming@patchwork.ozlabs.org; Fri, 17 Jul 2015 09:27:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZG5fJ-0003UO-Vg for qemu-devel@nongnu.org; Fri, 17 Jul 2015 09:27:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZG5fE-0002TM-Te for qemu-devel@nongnu.org; Fri, 17 Jul 2015 09:27:01 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:35616) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZG5fE-0002SG-Np for qemu-devel@nongnu.org; Fri, 17 Jul 2015 09:26:56 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NRM00ESYW0UV980@mailout4.w1.samsung.com> for qemu-devel@nongnu.org; Fri, 17 Jul 2015 14:26:54 +0100 (BST) X-AuditID: cbfec7f4-f79c56d0000012ee-ff-55a9029e219d Received: from eusync1.samsung.com ( [203.254.199.211]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 14.C5.04846.E9209A55; Fri, 17 Jul 2015 14:26:54 +0100 (BST) Received: from localhost ([106.109.131.169]) by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NRM006N9W0UJ330@eusync1.samsung.com>; Fri, 17 Jul 2015 14:26:54 +0100 (BST) From: Pavel Fedin To: qemu-devel@nongnu.org Date: Fri, 17 Jul 2015 16:26:50 +0300 Message-id: <75141d65388ad6bfbfa1da0597d7660b281830bf.1437139165.git.p.fedin@samsung.com> X-Mailer: git-send-email 1.9.5.msysgit.0 In-reply-to: References: In-reply-to: References: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNLMWRmVeSWpSXmKPExsVy+t/xy7rzmFaGGkzYom/x4vU/RotNn8+x WMzfcobVYs6ZBywWx3t3sFi0ff7ObnH39WcWB3aPf4f7mTx2zrrL7tFy5C2rx51re9g8nlzb zBTAGsVlk5Kak1mWWqRvl8CVsfLXI5aC/XEVv2bfYW9gPO3SxcjBISFgIrH4oHkXIyeQKSZx 4d56ti5GLg4hgaWMEp9WHWSBcL4xStzYvoMdpIpNQF3i9NcPLCC2iICkxO+u08wgRcwCE5kk Ns5uZQNJCAvYSjzYvx+siEVAVeLO2+esIDavQLTE7bM/2SHWaUgs+jKHDeQKTgFzid+bTEDC QgJmEsd/P8clPIGRfwEjwypG0dTS5ILipPRcQ73ixNzi0rx0veT83E2MkCD8soNx8TGrQ4wC HIxKPLwNritChVgTy4orcw8xSnAwK4nw/voHFOJNSaysSi3Kjy8qzUktPsQozcGiJM47d9f7 ECGB9MSS1OzU1ILUIpgsEwenVAOjzGbXFRwPHSWMU8NPSDzbM88jTX3V3qvH2v45bp/O9Dm8 8OD/kx4753ox/WZo+svIx3Ft7bT/LtOZH/76fneNXtynlrYdG+aU7FTwWHa2R4rn36V/K8Tk 5q6vZlhoJuF5bKnNxCXn1HQUulsXvD5t/OSw+9zKtTKP9xxOb1w1Z0NfqFBnc/KZy0osxRmJ hlrMRcWJAPR66U0+AgAA X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 210.118.77.14 Cc: Peter Maydell , Eric Auger , Shlomo Pongratz , Shlomo Pongratz , Diana Craciun , Christoffer Dall Subject: [Qemu-devel] [PATCH v5 5/5] Add gicversion option to virt machine X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Set kernel_irqchip_type according to value of the option and pass it around where necessary. Instantiate devices and fdt nodes according to the choice. mac_cpus for virt machine increased to 64. GICv2 compatibility check happens inside arm_gic_common_realize(). Signed-off-by: Pavel Fedin --- hw/arm/virt.c | 137 ++++++++++++++++++++++++++++++++++++++++++-------- include/hw/arm/fdt.h | 2 +- include/hw/arm/virt.h | 6 ++- 3 files changed, 121 insertions(+), 24 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 2e7d858..afbeedf 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -48,6 +48,8 @@ #include "hw/arm/sysbus-fdt.h" #include "hw/platform-bus.h" #include "hw/arm/fdt.h" +#include "linux/kvm.h" /* For KVM_DEV_TYPE_ARM_VGIC_V{2|3} */ +#include "qapi/visitor.h" /* Number of external interrupt lines to configure the GIC with */ #define NUM_IRQS 256 @@ -106,7 +108,12 @@ static const MemMapEntry a15memmap[] = { /* GIC distributor and CPU interfaces sit inside the CPU peripheral space */ [VIRT_GIC_DIST] = { 0x08000000, 0x00010000 }, [VIRT_GIC_CPU] = { 0x08010000, 0x00010000 }, - [VIRT_GIC_V2M] = { 0x08020000, 0x00001000 }, + [VIRT_GIC_V2M] = { 0x08020000, 0x00010000 }, + /* On v3 VIRT_GIC_DIST_MBI and VIRT_ITS_CONTROL take place of + * VIRT_GIC_CPU and VIRT_GIC_V2M respectively + */ + [VIRT_ITS_TRANSLATION] = { 0x08030000, 0x00010000 }, + [VIRT_LPI] = { 0x08040000, 0x00800000 }, [VIRT_UART] = { 0x09000000, 0x00001000 }, [VIRT_RTC] = { 0x09010000, 0x00001000 }, [VIRT_FW_CFG] = { 0x09020000, 0x0000000a }, @@ -256,10 +263,13 @@ static void fdt_add_timer_nodes(const VirtBoardInfo *vbi) * they are edge-triggered. */ ARMCPU *armcpu; + uint32_t max; uint32_t irqflags = GIC_FDT_IRQ_FLAGS_EDGE_LO_HI; + /* Argument is 32 bit but 8 bits are reserved for flags */ + max = (vbi->smp_cpus >= 24) ? 24 : vbi->smp_cpus; irqflags = deposit32(irqflags, GIC_FDT_IRQ_PPI_CPU_START, - GIC_FDT_IRQ_PPI_CPU_WIDTH, (1 << vbi->smp_cpus) - 1); + GIC_FDT_IRQ_PPI_CPU_WIDTH, (1 << max) - 1); qemu_fdt_add_subnode(vbi->fdt, "/timer"); @@ -283,6 +293,18 @@ static void fdt_add_cpu_nodes(const VirtBoardInfo *vbi) { int cpu; + /* + * From Documentation/devicetree/bindings/arm/cpus.txt + * On ARM v8 64-bit systems value should be set to 2, + * that corresponds to the MPIDR_EL1 register size. + * If MPIDR_EL1[63:32] value is equal to 0 on all CPUs + * in the system, #address-cells can be set to 1, since + * MPIDR_EL1[63:32] bits are not used for CPUs + * identification. + * + * Now GIC500 doesn't support affinities 2 & 3 so currently + * #address-cells can stay 1 until future GIC + */ qemu_fdt_add_subnode(vbi->fdt, "/cpus"); qemu_fdt_setprop_cell(vbi->fdt, "/cpus", "#address-cells", 0x1); qemu_fdt_setprop_cell(vbi->fdt, "/cpus", "#size-cells", 0x0); @@ -319,25 +341,36 @@ static void fdt_add_v2m_gic_node(VirtBoardInfo *vbi) qemu_fdt_setprop_cell(vbi->fdt, "/intc/v2m", "phandle", vbi->v2m_phandle); } -static void fdt_add_gic_node(VirtBoardInfo *vbi) +static void fdt_add_gic_node(VirtBoardInfo *vbi, int type) { vbi->gic_phandle = qemu_fdt_alloc_phandle(vbi->fdt); qemu_fdt_setprop_cell(vbi->fdt, "/", "interrupt-parent", vbi->gic_phandle); qemu_fdt_add_subnode(vbi->fdt, "/intc"); - /* 'cortex-a15-gic' means 'GIC v2' */ - qemu_fdt_setprop_string(vbi->fdt, "/intc", "compatible", - "arm,cortex-a15-gic"); qemu_fdt_setprop_cell(vbi->fdt, "/intc", "#interrupt-cells", 3); qemu_fdt_setprop(vbi->fdt, "/intc", "interrupt-controller", NULL, 0); - qemu_fdt_setprop_sized_cells(vbi->fdt, "/intc", "reg", - 2, vbi->memmap[VIRT_GIC_DIST].base, - 2, vbi->memmap[VIRT_GIC_DIST].size, - 2, vbi->memmap[VIRT_GIC_CPU].base, - 2, vbi->memmap[VIRT_GIC_CPU].size); qemu_fdt_setprop_cell(vbi->fdt, "/intc", "#address-cells", 0x2); qemu_fdt_setprop_cell(vbi->fdt, "/intc", "#size-cells", 0x2); qemu_fdt_setprop(vbi->fdt, "/intc", "ranges", NULL, 0); + if (type == KVM_DEV_TYPE_ARM_VGIC_V3) { + qemu_fdt_setprop_string(vbi->fdt, "/intc", "compatible", + "arm,gic-v3"); + qemu_fdt_setprop_sized_cells(vbi->fdt, "/intc", "reg", + 2, vbi->memmap[VIRT_GIC_DIST].base, + 2, vbi->memmap[VIRT_GIC_DIST].size, + 2, vbi->memmap[VIRT_LPI].base, + 2, vbi->memmap[VIRT_LPI].size); + } else { + /* 'cortex-a15-gic' means 'GIC v2' */ + qemu_fdt_setprop_string(vbi->fdt, "/intc", "compatible", + "arm,cortex-a15-gic"); + qemu_fdt_setprop_sized_cells(vbi->fdt, "/intc", "reg", + 2, vbi->memmap[VIRT_GIC_DIST].base, + 2, vbi->memmap[VIRT_GIC_DIST].size, + 2, vbi->memmap[VIRT_GIC_CPU].base, + 2, vbi->memmap[VIRT_GIC_CPU].size); + } + qemu_fdt_setprop_cell(vbi->fdt, "/intc", "phandle", vbi->gic_phandle); } @@ -360,20 +393,35 @@ static void create_v2m(VirtBoardInfo *vbi, qemu_irq *pic) fdt_add_v2m_gic_node(vbi); } -static void create_gic(VirtBoardInfo *vbi, qemu_irq *pic) +static void create_gic(VirtBoardInfo *vbi, qemu_irq *pic, int type) { /* We create a standalone GIC v2 */ DeviceState *gicdev; SysBusDevice *gicbusdev; - const char *gictype = "arm_gic"; + const char *gictype; int i; - if (kvm_irqchip_in_kernel()) { - gictype = "kvm-arm-gic"; + if (type == KVM_DEV_TYPE_ARM_VGIC_V3) { + /* TODO: Software emulation is not implemented yet */ + if (!kvm_irqchip_in_kernel()) { + fprintf(stderr, "KVM is currently required for GICv3 emulation\n"); + exit(1); + } + gictype = "kvm-arm-gicv3"; + } else { + gictype = kvm_irqchip_in_kernel() ? "kvm-arm-gic" : "arm_gic"; } gicdev = qdev_create(NULL, gictype); - qdev_prop_set_uint32(gicdev, "revision", 2); + + for (i = 0; i < vbi->smp_cpus; i++) { + CPUState *cpu = qemu_get_cpu(i); + CPUARMState *env = cpu->env_ptr; + env->nvic = gicdev; + } + + qdev_prop_set_uint32(gicdev, "revision", + type == KVM_DEV_TYPE_ARM_VGIC_V3 ? 3 : 2); qdev_prop_set_uint32(gicdev, "num-cpu", smp_cpus); /* Note that the num-irq property counts both internal and external * interrupts; there are always 32 of the former (mandated by GIC spec). @@ -382,7 +430,11 @@ static void create_gic(VirtBoardInfo *vbi, qemu_irq *pic) qdev_init_nofail(gicdev); gicbusdev = SYS_BUS_DEVICE(gicdev); sysbus_mmio_map(gicbusdev, 0, vbi->memmap[VIRT_GIC_DIST].base); - sysbus_mmio_map(gicbusdev, 1, vbi->memmap[VIRT_GIC_CPU].base); + if (type == KVM_DEV_TYPE_ARM_VGIC_V3) { + sysbus_mmio_map(gicbusdev, 1, vbi->memmap[VIRT_LPI].base); + } else { + sysbus_mmio_map(gicbusdev, 1, vbi->memmap[VIRT_GIC_CPU].base); + } /* Wire the outputs from each CPU's generic timer to the * appropriate GIC PPI inputs, and the GIC's IRQ output to @@ -409,9 +461,11 @@ static void create_gic(VirtBoardInfo *vbi, qemu_irq *pic) pic[i] = qdev_get_gpio_in(gicdev, i); } - fdt_add_gic_node(vbi); + fdt_add_gic_node(vbi, type); - create_v2m(vbi, pic); + if (type == KVM_DEV_TYPE_ARM_VGIC_V2) { + create_v2m(vbi, pic); + } } static void create_uart(const VirtBoardInfo *vbi, qemu_irq *pic) @@ -715,7 +769,9 @@ static void create_pcie(const VirtBoardInfo *vbi, qemu_irq *pic) qemu_fdt_setprop_cells(vbi->fdt, nodename, "bus-range", 0, nr_pcie_buses - 1); - qemu_fdt_setprop_cells(vbi->fdt, nodename, "msi-parent", vbi->v2m_phandle); + if (vbi->v2m_phandle) { + qemu_fdt_setprop_cells(vbi->fdt, nodename, "msi-parent", vbi->v2m_phandle); + } qemu_fdt_setprop_sized_cells(vbi->fdt, nodename, "reg", 2, base_ecam, 2, size_ecam); @@ -875,7 +931,7 @@ static void machvirt_init(MachineState *machine) create_flash(vbi); - create_gic(vbi, pic); + create_gic(vbi, pic, machine->kernel_irqchip_type); create_uart(vbi, pic); @@ -933,6 +989,37 @@ static void virt_set_secure(Object *obj, bool value, Error **errp) vms->secure = value; } +static void virt_get_gic_version(Object *obj, Visitor *v, void *opaque, + const char *name, Error **errp) +{ + MachineState *ms = MACHINE(obj); + int32_t value = (ms->kernel_irqchip_type == KVM_DEV_TYPE_ARM_VGIC_V3) ? + 3 : 2; + + visit_type_int32(v, &value, name, errp); +} + +static void virt_set_gic_version(Object *obj, Visitor *v, void *opaque, + const char *name, Error **errp) +{ + MachineState *ms = MACHINE(obj); + int32_t value; + + visit_type_int32(v, &value, name, errp); + + switch (value) { + case 3: + ms->kernel_irqchip_type = KVM_DEV_TYPE_ARM_VGIC_V3; + break; + case 2: + ms->kernel_irqchip_type = KVM_DEV_TYPE_ARM_VGIC_V2; + break; + default: + error_report ("Only GICv2 and GICv3 supported currently\n"); + exit(1); + } +} + static void virt_instance_init(Object *obj) { VirtMachineState *vms = VIRT_MACHINE(obj); @@ -948,6 +1035,11 @@ static void virt_instance_init(Object *obj) /* Default GIC type is v2 */ vms->parent.kernel_irqchip_type = KVM_DEV_TYPE_ARM_VGIC_V2; + object_property_add(obj, "gicversion", "int", virt_get_gic_version, + virt_set_gic_version, NULL, NULL, NULL); + object_property_set_description(obj, "gicversion", + "Set GIC version. " + "Valid values are 2 and 3", NULL); } static void virt_class_init(ObjectClass *oc, void *data) @@ -957,7 +1049,8 @@ static void virt_class_init(ObjectClass *oc, void *data) mc->name = TYPE_VIRT_MACHINE; mc->desc = "ARM Virtual Machine", mc->init = machvirt_init; - mc->max_cpus = 8; + /* With gic3 full implementation (with bitops) rase the lmit to 128 */ + mc->max_cpus = 64; mc->has_dynamic_sysbus = true; mc->block_default_type = IF_VIRTIO; mc->no_cdrom = 1; diff --git a/include/hw/arm/fdt.h b/include/hw/arm/fdt.h index c3d5015..dd794dd 100644 --- a/include/hw/arm/fdt.h +++ b/include/hw/arm/fdt.h @@ -29,6 +29,6 @@ #define GIC_FDT_IRQ_FLAGS_LEVEL_LO 8 #define GIC_FDT_IRQ_PPI_CPU_START 8 -#define GIC_FDT_IRQ_PPI_CPU_WIDTH 8 +#define GIC_FDT_IRQ_PPI_CPU_WIDTH 24 #endif diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h index d22fd8e..852efb9 100644 --- a/include/hw/arm/virt.h +++ b/include/hw/arm/virt.h @@ -46,6 +46,11 @@ enum { VIRT_CPUPERIPHS, VIRT_GIC_DIST, VIRT_GIC_CPU, + VIRT_GIC_V2M, + VIRT_GIC_DIST_MBI = VIRT_GIC_CPU, + VIRT_ITS_CONTROL = VIRT_GIC_V2M, + VIRT_ITS_TRANSLATION, + VIRT_LPI, VIRT_UART, VIRT_MMIO, VIRT_RTC, @@ -54,7 +59,6 @@ enum { VIRT_PCIE_MMIO, VIRT_PCIE_PIO, VIRT_PCIE_ECAM, - VIRT_GIC_V2M, VIRT_PLATFORM_BUS, };