From patchwork Wed Nov 8 22:57:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 836054 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="dRhXk9wg"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yXMYt3WWLz9rvt for ; Thu, 9 Nov 2017 10:14:10 +1100 (AEDT) Received: from localhost ([::1]:34367 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCZXs-0001F0-DE for incoming@patchwork.ozlabs.org; Wed, 08 Nov 2017 18:14:08 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCZLW-0007vf-L2 for qemu-devel@nongnu.org; Wed, 08 Nov 2017 18:01:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCZLS-0003DI-P5 for qemu-devel@nongnu.org; Wed, 08 Nov 2017 18:01:22 -0500 Received: from mail-sn1nam02on0068.outbound.protection.outlook.com ([104.47.36.68]:59191 helo=NAM02-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eCZLS-0003Cp-Gq for qemu-devel@nongnu.org; Wed, 08 Nov 2017 18:01:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=t4fS0+LHJ8Pb/j055VBrmvG3jhqDUnLP1BI0pIIgpC8=; b=dRhXk9wgtFxJUE8l97yU/BCYPY7202VOPc3NHYLqnSh8WjTqErHwofV1BSG9reVLBtjEP5xqKRmpVVXThsE1UofALr/g2HF3kKDDsfIzqHt28Kxnwr4h/TURpsJF2yBlAvIN2lSsaBXJFYAt44wNuVsez29xt/Z8HPEYssSp8+s= Received: from BN6PR02CA0048.namprd02.prod.outlook.com (10.173.146.162) by BN6PR02MB3380.namprd02.prod.outlook.com (10.161.153.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.13; Wed, 8 Nov 2017 23:01:15 +0000 Received: from CY1NAM02FT060.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::203) by BN6PR02CA0048.outlook.office365.com (2603:10b6:404:5f::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.218.12 via Frontend Transport; Wed, 8 Nov 2017 23:01:15 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by CY1NAM02FT060.mail.protection.outlook.com (10.152.74.252) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.197.9 via Frontend Transport; Wed, 8 Nov 2017 23:01:15 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1eCZLO-0001Le-B5; Wed, 08 Nov 2017 15:01:14 -0800 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1eCZLO-0002ho-8C; Wed, 08 Nov 2017 15:01:14 -0800 Received: from xsj-pvapsmtp01 (xsj-smtp1.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id vA8N180P009275; Wed, 8 Nov 2017 15:01:08 -0800 Received: from [172.19.2.220] (helo=xsjalistai50.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1eCZLI-0002dX-HH; Wed, 08 Nov 2017 15:01:08 -0800 From: Alistair Francis To: Date: Wed, 8 Nov 2017 14:57:10 -0800 Message-ID: <720acbeb99526cf48d07f29594c1964e97c6387a.1510181732.git.alistair.francis@xilinx.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: References: MIME-Version: 1.0 X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23450.000 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(2980300002)(438002)(199003)(189002)(76176999)(9786002)(118296001)(4326008)(23676003)(106002)(6666003)(5660300001)(63266004)(6916009)(2950100002)(54906003)(5820100001)(47776003)(39060400002)(189998001)(8936002)(2870700001)(2351001)(81156014)(81166006)(8676002)(50466002)(106466001)(77096006)(50226002)(2906002)(36756003)(316002)(478600001)(50986999)(36386004)(356003)(33646002)(305945005)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR02MB3380; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; PTR:unknown-60-83.xilinx.com; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; CY1NAM02FT060; 1:V+/uL5a0oYxtKVzeWz38F8VECmPsOJDMYriej/gt2DB3sXEx272VcqgsOKWSkuAxQ0NQbzwAVnHL+wiDZbGgLrO6d3l3+zrKlmQTHSPw3MV5tRNU6bh9XN6ZOXpnGrZx X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 424f2021-5671-4ccd-869a-08d526fc9d30 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(8251501002)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199); SRVR:BN6PR02MB3380; X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB3380; 3:GTmDqDmVslNRZ3R1Rl9aWF/hlZ8pXAqCCetv31gnn0P4UFUVkQNTPuG2Vduwp4ProIdmyzQTRtobzCuM4nFhlzn1BW1qYosKGZWIrLOMz2a/lEDcP2Dhq3E69tbfMEwjnC3IhV93uSWw50ohrHBQWoAnOyzdbJqwtokooZeQ6aUq88MRCHhLX68TU1gVbT2V0ih2O1TyNlZDDbQEv8NxW4K0RGTH8rUhmRNSejYTQxFcD0c5p8M5i9BD+rCHouB4bwD7vlvTV2GVyqkgiq1lQ9VsTInvDeGvnvI9kNnxCJ9FTuzQ9P/Tz4fmw+vIZWgCi7MB5vjPE4oFLVsHBhmEVQ45r+QZVex0yTdYgkqfUDg=; 25:sVwTuZFk3Hq+hBCojVnO3f6wrKlRb3I++g9I1n79JN7JTmLq0Lj0X+IEfiXqD+IvobrCY3MMf7X+AnqeMIJUEjPDqM5dYCBId6mDyacPhHnQvKrqMhIbu5XTzn0al08r+O476yxhEX1UTnerphFK/i2FFBRZLBWFJsK5oLMKlpAjyS4UgGyB3R1To0w0IrE44P/KI25Z4kYqg8tYHyPaG10I8or8TIRt4HKXYBmnRd2KUY9Z5MLkvmypkgTq1desC/28iZ5R+sjqf09MlhX9/Bxjry7Ud/rAMmIE8mT/UPVNnnwzCXDEbHNk3HMAoKnK50+d54Ntq38AiuAfEUNnbw== X-MS-TrafficTypeDiagnostic: BN6PR02MB3380: X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB3380; 31:1rLp3X6/PgPOm93UsGkkgr+ECQlEuyBErfwtZVerNRnrsvpxuRw05f0GEDRcbYtqRduOL90eZAqAiBlI/gE3f2VL6rAiV9uPxd/vKjTRpsfgOnA24H+8Zav64QN14roY9GrdHCKThPzhr+Pt0e7Nocej5/61PmdYIZqlcCEb93Q2CmH5O+Z+bmG0pYVZXRJr3r7WgfplLa2XMJqXbeQpjkk9cAYGjsVTaCG6jr7r9YA=; 20:g/Ort+U58oat3wZDhWVRDSHfKj8+3UwmqNkdSz94/2UxdbHuayMQmzrmF2gxjxtTc6FjrSW9ZcHsor53NF+UnkFFHLr4OqZTmVAhfz/BmiTO+N5TnWz1MUANbwMKqFqn7fxMUH+81slwFOYqgFqqGnr0wzZyYepOq/hsxONJ6/MAy/niMs7lUgUsKiYXKoLC3WX9NrHx1KKDmWypWfiVvoXKjLr7j5q7KlgZWmH5Mowrl5RCU02rV7rO8YzuwQnAzoTmPhqc241G66HNjJVagUkWe4bPLQBHhPbfiD+SPs+ELTfio9FBKtz61gYCVjzEnlq8dnLpReS1IKW8SaUQeNPyf4P5NkiU0ZnVS9tKoI7qdve4PQ0AR7ID1ZHAUVtEWG9Zgof9zqdBxEapkNmTfqprynVfjgccoKWaXbaC+ZzzDiA6WGyD0y644PqshWBIYRnkD7aCmUFJnrq9GQsPBuK+ZDc0buM4wCX3pB1Cg/rxu7rWReBGf6ixqwHWdbIw X-Exchange-Antispam-Report-Test: UriScan:(788757137089)(192813158149592); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93004095)(100000703101)(100105400095)(3231021)(6055026)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR02MB3380; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR02MB3380; X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB3380; 4:3B2EoYLfMmXpOFhqlUetDVWb0RhVve7Ve6OZMS9tAD3ifJdt90EfsCOOZ4fqEkq/9VBcHS9KjF21Ji8ypEeW5lBScFaSJrGQt/is9TKQNbNhQjXHrmR83LxEZtZ0X13R/OjhbbLz3oUK+LBdHIfR13AyiEGXGgIgp4BR8hsiknwX1SzK3ZkQYv7ohvBGo05y93KLDUfRfPVMLgCnxpvA96hr65/Qaex1APbkOPxj9/bn0FuKyFwnU1dYcV7BvcAfJf/TEq92Sr4EYbRGVtASYwJwqDfaO3gFQ/txH99PA4Pn6K87bPF+gPF9ghP4gZf+iod9nGC6shu2JNNytI7rpQ== X-Forefront-PRVS: 0485417665 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR02MB3380; 23:Rus0aYGPJ24nXcrKE1/VhuO7YAyJCpaHy/W6GIGF2?= 8dE/gQaE3gS/UImTrXs/oNATZBVXz//BYX7c70gB80fniyKoTFN0sEFiTepCIc+3AOLfZG+TrQc+ODGJAeR26tXirimlON8sKebSZCTzVfkhX6nK9Ya/4xvipl/TsZQL1ma7PtkHkwXKK/fLxTIxW51NM0ZQJJ8MZ2jdOpSZ8EqsL0CEPgVx1lDX1WLAnQOXInYbOoGzwOd89wcDy+JQKTnMv22ZgqRi2HasODHz2oT6CrMMAy6NlaQ/HEAoNZJmZtkNxzxA6f4ldjHdSXN3jYwh6z03N95wX3rdJ4g/AuoGaWDCW/HPrOqxEQ/gRb/17RuNuqamgZBn0/vJpVd4MJQE+OWwGs6QdCSeGcepgn1323NG2q2UiMtpd1HaaYPxdpI7/lXc/Tk/pjlnet8Y1lxL1ZKqDLc9ogzJeznkNN2jUeWhmwerQIKeKtkaRl48yY1nXUvsr2oEYBapu3h3DWLsBmelACXEm53RPDil0g5rQROArIlJUguM2S7laBaZG+erctDUugY9Vgq/wIjvIhmhKi26A7ozV5dzK1YuwYwf+NvV1TsVLMqUg0pt7b0rR3Y48YF3XAJYDVGaN6Bh1avYJy5zjTGVI0kEYQTYnYmki5IKiUFZ99axBXAAx5Mr+2i4dWkZC8onmTCE0+3d19PnyLUY5G0tP8XSrM97XA3/IyQ4NWqWjVfZM3MCcvYNsT+yvaBx3raOMsDxE52o1xQC3b5XTE4LdNAIK55SihJ4qDPSoEGDb/iJBsh9JVnAz/ZOmJhWiQrvXquvnk3Xj3cxwbi7eXNiLpVp0YIVF0e5kxZ1vZ1vOjO24dUBVevbiloWG5d8g6vhKULLmZuEFYGNhibt977zs30mAyLLwBC57I9Ls9SJGUzE6IQxuFRM3Sj/UyMomJ3Lu5JseBud8oTvuLXlGTO9CFILAtTS6VLAZvIm+ZqoaZWqq72dP38OM16g/E4rJ9/yqjMYrYBkpLta1dceqpQpaYZ5C+aqg/lzg== X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB3380; 6:oWpXMCCDo9xshnvT+DFwAsSy1JSouN6PyrW1SkPXzOt03ygZzNA4Ieh7/Gh4mqU5LYmmqi8gPmH18jMSQXARdARtmjhPmgD7FInLdkCtZ8ykLZRzN5YBi9XFiEyAU9W2mYRrJ8EeXc+w8+2Cybnt+/5G2ugtXjOn5vpSKzJbIo6tawkW5LGcik9/B17qszaHDFBd3k+wmzOh/W4sN61i2RDk06duNTjHvji66YrFQIHOFQfz2X2JwcdLtwdCGwetN2kf2AeMdpgad2tplfjPCjJV0/GiodoOQ6HN/0z5k8/ByWR7o8rrxSbTyVBjgtbXXBaFfspZPnCRcL4vUfKNWhmfOf0cBnB+HFhiVlAReKw=; 5:R1Umw0ozg1Cb3V4FG6uOZaOKHnQB6b7weBfpvHYaI00X0XdyjBOQKZ4oBFRXy/xcVeJ0kf9q/7A4lIJ7GlODy1avTEC/YoyK64XzRsRz5/DgslS+ZXpm+sBBEVXJT+EjozFU6T9p31JrhoCoQVjPyIshClBTjg3lmxWrIjfBBVQ=; 24:VsBrvXrsO5G+1lqwngHxFodrZyXwe0NDEuLJUD/R/k9lUjF0Pn97slilSEkhm23kzBCfd+Pf+AaN/XV3/NUP2h7sZJufTFRKX0L7MNsotXc=; 7:7kgUKl/eAmrmuMHDJhAYUd289YapRp3iGZKzaCjVtjoiQ8ovOYgJnsKEfiTWj/5lxpwbMaSTHQJT6/CFoDNKi6HCJ/8/i/lFu/D9KLN6TPxrz+2Rq8/eLMVcyew/4gLI79IJZz8rhBrU5+3mgLz1H95HQtUGLFGnBHxk4sP8qbLBNAlCDqLNKEl4AhZQap2NLVs0vkKEYohl5FaQ2O0H8k4c+q9BcpOWZqhWPzSiw6aYBDaJq6xJQSnFqI55X83B SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2017 23:01:15.0641 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 424f2021-5671-4ccd-869a-08d526fc9d30 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB3380 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.36.68 Subject: [Qemu-devel] [PATCH v4 14/45] hw/i2c: Replace fprintf(stderr, "*\n" with error_report() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, armbru@redhat.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Replace a large number of the fprintf(stderr, "*\n" calls with error_report(). The functions were renamed with these commands and then compiler issues where manually fixed. find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N;N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + find ./* -type f -exec sed -i \ 'N; {s|fprintf(stderr, "\(.*\)\\n"\(.*\));|error_report("\1"\2);|Ig}' \ {} + Some lines where then manually tweaked to pass checkpatch. A "I^2C" was manually replaced with "i2c" in hw/i2c/omap_i2c.c. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé --- V3: - Replace "I&2C" V2: - Split hw patch into individual directories hw/i2c/omap_i2c.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/i2c/omap_i2c.c b/hw/i2c/omap_i2c.c index 26e3e5ebf6..e9da7f9f51 100644 --- a/hw/i2c/omap_i2c.c +++ b/hw/i2c/omap_i2c.c @@ -340,13 +340,13 @@ static void omap_i2c_write(void *opaque, hwaddr addr, break; } if ((value & (1 << 15)) && !(value & (1 << 10))) { /* MST */ - fprintf(stderr, "%s: I^2C slave mode not supported\n", - __func__); + error_report("%s: i2c slave mode not supported", + __func__); break; } if ((value & (1 << 15)) && value & (1 << 8)) { /* XA */ - fprintf(stderr, "%s: 10-bit addressing mode not supported\n", - __func__); + error_report("%s: 10-bit addressing mode not supported", + __func__); break; } if ((value & (1 << 15)) && value & (1 << 0)) { /* STT */ @@ -393,7 +393,7 @@ static void omap_i2c_write(void *opaque, hwaddr addr, omap_i2c_interrupts_update(s); } if (value & (1 << 15)) /* ST_EN */ - fprintf(stderr, "%s: System Test not supported\n", __func__); + error_report("%s: System Test not supported", __func__); break; default: