From patchwork Wed Oct 27 10:21:21 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Isaku Yamahata X-Patchwork-Id: 69340 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id DCA1EB70E1 for ; Wed, 27 Oct 2010 22:21:08 +1100 (EST) Received: from localhost ([127.0.0.1]:49216 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PB441-0007Ao-4O for incoming@patchwork.ozlabs.org; Wed, 27 Oct 2010 07:21:05 -0400 Received: from [140.186.70.92] (port=35529 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PB3Q1-0002Hq-3P for qemu-devel@nongnu.org; Wed, 27 Oct 2010 06:39:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PB38H-0006DP-Ic for qemu-devel@nongnu.org; Wed, 27 Oct 2010 06:22:55 -0400 Received: from mail.valinux.co.jp ([210.128.90.3]:33485) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PB38H-0006CZ-7E for qemu-devel@nongnu.org; Wed, 27 Oct 2010 06:21:25 -0400 Received: from ps.local.valinux.co.jp (vagw.valinux.co.jp [210.128.90.14]) by mail.valinux.co.jp (Postfix) with SMTP id 7693287406; Wed, 27 Oct 2010 19:21:22 +0900 (JST) Received: (nullmailer pid 27276 invoked by uid 1000); Wed, 27 Oct 2010 10:21:21 -0000 From: Isaku Yamahata To: qemu-devel@nongnu.org Date: Wed, 27 Oct 2010 19:21:21 +0900 Message-Id: <676a90a3f99920d2d3b9ecec3ac6c83c87cacc12.1288174753.git.yamahata@valinux.co.jp> X-Mailer: git-send-email 1.7.1.1 In-Reply-To: References: In-Reply-To: References: X-Virus-Scanned: clamav-milter 0.95.2 at va-mail.local.valinux.co.jp X-Virus-Status: Clean X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: skandasa@cisco.com, adnan@khaleel.us, wexu2@cisco.com, mst@redhat.com, yamahata@valinux.co.jp, etmartin@cisco.com Subject: [Qemu-devel] [PATCH 6/6] msix: remove range checks. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Same as 4b78560503a802eae3663ace9f9cf080319e7265 > config write handlers should be idempotent. > So no need for range checks. Signed-off-by: Isaku Yamahata --- hw/msix.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index f66d255..20caa5e 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -157,14 +157,9 @@ static void msix_handle_mask_update(PCIDevice *dev, int vector) void msix_write_config(PCIDevice *dev, uint32_t addr, uint32_t val, int len) { - unsigned enable_pos = dev->msix_cap + MSIX_CONTROL_OFFSET; int vector; int i; - if (!range_covers_byte(addr, len, enable_pos)) { - return; - } - if (!msix_enabled(dev)) { return; }