From patchwork Sun Nov 2 11:57:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 405868 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id BAD7B14003E for ; Sun, 2 Nov 2014 23:02:05 +1100 (AEDT) Received: from localhost ([::1]:56492 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xktr9-0002K4-VE for incoming@patchwork.ozlabs.org; Sun, 02 Nov 2014 07:02:03 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xkto6-0005V3-HF for qemu-devel@nongnu.org; Sun, 02 Nov 2014 06:58:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xkto1-0002Rg-5e for qemu-devel@nongnu.org; Sun, 02 Nov 2014 06:58:54 -0500 Received: from isrv.corpit.ru ([86.62.121.231]:53456) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xkto0-0002RK-VS; Sun, 02 Nov 2014 06:58:49 -0500 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 334FF402BD; Sun, 2 Nov 2014 14:58:48 +0300 (MSK) Received: from tls.msk.ru (mjt.vpn.tls.msk.ru [192.168.177.99]) by tsrv.corpit.ru (Postfix) with SMTP id 1222E6FC; Sun, 2 Nov 2014 14:58:48 +0300 (MSK) Received: (nullmailer pid 14972 invoked by uid 1000); Sun, 02 Nov 2014 11:58:47 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Date: Sun, 2 Nov 2014 14:57:23 +0300 Message-Id: <660edd4eda903e32811a4929d1434cceda3284aa.1414929285.git.mjt@msgid.tls.msk.ru> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, Gonglei , Michael Tokarev Subject: [Qemu-devel] [PULL 11/23] virtio-9p-proxy: Fix sockfd leak X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org If connect() in connect_namedsocket() return false, the sockfd will leak. Plug it. Signed-off-by: Michael Tokarev Signed-off-by: Gonglei --- hw/9pfs/virtio-9p-proxy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9pfs/virtio-9p-proxy.c index b57966d..e6bbb06 100644 --- a/hw/9pfs/virtio-9p-proxy.c +++ b/hw/9pfs/virtio-9p-proxy.c @@ -1112,6 +1112,7 @@ static int connect_namedsocket(const char *path) size = strlen(helper.sun_path) + sizeof(helper.sun_family); if (connect(sockfd, (struct sockaddr *)&helper, size) < 0) { fprintf(stderr, "socket error\n"); + close(sockfd); return -1; }