From patchwork Thu Nov 28 03:27:03 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Crosthwaite X-Patchwork-Id: 294748 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 67C772C009A for ; Thu, 28 Nov 2013 14:28:21 +1100 (EST) Received: from localhost ([::1]:38883 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlsH4-00036S-Rb for incoming@patchwork.ozlabs.org; Wed, 27 Nov 2013 22:28:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49999) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlsGa-0002wd-Bm for qemu-devel@nongnu.org; Wed, 27 Nov 2013 22:27:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VlsGP-000755-4O for qemu-devel@nongnu.org; Wed, 27 Nov 2013 22:27:48 -0500 Received: from mail-pb0-f42.google.com ([209.85.160.42]:57515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlsGO-00073h-SH for qemu-devel@nongnu.org; Wed, 27 Nov 2013 22:27:37 -0500 Received: by mail-pb0-f42.google.com with SMTP id uo5so11831383pbc.1 for ; Wed, 27 Nov 2013 19:27:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=imx+LwXSTsNNZwOfNh5YCmEtoj7y6f/oWciXQgVfnsw=; b=JQ1aECb8OEwNY0D1QSMJ3/USw3LJFIhHRZ9mTx5TgQljw0fb062aQgPP8JSAPJMMbv bKf71EY5i3gJcn0iQTt94eL5PdZiZT650Og5quqj+FI82sjB+FvuVQbwQ8youPYCippb GahBty9sheg4ArPvImJ3yQHCrdPFvBw7F8l/emcdf5Qm9PtJqVOYPJJ+RoOiX0qISK8u dhaNm6518r/gNhYpfGm0TQBlCH32qVzYimd1cgNnMhSCQdAoAOSd53n6oh+oi8bLBaQR O3Ntpk8q1V5Dtz18B2BuHcGz8t8kTLQ6xoQCN6HdPqXVmO6cvXlkiYXXsmfOPKsWDOhX tKSA== X-Gm-Message-State: ALoCoQmMcj0ReurYL3CuqlsD7lg/SoIMWNURBZKXQLKNkPNg9VJ2pyywwG2BuZL/AoxVQxJDS1e6 X-Received: by 10.68.229.10 with SMTP id sm10mr8440621pbc.154.1385609256102; Wed, 27 Nov 2013 19:27:36 -0800 (PST) Received: from localhost ([149.199.62.254]) by mx.google.com with ESMTPSA id sd3sm91489835pbb.42.2013.11.27.19.27.34 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 27 Nov 2013 19:27:35 -0800 (PST) From: Peter Crosthwaite To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Wed, 27 Nov 2013 19:27:03 -0800 Message-Id: <5a2896d799f2cd4da327f06209c245bc67e205c2.1385608859.git.peter.crosthwaite@xilinx.com> X-Mailer: git-send-email 1.8.4.4 In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.160.42 Cc: peter.crosthwaite@xilinx.com, afaerber@suse.de, mark.langsdorf@calxeda.com Subject: [Qemu-devel] [PATCH arm-devs v2 1/8] qom/object: Make uintXX added properties writable X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Currently the uintXX property adders make a read only property. This is not useful for devices that want to create board (or container) configurable dynamic device properties. Fix by trivally adding property setters to object_property_add_uintXX. Signed-off-by: Peter Crosthwaite --- qom/object.c | 44 ++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 40 insertions(+), 4 deletions(-) diff --git a/qom/object.c b/qom/object.c index fc19cf6..07b454b 100644 --- a/qom/object.c +++ b/qom/object.c @@ -1353,6 +1353,15 @@ static void property_get_uint8_ptr(Object *obj, Visitor *v, visit_type_uint8(v, &value, name, errp); } +static void property_set_uint8_ptr(Object *obj, Visitor *v, + void *opaque, const char *name, + Error **errp) +{ + uint8_t value; + visit_type_uint8(v, &value, name, errp); + *(uint8_t *)opaque = value; +} + static void property_get_uint16_ptr(Object *obj, Visitor *v, void *opaque, const char *name, Error **errp) @@ -1361,6 +1370,15 @@ static void property_get_uint16_ptr(Object *obj, Visitor *v, visit_type_uint16(v, &value, name, errp); } +static void property_set_uint16_ptr(Object *obj, Visitor *v, + void *opaque, const char *name, + Error **errp) +{ + uint16_t value; + visit_type_uint16(v, &value, name, errp); + *(uint16_t *)opaque = value; +} + static void property_get_uint32_ptr(Object *obj, Visitor *v, void *opaque, const char *name, Error **errp) @@ -1369,6 +1387,15 @@ static void property_get_uint32_ptr(Object *obj, Visitor *v, visit_type_uint32(v, &value, name, errp); } +static void property_set_uint32_ptr(Object *obj, Visitor *v, + void *opaque, const char *name, + Error **errp) +{ + uint32_t value; + visit_type_uint32(v, &value, name, errp); + *(uint32_t *)opaque = value; +} + static void property_get_uint64_ptr(Object *obj, Visitor *v, void *opaque, const char *name, Error **errp) @@ -1377,32 +1404,41 @@ static void property_get_uint64_ptr(Object *obj, Visitor *v, visit_type_uint64(v, &value, name, errp); } +static void property_set_uint64_ptr(Object *obj, Visitor *v, + void *opaque, const char *name, + Error **errp) +{ + uint64_t value; + visit_type_uint64(v, &value, name, errp); + *(uint64_t *)opaque = value; +} + void object_property_add_uint8_ptr(Object *obj, const char *name, const uint8_t *v, Error **errp) { object_property_add(obj, name, "uint8", property_get_uint8_ptr, - NULL, NULL, (void *)v, errp); + property_set_uint8_ptr, NULL, (void *)v, errp); } void object_property_add_uint16_ptr(Object *obj, const char *name, const uint16_t *v, Error **errp) { object_property_add(obj, name, "uint16", property_get_uint16_ptr, - NULL, NULL, (void *)v, errp); + property_set_uint16_ptr, NULL, (void *)v, errp); } void object_property_add_uint32_ptr(Object *obj, const char *name, const uint32_t *v, Error **errp) { object_property_add(obj, name, "uint32", property_get_uint32_ptr, - NULL, NULL, (void *)v, errp); + property_set_uint32_ptr, NULL, (void *)v, errp); } void object_property_add_uint64_ptr(Object *obj, const char *name, const uint64_t *v, Error **errp) { object_property_add(obj, name, "uint64", property_get_uint64_ptr, - NULL, NULL, (void *)v, errp); + property_set_uint64_ptr, NULL, (void *)v, errp); } static void object_instance_init(Object *obj)