| Message ID | 5A0E9C91.4050108@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | Don't ignore O_DIRECT flag in the 9pfs server | expand |
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index 52d4663..5ea01c4 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -155,10 +155,6 @@ static int get_dotl_openflags(V9fsState *s, int oflags) */ flags = dotl_to_open_flags(oflags); flags &= ~(O_NOCTTY | O_ASYNC | O_CREAT); - /* - * Ignore direct disk access hint until the server supports it. - */ - flags &= ~O_DIRECT; return flags; }
Now v9fs in linux has already supported O_DIRECT(v9fs_direct_IO), when guest user open file with O_DIRECT flag and return success, so user hopes data doesn't pass through page cache, but 9pfs in qemu ignore direct disk access and use host page cache, it is not match to DIRECT_IO semantic, so we should not ignore O_DIRECT in 9pfs unless v9fs in linux don't support DIRECT_IO. And if server fs don't support O_DIRECT, user will receive -EINVAL and know the filesystem don't support O_DIRECT. So in order to ensure semantic consistency, don't ignore direct disk access in 9pfs. Signed-off-by: Yiwen Jiang <jiangyiwen@huawei.com> --- hw/9pfs/9p.c | 4 ---- 1 file changed, 4 deletions(-)