From patchwork Mon Apr 24 13:12:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Herongguang (Stephen)" X-Patchwork-Id: 754239 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wBRc94tq7z9s8Q for ; Mon, 24 Apr 2017 23:13:29 +1000 (AEST) Received: from localhost ([::1]:44157 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2dnz-0005Mt-5H for incoming@patchwork.ozlabs.org; Mon, 24 Apr 2017 09:13:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2dnW-0005Lw-SN for qemu-devel@nongnu.org; Mon, 24 Apr 2017 09:12:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2dnS-000819-Px for qemu-devel@nongnu.org; Mon, 24 Apr 2017 09:12:58 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:3521 helo=dggrg01-dlp.huawei.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1d2dnS-0007xu-Dq for qemu-devel@nongnu.org; Mon, 24 Apr 2017 09:12:54 -0400 Received: from 172.30.72.57 (EHLO DGGEML403-HUB.china.huawei.com) ([172.30.72.57]) by dggrg01-dlp.huawei.com (MOS 4.4.6-GA FastPath queued) with ESMTP id ANH57379; Mon, 24 Apr 2017 21:12:37 +0800 (CST) Received: from [10.177.19.20] (10.177.19.20) by DGGEML403-HUB.china.huawei.com (10.3.17.33) with Microsoft SMTP Server id 14.3.301.0; Mon, 24 Apr 2017 21:12:29 +0800 From: "Herongguang (Stephen)" To: , , "qemu-devel@nongnu.org" Message-ID: <58FDF9BD.2030100@huawei.com> Date: Mon, 24 Apr 2017 21:12:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 X-Originating-IP: [10.177.19.20] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.58FDF9C9.0278, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: c4ee8d6b9276f5e9bbf42f5e3f041d79 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy] X-Received-From: 45.249.212.187 Subject: [Qemu-devel] [RFC PATCH] pci: deassert intx when pci device unrealize X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "wangxinxin.wang@huawei.com >> wangxin \(U\)" Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" If a pci device is not reset by VM (by writing into config space) and unplugged by VM, after that when VM reboots, qemu may assert: pcibus_reset: Assertion `bus->irq_count[i] == 0' failed Signed-off-by: herongguang --- Is there need to call pci_do_device_reset()? --- hw/pci/pci.c | 1 + 1 file changed, 1 insertion(+) -- 1.7.12.4 diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 259483b..afe6397 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1078,6 +1078,7 @@ static void pci_qdev_unrealize(DeviceState *dev, Error **errp) pci_unregister_io_regions(pci_dev); pci_del_option_rom(pci_dev); + pci_device_deassert_intx(pci_dev); if (pc->exit) { pc->exit(pci_dev);