From patchwork Wed Sep 23 08:08:05 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 521621 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id C635F14030B for ; Wed, 23 Sep 2015 18:08:33 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=CV207fwS; dkim-atps=neutral Received: from localhost ([::1]:46104 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zef6N-000502-KK for incoming@patchwork.ozlabs.org; Wed, 23 Sep 2015 04:08:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52301) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zef66-0004hv-Ra for qemu-devel@nongnu.org; Wed, 23 Sep 2015 04:08:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zef62-0001rs-Ff for qemu-devel@nongnu.org; Wed, 23 Sep 2015 04:08:14 -0400 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:33983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zef62-0001rU-8s for qemu-devel@nongnu.org; Wed, 23 Sep 2015 04:08:10 -0400 Received: by wicfx3 with SMTP id fx3so226050242wic.1 for ; Wed, 23 Sep 2015 01:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=g3KChUODQKuMy/e5QaGpmuWefigD8ev3gyE3sB62HjA=; b=CV207fwS736KkziPUGVbCBSS/cizNnlJeZ63S9zFniM4hbPkIy7s/+q65TZgu2LZPt W8yyUBJ5jhDaIfSDeJHoqoJkjbRQGRmCsk2LuAA201whtlOD1+8KnKsZES+bUQF4na1v B/wqxuSVaxRFhCcHTSGzW1T3fWgFkIHSmq29ChCCvp9WW9V/JpULt6i0kR9dqhwKe21B mW+oLhpERSja84u8aPV3/N3M/KsubW4mNwlPDTGxCBtjZSB3+UDqDTGn0ACzsvjX0eYC fyNnk/NbtxR5dLBllqoX9SM+DIP7BD0vPmTws0e4flnZCvnkJ7hJdtVrFgPSPz8asqD5 wtGw== X-Received: by 10.180.186.195 with SMTP id fm3mr2562521wic.1.1442995689421; Wed, 23 Sep 2015 01:08:09 -0700 (PDT) Received: from [192.168.10.165] ([94.39.140.123]) by smtp.googlemail.com with ESMTPSA id fx2sm7193177wib.24.2015.09.23.01.08.07 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 23 Sep 2015 01:08:08 -0700 (PDT) To: Pavel Dovgaluk , qemu-devel@nongnu.org References: <20150917162322.8676.29314.stgit@PASHA-ISP.def.inno> <20150917162439.8676.38290.stgit@PASHA-ISP.def.inno> <56015479.8020403@redhat.com> <1946.37127356163$1442992987@news.gmane.org> From: Paolo Bonzini Message-ID: <56025DE5.5040600@redhat.com> Date: Wed, 23 Sep 2015 10:08:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1946.37127356163$1442992987@news.gmane.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::236 Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, igor.rubinov@gmail.com, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, hines@cert.org, alex.bennee@linaro.org, fred.konrad@greensocs.com Subject: Re: [Qemu-devel] [PATCH v18 13/21] icount: improve counting for record/replay X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On 23/09/2015 09:22, Pavel Dovgaluk wrote: > Sometimes tcg thread halts in qemu_tcg_wait_io_event function, > waiting for any external event. Virtual clock does not run, because > warp is not called. warp call in main_loop_wait proceeds virtual > clock and allows tcg thread to run further. Ok, this makes sense! Would this work too as a replacement for this patch? Paolo diff --git a/cpus.c b/cpus.c index fbbd17f..9480acc 100644 --- a/cpus.c +++ b/cpus.c @@ -926,6 +926,7 @@ static void qemu_tcg_wait_io_event(CPUState *cpu) } while (iothread_requesting_mutex) { + qemu_clock_warp(QEMU_CLOCK_VIRTUAL); qemu_cond_wait(&qemu_io_proceeded_cond, &qemu_global_mutex); }