| Message ID | 54b43e8b5fe6acff6fe667062d412c0b224f92f6.1370237352.git.peter.crosthwaite@xilinx.com |
|---|---|
| State | New |
| Headers | show |
Am 03.06.2013 07:32, schrieb peter.crosthwaite@xilinx.com: > From: Peter Crosthwaite <peter.crosthwaite@xilinx.com> > > These comments we're a little difficult to read. First one had While we're picky: "were" - Paolo can you fix up in your queue? Andreas > incorrect parenthesis. The part about attributes changing is > really applicable to the region being 'in both' rather than 'in > new' > > Second comment has an obscure parenthetic about 'Logging may have > changed'. Made clearer, as this if is supposed to handle the case where > the memory region is unchanged (with the notable exception re logging). > > Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com> > --- > > memory.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/memory.c b/memory.c > index 60e033b..7e710c4 100644 > --- a/memory.c > +++ b/memory.c > @@ -719,7 +719,7 @@ static void address_space_update_topology_pass(AddressSpace *as, > || int128_lt(frold->addr.start, frnew->addr.start) > || (int128_eq(frold->addr.start, frnew->addr.start) > && !flatrange_equal(frold, frnew)))) { > - /* In old, but (not in new, or in new but attributes changed). */ > + /* In old but not in new, or in both but attributes changed. */ > > if (!adding) { > MEMORY_LISTENER_UPDATE_REGION(frold, as, Reverse, region_del); > @@ -727,7 +727,7 @@ static void address_space_update_topology_pass(AddressSpace *as, > > ++iold; > } else if (frold && frnew && flatrange_equal(frold, frnew)) { > - /* In both (logging may have changed) */ > + /* In both and unchanged (except logging may have changed) */ > > if (adding) { > MEMORY_LISTENER_UPDATE_REGION(frnew, as, Forward, region_nop); >
Il 04/06/2013 13:43, Andreas Färber ha scritto: > Am 03.06.2013 07:32, schrieb peter.crosthwaite@xilinx.com: >> > From: Peter Crosthwaite <peter.crosthwaite@xilinx.com> >> > >> > These comments we're a little difficult to read. First one had > While we're picky: "were" - Paolo can you fix up in your queue? Of course. Paolo
diff --git a/memory.c b/memory.c index 60e033b..7e710c4 100644 --- a/memory.c +++ b/memory.c @@ -719,7 +719,7 @@ static void address_space_update_topology_pass(AddressSpace *as, || int128_lt(frold->addr.start, frnew->addr.start) || (int128_eq(frold->addr.start, frnew->addr.start) && !flatrange_equal(frold, frnew)))) { - /* In old, but (not in new, or in new but attributes changed). */ + /* In old but not in new, or in both but attributes changed. */ if (!adding) { MEMORY_LISTENER_UPDATE_REGION(frold, as, Reverse, region_del); @@ -727,7 +727,7 @@ static void address_space_update_topology_pass(AddressSpace *as, ++iold; } else if (frold && frnew && flatrange_equal(frold, frnew)) { - /* In both (logging may have changed) */ + /* In both and unchanged (except logging may have changed) */ if (adding) { MEMORY_LISTENER_UPDATE_REGION(frnew, as, Forward, region_nop);