diff mbox

Exposing different e1000 models through cmdline

Message ID 54BE6144.4020108@kamp.de
State New
Headers show

Commit Message

Peter Lieven Jan. 20, 2015, 2:08 p.m. UTC 
Hi,

I found that vmware emulates a 82545em per default and so some special crafted appliances only
work with that card. I was wondering if the below is the right approach to make the
models selectable via cmdline without changing the default:



Thanks,
Peter

Comments

Michael S. Tsirkin Jan. 20, 2015, 2:09 p.m. UTC | #1 
On Tue, Jan 20, 2015 at 03:08:04PM +0100, Peter Lieven wrote:
> Hi,
> 
> I found that vmware emulates a 82545em per default and so some special crafted appliances only
> work with that card. I was wondering if the below is the right approach to make the
> models selectable via cmdline without changing the default:

No - please just use -device to create devices.

> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> index 371699c..632c4ba 100644
> --- a/hw/pci/pci.c
> +++ b/hw/pci/pci.c
> @@ -1578,6 +1578,9 @@ static const char * const pci_nic_models[] = {
>      "i82559er",
>      "rtl8139",
>      "e1000",
> +    "e1000-82540em",
> +    "e1000-82544gc",
> +    "e1000-82545em",
>      "pcnet",
>      "virtio",
>      NULL
> @@ -1590,6 +1593,9 @@ static const char * const pci_nic_names[] = {
>      "i82559er",
>      "rtl8139",
>      "e1000",
> +    "e1000-82540em",
> +    "e1000-82544gc",
> +    "e1000-82545em",
>      "pcnet",
>      "virtio-net-pci",
>      NULL
> 
> 
> Thanks,
> Peter
diff mbox

Patch

diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 371699c..632c4ba 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -1578,6 +1578,9 @@  static const char * const pci_nic_models[] = {
      "i82559er",
      "rtl8139",
      "e1000",
+    "e1000-82540em",
+    "e1000-82544gc",
+    "e1000-82545em",
      "pcnet",
      "virtio",
      NULL
@@ -1590,6 +1593,9 @@  static const char * const pci_nic_names[] = {
      "i82559er",
      "rtl8139",
      "e1000",
+    "e1000-82540em",
+    "e1000-82544gc",
+    "e1000-82545em",
      "pcnet",
      "virtio-net-pci",
      NULL