From patchwork Thu Jun 12 03:29:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Kardashevskiy X-Patchwork-Id: 358976 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 6E77F140096 for ; Thu, 12 Jun 2014 13:30:52 +1000 (EST) Received: from localhost ([::1]:50353 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wuvj0-0002mo-5b for incoming@patchwork.ozlabs.org; Wed, 11 Jun 2014 23:30:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuviW-0002mS-It for qemu-devel@nongnu.org; Wed, 11 Jun 2014 23:30:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WuviP-00047n-OI for qemu-devel@nongnu.org; Wed, 11 Jun 2014 23:30:20 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:49061) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuviP-00047b-JI for qemu-devel@nongnu.org; Wed, 11 Jun 2014 23:30:13 -0400 Received: by mail-pa0-f51.google.com with SMTP id ey11so517316pad.10 for ; Wed, 11 Jun 2014 20:30:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=YazSYgurjSi1Mh76Cl7gAEY3kH8SpAgC14mRhJ+eMag=; b=CpsAmSv9bg7y/1lSJr287Faq6GHPdC+1pIZV6wNN2RzhE9IH0Spe19GCwrhqJzmRa2 j2UYTndDgXpsNcHblUAiqVdajkf7fZRUZOPfvelA4A5aCLAarSqL80m3gKgiEFWjfA/c HPwiH4bSDLbG9rdT4Kv4JWceBgj3JXuqMLr+M2Q48eCkuX6ICMJpRAlXwnt0+Kszavpj z679HYNUS+wlxmEpMZc+bqZ/klbZc/0XwyGHwiaG2DFomzIdFVMpANfMeicSddCfu55A Wph0eVizJ63Rhu1BtQN8icoFVIuTC3Bdu/wUQMCWQcDfhy+/E/eSX1JN5nEKLdT2OPAy e7Lg== X-Gm-Message-State: ALoCoQlwJzUOAyi5ALzVrN5ApGImPuwP+PI0DTWZ0aly/4uXPloeZEFTBz/JOP5HF6g9cknolE5/ X-Received: by 10.68.197.195 with SMTP id iw3mr9717284pbc.139.1402543811936; Wed, 11 Jun 2014 20:30:11 -0700 (PDT) Received: from aik.ozlabs.ibm.com (ibmaus65.lnk.telstra.net. [165.228.126.9]) by mx.google.com with ESMTPSA id pw4sm58555765pbc.61.2014.06.11.20.30.02 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 11 Jun 2014 20:30:10 -0700 (PDT) Message-ID: <53991EB5.6010104@ozlabs.ru> Date: Thu, 12 Jun 2014 13:29:57 +1000 From: Alexey Kardashevskiy User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Eric Blake , qemu-devel@nongnu.org References: <1402506183-29736-1-git-send-email-aik@ozlabs.ru> <1402506183-29736-2-git-send-email-aik@ozlabs.ru> <53989009.1000300@redhat.com> <5398EFF6.7060603@ozlabs.ru> <5399067B.20009@redhat.com> In-Reply-To: <5399067B.20009@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.220.51 Cc: Peter Maydell , Alex Bligh , Markus Armbruster , Luiz Capitulino , Alexander Graf , qemu-ppc@nongnu.org, Stefan Hajnoczi , Cornelia Huck , Paolo Bonzini , Richard Henderson Subject: Re: [Qemu-devel] [PATCH v6 1/4] cpus: Define callback for QEMU "nmi" command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On 06/12/2014 11:46 AM, Eric Blake wrote: > On 06/11/2014 06:10 PM, Alexey Kardashevskiy wrote: > >>>> + * This program is free software; you can redistribute it and/or modify >>>> + * it under the terms of the GNU General Public License as published by >>>> + * the Free Software Foundation; either version 2 of the License, >>>> + * or (at your option) any later version. > >>> >>> For the GPL license to work, there has to be a Copyright line. >> >> Hm. Ok. include/hw/fw-path-provider.h (where I copied this from) does not >> have one and it was ok. > > Just because there's existing bad practice in the code base doesn't mean > new files should perpetuate it :) Paolo did that in the first place and if he does it, I assume this is at least not "bad" ;) Like this? I do not know what should be there, corporation or something or just me? --- a/hw/core/nmi.c +++ b/hw/core/nmi.c @@ -1,6 +1,8 @@ /* * NMI monitor handler class and helpers. * + * Copyright (c) 2014 Alexey Kardashevskiy + * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License,