From patchwork Thu Jun 5 15:16:54 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eric Blake X-Patchwork-Id: 356512 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 105A214007B for ; Fri, 6 Jun 2014 01:38:48 +1000 (EST) Received: from localhost ([::1]:42155 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsZkb-0003L5-QN for incoming@patchwork.ozlabs.org; Thu, 05 Jun 2014 11:38:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57734) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsZkB-0002g0-Ri for qemu-devel@nongnu.org; Thu, 05 Jun 2014 11:38:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WsZPX-0002tv-H7 for qemu-devel@nongnu.org; Thu, 05 Jun 2014 11:17:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63259) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WsZPX-0002t7-3W for qemu-devel@nongnu.org; Thu, 05 Jun 2014 11:16:59 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s55FGtEn006638 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 5 Jun 2014 11:16:56 -0400 Received: from [10.3.113.211] (ovpn-113-211.phx2.redhat.com [10.3.113.211]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s55FGsNP030323; Thu, 5 Jun 2014 11:16:54 -0400 Message-ID: <539089E6.3070800@redhat.com> Date: Thu, 05 Jun 2014 09:16:54 -0600 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org References: <1401968733-10998-1-git-send-email-benoit.canet@irqsave.net> <1401968733-10998-2-git-send-email-benoit.canet@irqsave.net> In-Reply-To: <1401968733-10998-2-git-send-email-benoit.canet@irqsave.net> X-Enigmail-Version: 1.6 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: kwolf@redhat.com, Benoit Canet , stefanha@redhat.com, lcapitulino@redhat.com Subject: Re: [Qemu-devel] [PATCH v2 1/5] qapi: Extract qapi/common.json definitions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On 06/05/2014 05:45 AM, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > qapi-schema.json | 87 ++---------------------------------------------------- > qapi/common.json | 89 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 91 insertions(+), 85 deletions(-) > create mode 100644 qapi/common.json Reviewed-by: Eric Blake Much nicer. Here's the intra-diff showing that the motion is fairly straightforward: $ diff -u <(sed -n 's/^-//p' patch1) \ <(sed -n 's/^\+//p' patch1) --- /dev/fd/63 2014-06-05 09:15:37.189091311 -0600 +++ /dev/fd/62 2014-06-05 09:15:37.190091308 -0600 @@ -1,5 +1,11 @@ --- --- a/qapi-schema.json +++ b/qapi-schema.json +# QAPI common definitions +{ 'include': 'qapi/common.json' } +++ b/qapi/common.json +# -*- Mode: Python -*- +# +# QAPI common definitions + ## # @ErrorClass # @@ -26,6 +32,7 @@ 'data': [ 'GenericError', 'CommandNotFound', 'DeviceEncrypted', 'DeviceNotActive', 'DeviceNotFound', 'KVMMissingCap' ] } +## # @VersionInfo: # # A description of QEMU's version. @@ -84,6 +91,3 @@ ## { 'command': 'query-commands', 'returns': ['CommandInfo'] } -## --- /dev/null --