diff mbox

pc: Fix disabling of vapic for compat PC models

Message ID 5353DCFA.4050904@web.de
State New
Headers show

Commit Message

Jan Kiszka April 20, 2014, 2:43 p.m. UTC 
From: Jan Kiszka <jan.kiszka@siemens.com>

We used to be able to address both the QEMU and the KVM APIC via "apic".
This doesn't work anymore. So we need to use their parent class to turn
off the vapic on machines that should not expose them.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

I'm pretty sure it was like this, that -global apic.vapic=off also
worked for -enable-kvm, ie. the KVM APIC. If someone could explain what
changes, probably around QOM - maybe we can restore the original
behavior and skip this patch.

 hw/i386/pc_piix.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 7930a26..12ee716 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -566,7 +566,7 @@  static QEMUMachine pc_machine_v1_1 = {
             .property = "class",\
             .value    = stringify(PCI_CLASS_MEMORY_RAM),\
         },{\
-            .driver   = "apic",\
+            .driver   = "apic-common",\
             .property = "vapic",\
             .value    = "off",\
         },{\