From patchwork Sat Mar 1 17:35:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Gang X-Patchwork-Id: 325471 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id E77962C00C3 for ; Sun, 2 Mar 2014 04:35:24 +1100 (EST) Received: from localhost ([::1]:60428 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJnoo-0008B7-In for incoming@patchwork.ozlabs.org; Sat, 01 Mar 2014 12:35:22 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJnoQ-000874-Ip for qemu-devel@nongnu.org; Sat, 01 Mar 2014 12:35:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJnoH-00013R-Of for qemu-devel@nongnu.org; Sat, 01 Mar 2014 12:34:58 -0500 Received: from mail-pa0-x230.google.com ([2607:f8b0:400e:c03::230]:46933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJnoH-00012E-Gn for qemu-devel@nongnu.org; Sat, 01 Mar 2014 12:34:49 -0500 Received: by mail-pa0-f48.google.com with SMTP id kx10so2095127pab.21 for ; Sat, 01 Mar 2014 09:34:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=IWMHkpsTH1sKiZ0KyTV1I5U+v96zwY7Nw2OCmTlrvV4=; b=SqoIh1qEg9POegJvLrFmq6eQSPBWsDVEwHotaIGhVVs/np/65f1XwId5FHskQBsrFW sSbBnFYhMdCdwse1MgRiqjSA87cZiUH4L0uo5PjMVFcxh39xBZXHkcLu4NXKGETNWVRt Ey111OaGwNkqOB1FK/72vlSZ3EK0EWpbidSaNktM5JDfACfg0LB5c5YxCm/h0ExhtRdn guEyKddSQIKRYatrYCs4fBFbuIv6D6/xaWcGZRwj/m7ZmPg14FpBmQjLCJuMC6IwyNQ9 rKeWkpW9SdUg5ZYrEmT9ifIhb+0df7xTwJMkMi0aFfN1HyPUYipc64vhiDsogtFspC3n TMwQ== X-Received: by 10.67.23.135 with SMTP id ia7mr10242499pad.5.1393695288525; Sat, 01 Mar 2014 09:34:48 -0800 (PST) Received: from [192.168.1.102] ([223.72.65.28]) by mx.google.com with ESMTPSA id iq10sm18217569pbc.14.2014.03.01.09.34.46 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sat, 01 Mar 2014 09:34:48 -0800 (PST) Message-ID: <53121A4B.70308@gmail.com> Date: Sun, 02 Mar 2014 01:35:07 +0800 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Markus Armbruster , "Aneesh Kumar K.V" , aliguori@amazon.com, Eric Blake , "Daniel P. Berrange" References: <52EF68CA.9060604@gmail.com> <20140203103429.GB10408@redhat.com> <52EF71DC.3000309@gmail.com> <52F0C8BA.7020709@gmail.com> <20140204110631.GD5632@redhat.com> <52F0CD67.5070601@gmail.com> <87siry3l7t.fsf@linux.vnet.ibm.com> <52F17B5E.1050602@gmail.com> <52FF3182.9090106@gmail.com> <53097D8E.1030803@gmail.com> <87sir850ho.fsf@blackfin.pond.sub.org> <87ha7o3c5x.fsf@blackfin.pond.sub.org> <530FCBAD.10305@gmail.com> <531219CC.4050505@gmail.com> <53121A12.5050105@gmail.com> In-Reply-To: <53121A12.5050105@gmail.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::230 Cc: QEMU Developers Subject: [Qemu-devel] [PATCH 2/3] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org 'ctx->fs_root' + 'path'/'fullname.data' may be larger than PATH_MAX, so need use snprintf() instead of sprintf() just like another area have done in 9pfs. Signed-off-by: Chen Gang Reviewed-by: Aneesh Kumar K.V --- hw/9pfs/virtio-9p-local.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c index 77a04cd..61be75a 100644 --- a/hw/9pfs/virtio-9p-local.c +++ b/hw/9pfs/virtio-9p-local.c @@ -898,7 +898,8 @@ static int local_remove(FsContext *ctx, const char *path) * directory */ if (S_ISDIR(stbuf.st_mode)) { - sprintf(buffer, "%s/%s/%s", ctx->fs_root, path, VIRTFS_META_DIR); + snprintf(buffer, ARRAY_SIZE(buffer), "%s/%s/%s", + ctx->fs_root, path, VIRTFS_META_DIR); err = remove(buffer); if (err < 0 && errno != ENOENT) { /* @@ -1033,8 +1034,8 @@ static int local_unlinkat(FsContext *ctx, V9fsPath *dir, * If directory remove .virtfs_metadata contained in the * directory */ - sprintf(buffer, "%s/%s/%s", ctx->fs_root, - fullname.data, VIRTFS_META_DIR); + snprintf(buffer, ARRAY_SIZE(buffer), "%s/%s/%s", ctx->fs_root, + fullname.data, VIRTFS_META_DIR); ret = remove(buffer); if (ret < 0 && errno != ENOENT) { /*