From patchwork Wed May 22 01:21:04 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qiao Nuohan X-Patchwork-Id: 245475 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B614A2C00AA for ; Wed, 22 May 2013 11:21:30 +1000 (EST) Received: from localhost ([::1]:56780 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uexk8-0003Sp-Hw for incoming@patchwork.ozlabs.org; Tue, 21 May 2013 21:21:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44370) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uexjr-0003Sc-B8 for qemu-devel@nongnu.org; Tue, 21 May 2013 21:21:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uexjn-0005au-4X for qemu-devel@nongnu.org; Tue, 21 May 2013 21:21:11 -0400 Received: from [222.73.24.84] (port=39370 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uexjm-0005aY-Qg for qemu-devel@nongnu.org; Tue, 21 May 2013 21:21:07 -0400 X-IronPort-AV: E=Sophos;i="4.87,718,1363104000"; d="scan'208";a="7328725" Received: from unknown (HELO tang.cn.fujitsu.com) ([10.167.250.3]) by song.cn.fujitsu.com with ESMTP; 22 May 2013 09:18:11 +0800 Received: from fnstmail02.fnst.cn.fujitsu.com (tang.cn.fujitsu.com [127.0.0.1]) by tang.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id r4M1KrlY003817; Wed, 22 May 2013 09:20:55 +0800 Received: from localhost.localdomain ([10.167.226.41]) by fnstmail02.fnst.cn.fujitsu.com (Lotus Domino Release 8.5.3) with ESMTP id 2013052209193560-1415103 ; Wed, 22 May 2013 09:19:35 +0800 Message-ID: <519C1D80.6090707@cn.fujitsu.com> Date: Wed, 22 May 2013 09:21:04 +0800 From: Qiao Nuohan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.5) Gecko/20120607 Thunderbird/10.0.5 MIME-Version: 1.0 To: =?ISO-8859-1?Q?Andreas_F=E4rber?= References: <1369105221-26307-1-git-send-email-qiaonuohan@cn.fujitsu.com> <519B112E.7040100@linux.vnet.ibm.com> <519B5B66.2000806@suse.de> <519B6326.1000607@cn.fujitsu.com> <519BA6A5.7090906@suse.de> In-Reply-To: <519BA6A5.7090906@suse.de> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/05/22 09:19:35, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/05/22 09:19:41, Serialize complete at 2013/05/22 09:19:41 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 222.73.24.84 Cc: aliguori@us.ibm.com, Jesse Larrew , qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH] Fix mask of pte index X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Function walk_pte needs pte index to calculate virtual address. However, pte index of PAE paging or IA-32e paging is 9 bit, so the mask should be 0x1ff. Signed-off-by: Qiao Nuohan --- target-i386/arch_memory_mapping.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) } diff --git a/target-i386/arch_memory_mapping.c b/target-i386/arch_memory_mapping.c index 844893f..a2eb7e7 100644 --- a/target-i386/arch_memory_mapping.c +++ b/target-i386/arch_memory_mapping.c @@ -38,7 +38,7 @@ static void walk_pte(MemoryMappingList *list, hwaddr pte_start_addr, continue; } - start_vaddr = start_line_addr | ((i & 0x1fff) << 12); + start_vaddr = start_line_addr | ((i & 0x1ff) << 12); memory_mapping_list_add_merge_sorted(list, start_paddr, start_vaddr, 1 << 12);