From patchwork Mon Dec 10 06:16:29 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Spencer X-Patchwork-Id: 204820 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 51FBA2C007E for ; Mon, 10 Dec 2012 17:16:31 +1100 (EST) Received: from localhost ([::1]:44997 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThwfF-0007Rq-Bo for incoming@patchwork.ozlabs.org; Mon, 10 Dec 2012 01:16:29 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Thwf5-0007RU-2a for qemu-devel@nongnu.org; Mon, 10 Dec 2012 01:16:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Thwf2-0002TD-Gh for qemu-devel@nongnu.org; Mon, 10 Dec 2012 01:16:19 -0500 Received: from furnace.wzff.de ([176.9.216.40]:55597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Thwev-0002RH-2N; Mon, 10 Dec 2012 01:16:09 -0500 Received: from xdsl-188-155-204-150.adslplus.ch ([188.155.204.150] helo=[10.1.1.4]) by furnace.wzff.de with esmtpsa (TLSv1:DHE-RSA-CAMELLIA256-SHA:256) (Exim 4.80.1 (FreeBSD)) (envelope-from ) id 1Thwes-000Jl8-Gz; Mon, 10 Dec 2012 07:16:08 +0100 Message-ID: <50C57E3D.9010708@barfooze.de> Date: Mon, 10 Dec 2012 07:16:29 +0100 From: John Spencer User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.14) Gecko/20110221 SUSE/3.1.8 Mail/1.0 MIME-Version: 1.0 To: qemu-trivial@nongnu.org X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 176.9.216.40 Cc: qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Reviewed-by: Stefan Weil From 3d9bc5e06ae64806003f8999b4b7ead42bd19c5d Mon Sep 17 00:00:00 2001 From: John Spencer Date: Mon, 10 Dec 2012 07:02:49 +0100 Subject: [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups() this declaration is wrong: the correct prototype on linux is: int setgroups(size_t size, const gid_t *list); since by default musl libc exposes this symbol in unistd.h additionally to grp.h, the wrong declaration causes a build error. the proper fix is to simply include the correct header. Signed-off-by: John Spencer --- linux-user/syscall.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index fabbcd7..665316e 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include #include @@ -585,7 +586,6 @@ extern int personality(int); extern int flock(int, int); extern int setfsuid(int); extern int setfsgid(int); -extern int setgroups(int, gid_t *); /* ARM EABI and MIPS expect 64bit types aligned even on pairs or registers */ #ifdef TARGET_ARM -- 1.7.3.4