From patchwork Sat Nov 17 15:20:28 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Lieven X-Patchwork-Id: 199858 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D03A42C007E for ; Sun, 18 Nov 2012 02:20:47 +1100 (EST) Received: from localhost ([::1]:54952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZkCL-0002hQ-8w for incoming@patchwork.ozlabs.org; Sat, 17 Nov 2012 10:20:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZkC9-0002gp-Pj for qemu-devel@nongnu.org; Sat, 17 Nov 2012 10:20:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZkC6-0002Qa-Ni for qemu-devel@nongnu.org; Sat, 17 Nov 2012 10:20:33 -0500 Received: from ssl.dlhnet.de ([91.198.192.8]:54160 helo=ssl.dlh.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZkC6-0002QO-AA for qemu-devel@nongnu.org; Sat, 17 Nov 2012 10:20:30 -0500 Received: from localhost (localhost [127.0.0.1]) by ssl.dlh.net (Postfix) with ESMTP id 1E6BE14CAF7; Sat, 17 Nov 2012 16:20:29 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ssl.dlh.net Received: from ssl.dlh.net ([127.0.0.1]) by localhost (ssl.dlh.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VYjoeKUeZtcs; Sat, 17 Nov 2012 16:20:28 +0100 (CET) Received: from [82.141.7.8] (unknown [82.141.7.8]) by ssl.dlh.net (Postfix) with ESMTPSA id 53E4E14CAF2; Sat, 17 Nov 2012 16:20:28 +0100 (CET) Message-ID: <50A7AB3C.4070902@dlhnet.de> Date: Sat, 17 Nov 2012 16:20:28 +0100 From: Peter Lieven User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0 MIME-Version: 1.0 To: "qemu-devel@nongnu.org" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 91.198.192.8 Cc: Kevin Wolf , Paolo Bonzini , ronnie sahlberg Subject: [Qemu-devel] [PATCH] iscsi: do not assume device is zero initialized X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Without any complex checks we can't assume that an iscsi target is initialized to zero. Signed-off-by: Peter Lieven --- block/iscsi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index eb586cb..d685f20 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -991,6 +991,11 @@ out: return ret; } +static int iscsi_has_zero_init(BlockDriverState *bs) +{ + return 0; +} + static QEMUOptionParameter iscsi_create_options[] = { { .name = BLOCK_OPT_SIZE, @@ -1017,6 +1022,7 @@ static BlockDriver bdrv_iscsi = { .bdrv_aio_flush = iscsi_aio_flush, .bdrv_aio_discard = iscsi_aio_discard, + .bdrv_has_zero_init = iscsi_has_zero_init, #ifdef __linux__ .bdrv_ioctl = iscsi_ioctl,