diff mbox

[2/3] runstate: introduce suspended state

Message ID 4FA3DF92.9080208@redhat.com
State New
Headers show

Commit Message

Gerd Hoffmann May 4, 2012, 1:54 p.m. UTC 
Hi,

> There's a quite simple and stupid way to do it. When we migrate an stopped
> VM, it's automatically resumed on the target. We could do the same for a
> suspended VM: we could automatically resume it before migrating, as you said
> above.
> 
> That's not the behavior I'd expect, I mean I would expect a stopped VM to
> remain stopped after it's migrated. But it has always been this way and I'm
> afraid we can't change this.

Oh, I wasn't aware that a stopped vm behaves the same way.  So resuming
on migration is sort-of bug compatible then.  Patch attached.  Will you
add it to your series or should I submit it separately?

cheers,
  Gerd
From 566ec2adacfa570e9d08067e242a6b7224c46c8e Mon Sep 17 00:00:00 2001
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 7 Mar 2012 08:00:26 +0100
Subject: [PATCH] wakeup on migration

Wakeup the guest when the live part of the migation is finished.
This avoids being in suspended state on migration, so we don't
have to save the is_suspended bit.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 migration.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Luiz Capitulino May 4, 2012, 2 p.m. UTC | #1 
On Fri, 04 May 2012 15:54:26 +0200
Gerd Hoffmann <kraxel@redhat.com> wrote:

>   Hi,
> 
> > There's a quite simple and stupid way to do it. When we migrate an stopped
> > VM, it's automatically resumed on the target. We could do the same for a
> > suspended VM: we could automatically resume it before migrating, as you said
> > above.
> > 
> > That's not the behavior I'd expect, I mean I would expect a stopped VM to
> > remain stopped after it's migrated. But it has always been this way and I'm
> > afraid we can't change this.
> 
> Oh, I wasn't aware that a stopped vm behaves the same way.  So resuming
> on migration is sort-of bug compatible then.  Patch attached.  Will you
> add it to your series or should I submit it separately?

I can add it to my series, thanks Gerd!
diff mbox

Patch

diff --git a/migration.c b/migration.c
index 94f7839..f9e968e 100644
--- a/migration.c
+++ b/migration.c
@@ -252,6 +252,7 @@  static void migrate_fd_put_ready(void *opaque)
         int old_vm_running = runstate_is_running();
 
         DPRINTF("done iterating\n");
+        qemu_system_wakeup_request(QEMU_WAKEUP_REASON_OTHER);
         vm_stop_force_state(RUN_STATE_FINISH_MIGRATE);
 
         if (qemu_savevm_state_complete(s->file) < 0) {