diff mbox

[2/2] seabios: fix mptable nmi entry (was: Re: [PATCH] qemu: Fix inject-nmi)

Message ID 4E928B65.4080701@cn.fujitsu.com
State New
Headers show

Commit Message

Lai Jiangshan Oct. 10, 2011, 6:06 a.m. UTC
From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>

In the current seabios MP table description, NMI is connected only to
BSP's LINT1. But usually NMI is connected to all the CPUs' LINT1 as
indicated in MP specification. This patch changes seabios MP table to
describe NMI is connected to all the CPUs' LINT1.

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Reviewed-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
 src/mptable.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kevin O'Connor Oct. 30, 2011, 5:52 p.m. UTC | #1
On Mon, Oct 10, 2011 at 02:06:29PM +0800, Lai Jiangshan wrote:
> From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
> 
> In the current seabios MP table description, NMI is connected only to
> BSP's LINT1. But usually NMI is connected to all the CPUs' LINT1 as
> indicated in MP specification. This patch changes seabios MP table to
> describe NMI is connected to all the CPUs' LINT1.

Thanks - I applied both of these patches.

-Kevin
diff mbox

Patch

Index: seabios/src/mptable.c
===================================================================
--- seabios.orig/src/mptable.c
+++ seabios/src/mptable.c
@@ -169,7 +169,7 @@  mptable_init(void)
     intsrc->irqflag = 0; /* PO, EL default */
     intsrc->srcbus = isabusid; /* ISA */
     intsrc->srcbusirq = 0;
-    intsrc->dstapic = 0; /* BSP == APIC #0 */
+    intsrc->dstapic = 0xff; /* to all local APICs */
     intsrc->dstirq = 1; /* LINTIN1 */
     intsrc++;
     entrycount += intsrc - intsrcs;